Remove extra DNP condition in FP rendering path

DNP footprints have a control layer for if they should be shown, which
is handled by the IsFootprintShown() method, so we shouldn't gate them
unconditionally just because of their DNP property.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/23316
This commit is contained in:
Ian McInerney
2026-03-03 18:53:00 +00:00
parent 764fb31877
commit 40205eb181
2 changed files with 0 additions and 8 deletions
@@ -1070,10 +1070,6 @@ void RENDER_3D_OPENGL::get3dModelsSelected( std::list<MODELTORENDER> &aDstRender
{
if( m_boardAdapter.IsFootprintShown( fp ) )
{
// Skip 3D models for footprints that are DNP in the current variant
if( fp->GetDNPForVariant( currentVariant ) )
continue;
const bool isFlipped = fp->IsFlipped();
if( aGetTop == !isFlipped || aGetBot == isFlipped )
@@ -1931,10 +1931,6 @@ void RENDER_3D_RAYTRACE_BASE::load3DModels( CONTAINER_3D& aDstContainer,
if( !fp->Models().empty()
&& m_boardAdapter.IsFootprintShown( fp ) )
{
// Skip 3D models for footprints that are DNP in the current variant
if( fp->GetDNPForVariant( currentVariant ) )
continue;
double zpos = m_boardAdapter.GetFootprintZPos( fp->IsFlipped() );
VECTOR2I pos = fp->GetPosition();