electron-rare/kicad-source-mirror
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pcbnew: Fix VRML export checking

Browse Source 
In rare cases, the VRML triangulator may claim to work but return empty
vectors.  These cases need to be caught before we dereference the vector
elements.

Fixes: lp:1838448
* https://bugs.launchpad.net/kicad/+bug/1838448
This commit is contained in:
Seth Hillbrand
2019-07-31 20:02:11 -07:00
parent 090073cc3b
commit 161dc9ce7e
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pcbnew/exporters/export_vrml.cpp
+4 -2
View File
@@ -1702,7 +1702,8 @@ static void create_vrml_plane( IFSG_TRANSFORM& PcbOutput, VRML_COLOR_INDEX color
std::vector< int > idxPlane;
std::vector< int > idxSide;
if( !(*layer).Get2DTriangles( vertices, idxPlane, top_z, aTopPlane ) )
if( !( *layer ).Get2DTriangles( vertices, idxPlane, top_z, aTopPlane ) || idxPlane.empty()
|| idxSide.empty() )
{
#ifdef DEBUG
do {
@@ -1788,7 +1789,8 @@ static void create_vrml_shell( IFSG_TRANSFORM& PcbOutput, VRML_COLOR_INDEX color
bottom_z = tmp;
}
if( !(*layer).Get3DTriangles( vertices, idxPlane, idxSide, top_z, bottom_z ) )
if( !( *layer ).Get3DTriangles( vertices, idxPlane, idxSide, top_z, bottom_z )
|| idxPlane.empty() || idxSide.empty() )
{
#ifdef DEBUG
do {