electron-rare/kicad-source-mirror
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix memory leak in Python pcbnew.FootprintLoad()

Browse Source 
PCB_IO_MGR::FindPlugin() returns a new PCB_IO* that the caller owns. The
Python wrapper functions (FootprintLoad, FootprintSave, etc.) in
footprint.i call GetPluginForPath which calls FindPlugin, but the
returned plugin object was never deleted because SWIG didn't know
Python owned it.

The %newobject directive tells SWIG that Python owns the returned
PCB_IO* and should delete it when the Python object is garbage
collected.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/22526
This commit is contained in:
Seth Hillbrand
2026-01-06 04:45:06 -08:00
parent 127a85f753
commit 0f0fbc55d7
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pcbnew/python/swig/pcbnew.i
+5
View File
@@ -94,6 +94,11 @@ wxArrayString GetFootprints(const wxString& aNickName);
%}
// Tell SWIG that the caller owns the PCB_IO* returned by FindPlugin and is
// responsible for deleting it. This fixes memory leaks in Python wrapper
// functions like FootprintLoad that call GetPluginForPath -> FindPlugin.
%newobject PCB_IO_MGR::FindPlugin;
%include <pcb_io/pcb_io_mgr.h>
%include <pcb_io/pcb_io.h>