diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-ai.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-ai.spec.ts index 0a3885fd..170dbf7e 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-ai.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-ai.spec.ts @@ -47,9 +47,9 @@ test.describe('Doc AI feature', () => { await page.locator('.bn-block-outer').last().fill('Anything'); await page.getByText('Anything').selectText(); - expect( - await page.locator('button[data-test="convertMarkdown"]').count(), - ).toBe(1); + await expect( + page.locator('button[data-test="convertMarkdown"]'), + ).toHaveCount(1); await expect( page.getByRole('button', { name: config.selector, exact: true }), ).toBeHidden(); diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-editor.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-editor.spec.ts index 8f8d9694..fc6aee7d 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-editor.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-editor.spec.ts @@ -155,13 +155,11 @@ test.describe('Doc Editor', () => { expect(wsClose.isClosed()).toBeTruthy(); // Check the ws is connected again - webSocketPromise = page.waitForEvent('websocket', (webSocket) => { + webSocket = await page.waitForEvent('websocket', (webSocket) => { return webSocket .url() .includes('ws://localhost:4444/collaboration/ws/?room='); }); - - webSocket = await webSocketPromise; framesentPromise = webSocket.waitForEvent('framesent'); framesent = await framesentPromise; expect(framesent.payload).not.toBeNull(); @@ -578,12 +576,10 @@ test.describe('Doc Editor', () => { await page.reload(); - responseCanEditPromise = page.waitForResponse( + responseCanEdit = await page.waitForResponse( (response) => response.url().includes(`/can-edit/`) && response.status() === 200, ); - - responseCanEdit = await responseCanEditPromise; expect(responseCanEdit.ok()).toBeTruthy(); jsonCanEdit = (await responseCanEdit.json()) as { can_edit: boolean }; diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts index 7496792c..3c165050 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts @@ -236,7 +236,7 @@ test.describe('Doc Header', () => { hasText: randomDoc, }); - expect(await row.count()).toBe(0); + await expect(row).toHaveCount(0); }); test('it checks the options available if administrator', async ({ page }) => { @@ -273,7 +273,7 @@ test.describe('Doc Header', () => { await expect(getMenuItem(page, 'Delete document')).toBeDisabled(); // Click somewhere else to close the options - await page.click('body', { position: { x: 0, y: 0 } }); + await page.locator('body').click({ position: { x: 0, y: 0 } }); await page.getByRole('button', { name: 'Share' }).click(); @@ -348,7 +348,7 @@ test.describe('Doc Header', () => { await expect(getMenuItem(page, 'Delete document')).toBeDisabled(); // Click somewhere else to close the options - await page.click('body', { position: { x: 0, y: 0 } }); + await page.locator('body').click({ position: { x: 0, y: 0 } }); await page.getByRole('button', { name: 'Share' }).click(); @@ -418,7 +418,7 @@ test.describe('Doc Header', () => { await expect(getMenuItem(page, 'Delete document')).toBeDisabled(); // Click somewhere else to close the options - await page.click('body', { position: { x: 0, y: 0 } }); + await page.locator('body').click({ position: { x: 0, y: 0 } }); await page.getByRole('button', { name: 'Share' }).click(); diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-import.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-import.spec.ts index f5269bce..d1b4ad79 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-import.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-import.spec.ts @@ -177,5 +177,5 @@ const dragAndDropFiles = async ( return dt; }, filesData); - await page.dispatchEvent(selector, 'drop', { dataTransfer }); + await page.locator(selector).dispatchEvent('drop', { dataTransfer }); }; diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-tree.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-tree.spec.ts index b0cbd1cf..20c24bce 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-tree.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-tree.spec.ts @@ -43,15 +43,12 @@ test.describe('Doc Tree', () => { await expect(secondSubPageItem).toBeVisible(); // Check the position of the sub pages - const allSubPageItems = await docTree - .getByTestId(/^doc-sub-page-item/) - .all(); - - expect(allSubPageItems.length).toBe(2); + const allSubPageItems = docTree.getByTestId(/^doc-sub-page-item/); + await expect(allSubPageItems).toHaveCount(2); // Check that elements are in the correct order - await expect(allSubPageItems[0].getByText('first move')).toBeVisible(); - await expect(allSubPageItems[1].getByText('second move')).toBeVisible(); + await expect(allSubPageItems.nth(0).getByText('first move')).toBeVisible(); + await expect(allSubPageItems.nth(1).getByText('second move')).toBeVisible(); // Will move the first sub page to the second position const firstSubPageBoundingBox = await firstSubPageItem.boundingBox(); @@ -91,17 +88,15 @@ test.describe('Doc Tree', () => { await expect(secondSubPageItem).toBeVisible(); // Check that elements are in the correct order - const allSubPageItemsAfterReload = await docTree - .getByTestId(/^doc-sub-page-item/) - .all(); - - expect(allSubPageItemsAfterReload.length).toBe(2); + const allSubPageItemsAfterReload = + docTree.getByTestId(/^doc-sub-page-item/); + await expect(allSubPageItemsAfterReload).toHaveCount(2); await expect( - allSubPageItemsAfterReload[0].getByText('second move'), + allSubPageItemsAfterReload.nth(0).getByText('second move'), ).toBeVisible(); await expect( - allSubPageItemsAfterReload[1].getByText('first move'), + allSubPageItemsAfterReload.nth(1).getByText('first move'), ).toBeVisible(); }); diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-version.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-version.spec.ts index 2f52f139..87441eec 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-version.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-version.spec.ts @@ -80,9 +80,9 @@ test.describe('Doc Version', () => { await expect(panel).toBeVisible(); await expect(page.getByText('History', { exact: true })).toBeVisible(); await expect(page.getByRole('status')).toBeHidden(); - const items = await panel.locator('.version-item').all(); - expect(items.length).toBe(2); - await items[1].click(); + const items = panel.locator('.version-item'); + await expect(items).toHaveCount(2); + await items.nth(1).click(); await expect(modal.getByText('Hello World')).toBeVisible(); await expect(modal.getByText('It will create a version')).toBeHidden(); @@ -90,7 +90,7 @@ test.describe('Doc Version', () => { modal.locator('div[data-content-type="callout"]').first(), ).toBeHidden(); - await items[0].click(); + await items.nth(0).click(); await expect(modal.getByText('Hello World')).toBeVisible(); await expect(modal.getByText('It will create a version')).toBeVisible(); @@ -101,7 +101,7 @@ test.describe('Doc Version', () => { modal.getByText('It will create a second version'), ).toBeHidden(); - await items[1].click(); + await items.nth(1).click(); await expect(modal.getByText('Hello World')).toBeVisible(); await expect(modal.getByText('It will create a version')).toBeHidden();