From 225f5a8abb0a6dd40773ae94884fbfc2a08fb655 Mon Sep 17 00:00:00 2001
From: Your name <marine.marchandb@etik.com>
Date: Fri, 31 Jan 2025 13:23:05 +0100
Subject: [PATCH] =?UTF-8?q?erreur=20du=20commit=20pr=C3=A9cedent?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

je ne commite que les modifications annoncées dans le commit précédent
---
 .../impress/src/components/DropButton.tsx     | 21 ++++------
 .../impress/src/components/DropdownMenu.tsx   | 38 +++++++++----------
 .../apps/impress/src/components/Icon.tsx      | 24 +-----------
 .../apps/impress/src/components/Text.tsx      |  1 -
 4 files changed, 27 insertions(+), 57 deletions(-)

diff --git a/src/frontend/apps/impress/src/components/DropButton.tsx b/src/frontend/apps/impress/src/components/DropButton.tsx
index dc1188d5..92aaca69 100644
--- a/src/frontend/apps/impress/src/components/DropButton.tsx
+++ b/src/frontend/apps/impress/src/components/DropButton.tsx
@@ -56,22 +56,17 @@ export const DropButton = ({
 
   return (
     <>
-      {/* Bouton activant le menu avec les propriétés ARIA */}
-      <StyledButton
-        ref={triggerRef}
-        aria-haspopup="menu"
-        aria-expanded={isLocalOpen}
-        onPress={() => onOpenChangeHandler(true)}
-      >
+      <StyledButton ref={triggerRef} onPress={() => onOpenChangeHandler(true)}>
         <span aria-hidden="true">{button}</span>
       </StyledButton>
 
-      {/* Menu accessible */}
-      {isLocalOpen && (
-        <StyledPopover as="div" role="menu">
-          {children}
-        </StyledPopover>
-      )}
+      <StyledPopover
+        triggerRef={triggerRef}
+        isOpen={isLocalOpen}
+        onOpenChange={onOpenChangeHandler}
+      >
+        {children}
+      </StyledPopover>
     </>
   );
 };
diff --git a/src/frontend/apps/impress/src/components/DropdownMenu.tsx b/src/frontend/apps/impress/src/components/DropdownMenu.tsx
index 2dd39b2f..815e0e1f 100644
--- a/src/frontend/apps/impress/src/components/DropdownMenu.tsx
+++ b/src/frontend/apps/impress/src/components/DropdownMenu.tsx
@@ -1,3 +1,4 @@
+//import { t } from 'i18next';
 import { PropsWithChildren, useState } from 'react';
 import { css } from 'styled-components';
 
@@ -55,19 +56,16 @@ export const DropdownMenu = ({
         showArrow ? (
           <Box $direction="row" $align="center">
             <div>{children}</div>
-            <span aria-hidden="true">
-              <Icon
-                role="presentation"
-                $variation="600"
-                $css={
-                  arrowCss ??
-                  css`
-                    color: var(--c--theme--colors--primary-600);
-                  `
-                }
-                iconName={isOpen ? 'arrow_drop_up' : 'arrow_drop_down'}
-              />
-            </span>
+            <Icon
+              $variation="600"
+              $css={
+                arrowCss ??
+                css`
+                  color: var(--c--theme--colors--primary-600);
+                `
+              }
+              iconName={isOpen ? 'arrow_drop_up' : 'arrow_drop_down'}
+            />
           </Box>
         ) : (
           children
@@ -136,14 +134,12 @@ export const DropdownMenu = ({
             >
               <Box $direction="row" $align="center" $gap={spacings['base']}>
                 {option.icon && (
-                  <span aria-hidden="true">
-                    <Icon
-                      $size="20px"
-                      $theme="greyscale"
-                      $variation={isDisabled ? '400' : '1000'}
-                      iconName={option.icon}
-                    />
-                  </span>
+                  <Icon
+                    $size="20px"
+                    $theme="greyscale"
+                    $variation={isDisabled ? '400' : '1000'}
+                    iconName={option.icon}
+                  />
                 )}
                 <Text $variation={isDisabled ? '400' : '1000'}>
                   {option.label}
diff --git a/src/frontend/apps/impress/src/components/Icon.tsx b/src/frontend/apps/impress/src/components/Icon.tsx
index e877a6cb..224f87b6 100644
--- a/src/frontend/apps/impress/src/components/Icon.tsx
+++ b/src/frontend/apps/impress/src/components/Icon.tsx
@@ -8,27 +8,8 @@ type IconProps = TextType & {
 };
 export const Icon = ({ iconName, ...textProps }: IconProps) => {
   return (
-    <Text
-      $isMaterialIcon
-      {...textProps}
-      aria-hidden="true"
-      $css={`
-        visibility: hidden;
-        display: inline-block;
-        position: relative;
-      `}
-    >
-      <span
-        aria-hidden="true"
-        style={{
-          position: 'absolute',
-          top: 0,
-          left: 0,
-          visibility: 'visible',
-        }}
-      >
-        {iconName}
-      </span>
+    <Text $isMaterialIcon {...textProps}>
+      {iconName}
     </Text>
   );
 };
@@ -43,7 +24,6 @@ export const IconBG = ({ iconName, ...textProps }: IconBGProps) => {
   return (
     <Text
       $isMaterialIcon
-      aria-hidden="true"
       $size="36px"
       $theme="primary"
       $variation="600"
diff --git a/src/frontend/apps/impress/src/components/Text.tsx b/src/frontend/apps/impress/src/components/Text.tsx
index edf0cf27..2764f74c 100644
--- a/src/frontend/apps/impress/src/components/Text.tsx
+++ b/src/frontend/apps/impress/src/components/Text.tsx
@@ -68,7 +68,6 @@ const Text = forwardRef<HTMLElement, ComponentPropsWithRef<typeof TextStyled>>(
       <TextStyled
         ref={ref}
         as="span"
-        aria-hidden={$isMaterialIcon ? 'true' : undefined}
         $theme="greyscale"
         $variation="text"
         className={`${className || ''}${$isMaterialIcon ? ' material-icons' : ''}`}