electron-rare/RTC_BL_PHONE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[codex] harden bt scan mode and refresh hardware validation reports #9

Merged
electron-rare merged 1 commits from codex/web-network-controls-latest into audit/telephony-webserver 2026-02-20 23:05:04 +00:00
Conversation 4 Commits 1 Files Changed 7
+1262 -40
electron-rare commented 2026-02-20 23:01:24 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Context

After merge of #8 into audit/telephony-webserver, hardware validation on connected A252 bench units found two follow-up needs:

  • tighten Classic BT discoverability policy during outbound HFP attempts,
  • publish updated hardware test evidence (BLE/HFP-assisted runs + refreshed functional report).

User impact

This reduces random inbound Classic BT grabs while keeping outbound HFP connect flow available, and provides up-to-date hardware validation artifacts for QA/audit.

Root cause

BluetoothManager::ensureBtStackReady() used ESP_BT_GENERAL_DISCOVERABLE, which made the board broadly discoverable during normal operation. On noisy environments this can increase unsolicited inbound attempts.

Fix

  • In src/bluetooth/BluetoothManager.cpp:
    • keep device connectable but switch to ESP_BT_NON_DISCOVERABLE.
  • Refresh hardware validation docs:
    • update docs/rapport_hw.json
    • update docs/rapport_tests_fonctionnels.md
    • add docs/rapport_ble_mac.json
    • add docs/rapport_hfp_mac.json
    • add docs/rapport_hfp_pairing_assiste.json
    • add docs/rapport_hfp_pairing_assiste_v2.json

Validation

  • python3 -m py_compile scripts/hw_validation.py -> PASS
  • platformio run -e esp32dev -> PASS
  • platformio test --without-uploading --without-testing -e esp32dev -> PASS

Coordination

  • Cross-repo hardware sync branch created:
    • coord/hw-sync-rtc-zacus-20260220 (RTC)
    • coord/hw-sync-rtc-zacus-20260220 (Zacus)
## Context After merge of #8 into `audit/telephony-webserver`, hardware validation on connected A252 bench units found two follow-up needs: - tighten Classic BT discoverability policy during outbound HFP attempts, - publish updated hardware test evidence (BLE/HFP-assisted runs + refreshed functional report). ## User impact This reduces random inbound Classic BT grabs while keeping outbound HFP connect flow available, and provides up-to-date hardware validation artifacts for QA/audit. ## Root cause `BluetoothManager::ensureBtStackReady()` used `ESP_BT_GENERAL_DISCOVERABLE`, which made the board broadly discoverable during normal operation. On noisy environments this can increase unsolicited inbound attempts. ## Fix - In `src/bluetooth/BluetoothManager.cpp`: - keep device connectable but switch to `ESP_BT_NON_DISCOVERABLE`. - Refresh hardware validation docs: - update `docs/rapport_hw.json` - update `docs/rapport_tests_fonctionnels.md` - add `docs/rapport_ble_mac.json` - add `docs/rapport_hfp_mac.json` - add `docs/rapport_hfp_pairing_assiste.json` - add `docs/rapport_hfp_pairing_assiste_v2.json` ## Validation - `python3 -m py_compile scripts/hw_validation.py` -> PASS - `platformio run -e esp32dev` -> PASS - `platformio test --without-uploading --without-testing -e esp32dev` -> PASS ## Coordination - Cross-repo hardware sync branch created: - `coord/hw-sync-rtc-zacus-20260220` (RTC) - `coord/hw-sync-rtc-zacus-20260220` (Zacus)
👍 1
electron-rare commented 2026-02-20 23:01:30 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@codex review

@codex review
👀 1
electron-rare commented 2026-02-20 23:01:46 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Cross-repo coordination branch is active in both repos ().\n\n@codex review

Cross-repo coordination branch is active in both repos ().\n\n@codex review
👀 1
electron-rare commented 2026-02-20 23:01:50 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Cross-repo coordination branch is active in both repos (coord/hw-sync-rtc-zacus-20260220).

@codex review

Cross-repo coordination branch is active in both repos (`coord/hw-sync-rtc-zacus-20260220`). @codex review
chatgpt-codex-connector[bot] commented 2026-02-20 23:04:03 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Codex Review: Didn't find any major issues. Chef's kiss. <details> <summary>ℹ️ About Codex in GitHub</summary> <br/> [Your team has set up Codex to review pull requests in this repo](http://chatgpt.com/codex/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". </details>
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 codex
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
electron (Clément Saillant)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: electron-rare/RTC_BL_PHONE#9
Delete Branch "codex/web-network-controls-latest"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?