Commit Graph

2165 Commits

Author SHA1 Message Date
sliptonic f18c730491 fix #4810
use subprocess.Popen() to avoid executing arbitrary code
2021-12-30 16:32:17 -06:00
sliptonic b23ae963d9 Merge pull request #5271 from sundtek/sundtek-discretize-bug
[PATH] change discretize value to fix issues
2021-12-19 12:35:13 -06:00
sundtek 7172e57e5d Update PathAdaptive.py
the internal unit is mm, only lowering the accuracy should be enough.
2021-12-20 01:15:59 +08:00
sundtek 47fc8dee91 change discretize value to fix issues
Discretize of 0.0001 is okay for inches, but for metric <1microns would be quite small, this fixes some issues when generating paths for curves that look inward.
I found following post in the forum: https://forum.freecadweb.org/viewtopic.php?f=15&t=42755
I have experienced similar issues with other curves in my object.
2021-12-19 19:23:09 +08:00
sliptonic 21765dec9c Modified combobox selection
cleaned up translation method

Profile translation cleanup

Incorporating additional suggestions
2021-12-17 08:35:41 -06:00
Russell Johnson 1eccba10ca Path: Translation Solution POC 2021-12-17 08:35:41 -06:00
sliptonic 3ca86cafeb PathOpGui Black reformat 2021-12-17 08:35:41 -06:00
luz paz e901e584ac Path: fix file header uniformity 2021-12-10 02:36:56 +01:00
sliptonic f5d230ed29 Merge pull request #5205 from sliptonic/bug/depthsteps
[PATH]  depthparams handles negative steps and finish step correctly. Unit tests
2021-11-26 20:24:25 -06:00
sliptonic 8e6c5a497b make sure depthparams handles negative steps and finish step correctly
revised test
2021-11-26 13:27:44 -06:00
sliptonic 4c129c7526 face outerwires aren't always the first wire in the Wires list.
Added logic to compare hashCodes()

https://forum.freecadweb.org/viewtopic.php?f=13&t=50567
2021-11-15 18:40:28 -06:00
sliptonic c21f7ab023 Black reformat 2021-09-29 16:51:00 -05:00
sliptonic 9fbd227456 Job object doesn't exist in this context.
Derive output name in the output section or default if unknown
2021-09-29 16:51:00 -05:00
Russell Johnson e018707307 Path: Strict application of Black code formatting to module file
This commit ONLY contains application of `Black` code formatting.  No other alterations have been made in this commit.
2021-09-27 20:53:09 -05:00
Russell Johnson 0242ada64e Path: Restore removal shape envelope buffer
This buffer application was removed in PR #4978 with removal of rotational code.

The buffer is required to provided adequate significant digit or rounding  in later processing of envelope in Path.Area().

NOTE:  I suggest separate `removalshape` envelopes  be created without the necessary `buffer` adjustment to allow for usage of the `removalshape` for subsequent REST type operations.
2021-09-27 20:53:09 -05:00
sliptonic 0afe01dc5e Merge pull request #5009 from Russ4262/fix/ramp_dressup
[Path] Fix for inactive ramp dressup base operation
2021-09-27 15:34:43 -05:00
sliptonic fdfe0291fd Merge pull request #5050 from jimzim111/PathArray_Z
Path: PathArray translate copies along Z axis as it does along X/Y
2021-09-27 15:19:43 -05:00
sliptonic c062384976 Merge pull request #4975 from Russ4262/cleanup/pathprofile
[Path] LGTM cleanup of PathProfile module
2021-09-27 15:16:20 -05:00
Russell Johnson 2bb8baec06 Path: Delete unnecessary comments 2021-09-24 06:40:53 -05:00
Russell Johnson dd03e616d0 Path: LGTM cleanup 2021-09-24 06:40:53 -05:00
Russell Johnson fcd8b8558e Path: Fix Face Region boundary shape usage
This commit removes automatic edge extension for `Face Region` boundary shape.  It applies the `Clear Edges` toggle for `Face Region`.  It applies `Exclude Raised Areas` correctly.  The problem of collision paths for `Clear Edges` with `Exclude Raised Areas` for certain use cases remains and is not fixed with this commit.
2021-09-24 06:39:25 -05:00
Russell Johnson 7ec38a5c3b Path: Remove unused import 2021-09-24 06:39:25 -05:00
Russell Johnson 1fbb7412b7 Path: Add docString and comments for getAllIncludedFaces() method 2021-09-24 06:39:25 -05:00
Russell Johnson 48d10b25b2 Path: LGTM fix
Prompted by LuzPaz in Gitter.im/FreeCAD/Path chatroom
2021-09-24 06:39:25 -05:00
Russell Johnson 61a43a644c Path: Black code formatting only 2021-09-24 06:38:39 -05:00
Russell Johnson a83871e509 Path: Add Base.Active check early in execute() method
This commit adds a `Base.Active` check to determine if the Base is Active.  If the Base is Inactive, the new code sets the `obj.Path` property to the same inactive message used in PathOp module and the `execution()` method returns immediately, stopping further execution.
2021-09-24 06:38:39 -05:00
jim 6e1784ddba PathArry translate copies along Z axis as it does along X/Y 2021-09-20 21:10:49 -07:00
Chris Hennes be5971ad8e Path: LGTM - don't catch BaseException 2021-09-19 14:37:11 -05:00
luz paz 6642e28826 Path: Fix PathScripts/PathJobGui.py typo bug 2021-09-08 10:22:26 -04:00
sliptonic b53ec3bd4e Black reformat 2021-09-01 12:56:00 -05:00
sliptonic ddc4c69e82 black 2021-09-01 12:26:29 -05:00
sliptonic 829c1d2a7e Merge pull request #5003 from sliptonic/removeArchPanel
[PATH] purge archpanel support
2021-09-01 11:00:54 -05:00
sliptonic b60edfd9d6 Merge pull request #4974 from Russ4262/cleanup/pathpocketshapegui
[Path] Remove unused imports per LGTM in PathPocketShapeGui module
2021-09-01 10:23:06 -05:00
sliptonic ffa92561a0 Merge pull request #4976 from Russ4262/cleanup/general_lgtm
[Path] LGTM cleanup
2021-09-01 10:21:09 -05:00
sliptonic 9cd18976d4 Merge pull request #4986 from ho-ho-ho/master
Path: Add missing newline to return-to statement in grbl postprocessor
2021-09-01 10:18:00 -05:00
sliptonic 730159d088 purge archpanel support 2021-09-01 08:34:46 -05:00
Russell Johnson ae7a8752fb Path: LGTM cleanup 2021-08-27 22:37:41 -05:00
sliptonic 8c361dd3fc Merge pull request #4902 from Russ4262/fix/Extensions_error_msg
[Path] Downgrade Extensions error message priority
2021-08-27 17:17:33 -05:00
ho-ho-ho baafa2a0c4 Update grbl_post.py
Append new line to return-to line
2021-08-21 12:36:47 +02:00
Russell Johnson 248a89020c Path: Remove unused imports per LGTM 2021-08-17 21:47:22 -05:00
sliptonic 0fcd0cec44 Merge pull request #4797 from Russ4262/feature/tile_job
[Path] GUI scripting support and other improvements
2021-08-14 09:26:25 -05:00
sliptonic 59c36f150e Merge pull request #4815 from Russ4262/fix/GUI_issues
[Path] Fix GUI issues and minor code cleanup
2021-08-14 09:20:03 -05:00
Russell Johnson 1cdfd611fd Path: Downgrade module's debug level to INFO 2021-08-13 19:02:40 -05:00
Russell Johnson ff3adacd93 Path: Auto-load the user-selected job for the simulator
Add code to auto-load the user-selected job in the simulator so manual selection is not necessary with multi-job documents.
2021-08-13 19:02:40 -05:00
Russell Johnson be1e394da9 Path: Changes to allow for Adaptive op defaults at job level
Add `SetupProperties()` function to Adaptive module.
Connect `SetupProperties()` function to GUI command resources.
Add string assignment for `App::PropertyPythonObject` property prototype
2021-08-13 19:02:40 -05:00
Russell Johnson 86b4c626a7 Path: Add missing translate() function 2021-08-13 19:02:40 -05:00
Russell Johnson 30ea19a923 Path: Refactor PathBoundary algorithm to independent class
Relocate code for PathBoundary algorithm into an independent class allowing for usage without the Dressup object creation.
2021-08-13 19:02:40 -05:00
Russell Johnson cfca2a790a Path: Allow parent job assignment
Modifications focus on allowing the creation of operations to include direct provision of parent job.
Path: Remove `useGui` implementation
2021-08-13 19:02:40 -05:00
sliptonic 2736142ddf Merge pull request #4901 from Russ4262/fix/3D_Pocket
[Path] Fix 3D Pocket tuple lengths in return values
2021-08-02 12:22:56 -05:00
sliptonic 8f4d3a7008 Merge pull request #4906 from Russ4262/fix/toolbit_missing_readme_doc
[Path] Fix relative shape files for toolbits
2021-08-02 12:19:37 -05:00