Commit Graph

183 Commits

Author SHA1 Message Date
Benjamin Bræstrup Sayoc ee11eb188f Remove magic number and hard type enums in DrawViewDimension.h
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-03-02 17:14:24 +01:00
Benjamin Bræstrup Sayoc f115ed4bb1 Remove magic numbers and hard type enums in DimensionFormatter.h.h
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-02-17 12:16:49 -05:00
Benjamin Bræstrup Sayoc 63d9806b86 Remove magic number and hard type enums in Geometry.h
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-02-17 12:16:49 -05:00
Benjamin Bræstrup Sayoc 1d7e7c86a0 [TechDraw] Use templates instead of duplicate code: toGp 2025-02-08 22:35:57 +01:00
Chris Hennes 5e9dd297fe Merge pull request #19232 from WandererFan/miscSmallFixes
[TD]minor fixes x3
2025-02-03 17:54:20 +01:00
Benjamin Nauck dd6aa9f3c7 Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's
Regex based changes, manually verified
2025-01-27 16:08:18 +01:00
wandererfan a1933ff64f [TD]allow showing units on individual dimensions 2025-01-24 13:04:00 -05:00
WandererFan abb50a4daa [TD]Long and link dim refs (fix #13375) (#18641)
* [Meas]Changes for TD dimension refs for links

* [TD]App changes for dim refs to links

* [TD]Gui changes for dim refs to links

* [TD]fix 2 lint messages

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-12-23 17:36:22 -05:00
Benjamin Bræstrup Sayoc 36f2aa6152 [TechDraw] Translations and grammer (#16301)
Co-authored-by: WandererFan <WandererFan@gmail.com>
2024-12-02 12:27:39 -05:00
wandererfan 1de4dc600d [TD]fix area calculation 2024-11-25 17:49:21 +01:00
wandererfan 9f7e50e4ce [TD]throttle over aggressive dimension autocorrect 2024-10-14 17:45:53 +02:00
WandererFan e8772751e6 [TD]Fix auto correct msg missing16892 (#16909)
* [TD]fix bad return code on auto-correct fail

* [TD]prevent changing references in property editor

- this is a "shoot yourself in the foot" practice
2024-09-30 18:20:47 +02:00
wandererfan 93e685bd7a [TD]fix dim text wrong side of dim line (fix #16172) 2024-09-02 18:24:16 +02:00
PaddleStroke ba0ff0db5e Techdraw: area dimension: fix scale issue. 2024-06-10 08:28:36 -04:00
wandererfan 40a1ac8c8b [TD]fix autocorrect handling of older documents 2024-05-21 14:14:16 -04:00
wandererfan 2d2977abaf [TD]fix #13992 - compile warnings 2024-05-17 18:07:25 -04:00
PaddleStroke e33c983614 TechDraw: Implement 'Area' dimension. 2024-05-06 18:42:28 +02:00
wandererfan d2d93458e9 [TD]fix dimension autocorrect
- autocorrect was not handling scaled and rotated reference geometry
  properly.
2024-05-05 20:38:14 -04:00
wandererfan 41bce2eaf4 [TD]fix BrokenView dimensions 2024-04-15 19:59:22 -04:00
wandererfan 33a3c84d92 [TD]implement BrokenView 2024-04-06 15:25:23 -04:00
wandererfan 94c2d4fff1 [TD]fix fail on corrupt dimension reference 2024-04-03 08:48:39 -04:00
wmayer 2326d52a78 [TD]Refactor LTNP correction code for Dimensions
- additional geometry types

- add method to handle line like bsplines

- handle deleted ref body feature

- add test for empty savedGeometry

- add switch for matcher/LTNP on/off
2024-03-17 08:56:34 -04:00
wandererfan fca3b80da8 [TD]fix over/under tolerance
- left justify tolerances
- use format spec for tolerance == zero
- prevent uncommanded tolerance format changes
- use 'w' format for HoleShaftFit
- allow zero tolerance values for HoleShaftFit
2024-03-14 21:45:16 -04:00
wandererfan ff2cea3008 [TD]fix Dimension icons 2024-01-12 09:23:38 -05:00
wandererfan c91a35961f [TD]mute dimension autocorrect warning 2023-12-24 12:27:25 -05:00
wmayer 5b1ccf895a TD: fix -Wsign-compare 2023-10-11 15:12:42 +02:00
Florian Foinant-Willig 60da0b80f7 TechDraw: fix extension lines of projected dimension 2023-10-02 13:53:01 -04:00
Florian Foinant-Willig c8313874e4 TechDraw: Implements projected Length dimension 2023-10-02 13:53:01 -04:00
wandererfan 0e2b3c0ecc [TD]Fix no dimensions from old document (#10880) 2023-10-02 09:39:27 -04:00
wandererfan d7fcbc79a8 [TD]fix missing reference geometry 2023-09-28 09:01:39 -04:00
wandererfan 6caaea06b7 [TD]handle BSpline "lines" in GeometryMatcher 2023-04-22 13:49:10 -04:00
Benjamin Bræstrup Sayoc 15fe52a04b [TechDraw] Simplify retrievement of user preferences
for all TechDraw files
2023-04-10 23:34:05 -04:00
wandererfan 20e44eba50 [TD]fix bad 3d dimensions
- mapToPage was left in place when converting to using
  projectPoint instead of projectToPlane.
2023-03-25 18:14:26 -04:00
wandererfan 85216bd127 [TD]Lint/Tidy/Review comments applied 2023-03-22 20:09:35 -04:00
wandererfan b9fa9cb33e [TD]corrupt dim reference detect and correct 2023-03-22 20:09:35 -04:00
wandererfan 01641433c1 [TD]getters and setters for geometry
- make attributes private (or protected) and use
  getters and setters instead of accessing attributes
  directly.
2023-02-28 08:15:06 -05:00
Uwe f8db7e9187 [TD] remove unused headers (#8155)
* [TD] remove unused headers

- also some sorting
- also improve readability by not using an abbreviation (we consistently don't abbreviate class names)
2023-01-09 14:55:22 +01:00
wandererfan 664b2560ad [TD]fix wrong calculation of 3d two edge angle 2023-01-07 16:32:03 -05:00
wandererfan 17554e29f1 [TD]fix issues reported by 3d dimension testers
- correct interpretation of True vs Projected

- handle long subelement names in references

- fix "too small" value condition

- better error messages for bad dimension geometry
2023-01-07 16:32:03 -05:00
wandererfan 1b547dff72 [TD]Refactor Dimensions for 3d upgrade
- separate validation, geometry and reference handling into
  individual files
- improve 3d reference geometry handling
- eliminate duplicate dim creation code

- add Dimension reference repair dialog

- Refactor formatting out of DrawViewDimension

- move dimension repaint control to ViewProvider
2023-01-07 16:32:03 -05:00
wandererfan 23dc64365b [TD]move makeAlignedPieces to separate thread
- correct ComplexSection rotation

- fix fail to load CS for some profiles and directions
2022-12-18 09:42:42 -05:00
wmayer c38e522101 TD: replace QRegExp with QRegularExpression 2022-10-08 13:33:10 +02:00
Uwe 061bf91e84 [TD] DrawView*: remove unused includes - part 1
- also sort includes
- also additions to precompiled header
2022-10-07 01:08:38 +02:00
wandererfan 20f5db1ad1 [TD]fix extent dimension 2022-09-09 13:02:08 -04:00
wandererfan acf17905ed [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Wanderer Fan 74cdc6db61 [TD]code clean ups
- QtConcurrent include and CMake for Win

- include clean up dvp, dvs, dvd

- variable names and nested if clean up

- remove debug code
2022-08-18 09:34:32 -04:00
berniev da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Benjamin Bræstrup Sayoc 6ed38eeb99 [TechDraw] Improve readability of DrawViewDetail.cpp
[TechDraw] Improve readability of DrawViewDimension.cpp

[TechDraw] Improve readability of DrawViewDimExtent.cpp

[TechDraw] Improve readability of DrawViewDraft.cpp

[TechDraw] Improve readability of DrawViewImage.cpp

[TechDraw] Improve readability of DrawViewMulti.cpp
2022-07-20 16:44:26 -04:00
Uwe 31bc9f3913 [TD] remove some more superfluous nullptr checks 2022-07-20 02:53:48 +02:00
Uwe 93796e2d92 [TD] App: remove some superfluous nullptr checks 2022-07-19 02:03:50 +02:00