Commit Graph

2195 Commits

Author SHA1 Message Date
Russell Johnson 2b35419e55 Path: LGTM cleanup 2021-02-20 12:32:25 -06:00
Russell Johnson a961fbee86 Path: Remove unnecessary line return 2021-02-20 12:32:25 -06:00
Russell Johnson 1b3205de20 Path: Add error for incorrect open-edge usage
When profiling open edges, the user must currently select a top edge and then set the Final Depth manually to a value below the selected edge(s).
This fix provides the user with feedback for the empty path generated.
2021-02-20 12:32:25 -06:00
Russell Johnson 215967fe78 Path: Catch error if ofstShape has no Area attribute 2021-02-20 12:32:25 -06:00
Russell Johnson 2b4158addc Path: Fix incorrect empty data type return 2021-02-20 12:32:25 -06:00
Russell Johnson 8e234290ef Path: Catch openEdges error if None 2021-02-20 12:32:25 -06:00
Russell Johnson b3fc4fcf17 Path: Fix spacing typo 2021-02-20 12:32:25 -06:00
Russell Johnson d7483f6e85 Path: Fix range() input type per gcc-7 build 2021-02-20 12:32:25 -06:00
Russell Johnson 3a10ed5f27 Path: Fix feature selection and handling
Fix error when working with selections containing edges and faces.  This fix effectively processes edges and only passes faces on to next processing step.  This simplifies the code a bit and changes some `obj.Base` references to `otherBase` to improve readability.
Path: Improve `obj.Base` reading and processing

`obj.Base` is first read in `self._processEdges()`.  All edges are identified and processed there.  Remaining features are saved in `remainingObjBaseFeatures` to be processed in the next section of the Profile code.
Path: Change `if` to `elif`
2021-02-20 12:32:25 -06:00
Russell Johnson 91dd729d4e Path: Fix error for undefined profileshape variable 2021-02-20 12:32:25 -06:00
Russell Johnson 8f4f304635 Path: Fix open-edge profiling for micro bit usage 2021-02-20 12:32:25 -06:00
Russell Johnson 45dab6b589 Path: Change HandleMultipleFeatures default value to Collectively
This fixes error when attempting to profile loop of vertical faces, thus maintaining original Profile Faces behavior by default for vertical looped face set.
2021-02-20 12:32:25 -06:00
Russell Johnson 0b9a160331 Path: Apply LazyLoader for DraftGeomUtils module 2021-02-20 12:32:25 -06:00
sliptonic 6359d83836 Merge pull request #4454 from lag-linaro/master
PathToolBitLibraryGui: Fix LinuxCNC tool table format
2021-02-20 11:54:51 -06:00
Stefano Chiaro d9ed0191d8 Update src/Mod/Path/PathScripts/post/heidenhain_post.py
Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2021-02-20 11:37:08 -06:00
Stefano Chiaro ca06ab24a5 Update heidenhain_post.py
fixed pol_Angle
2021-02-20 11:37:08 -06:00
sliptonic 6238f0e88a Pep8 cleanup 2021-02-20 11:37:08 -06:00
sliptonic 0a9bf1c5f0 Add useoutline property to op if doesn't exist 2021-02-20 11:37:08 -06:00
sliptonic 2e1c00e4fe add back translation string 2021-02-19 17:50:56 -06:00
sliptonic 7c2962e119 Fix unit test with property name sanitize. 2021-02-17 18:39:15 -06:00
sliptonic 097b2c982e Fixes #4555 2021-02-17 17:21:50 -06:00
sliptonic f369260452 fix lgtm error 2021-02-17 17:21:50 -06:00
sliptonic af721d6f08 fix typos 2021-02-17 17:20:19 -06:00
sliptonic b7eac5df49 fix #4572 2021-02-17 17:20:19 -06:00
sliptonic 90b8a7b45a remove deprecated preference setting 2021-02-17 17:20:19 -06:00
sliptonic 87b6a42f13 Merge pull request #4440 from mlampert/bugfix/path-invalid-base-geometry-robustness
[Path]: bugfix/invalid base geometry robustness
2021-02-16 09:27:06 -06:00
sliptonic 61824e80f3 Update PathOp.py
fix typo
2021-02-16 09:25:59 -06:00
mlampert eae5826d93 Merge branch 'master' into bugfix/toolbit-properties-alignment 2021-02-15 16:03:28 -08:00
mlampert 04fb966d69 Merge branch 'master' into bugfix/path-invalid-base-geometry-robustness 2021-02-15 16:01:48 -08:00
Markus Lampert 35c1a005f1 Fixed TC creation from templates if legacy tools are enabled. 2021-02-15 22:15:17 +01:00
Markus Lampert 522734eb3c Removed obsolete preference api 2021-02-15 22:15:17 +01:00
mlampert ec89caacd1 Merge branch 'master' into bugfix/toolbit-properties-alignment 2021-02-15 12:22:13 -08:00
Markus Lampert 41de35c456 Only use IconViewProvider in PathStock when required. 2021-02-15 12:21:33 -08:00
sliptonic 48dc4063f8 Merge pull request #4387 from mlampert/feature/add-experimental-features-to-preferences
[Path]: Expose experimental feature flag in preferences - with warning.
2021-02-15 10:09:53 -06:00
sliptonic ab186aa05a Merge pull request #4433 from J-Dunn/master
[PATH] fix conecutter core dumps #4561
2021-02-15 10:03:09 -06:00
Markus Lampert a058d1c482 Only import icon view provider in job if required. 2021-02-15 00:16:39 -08:00
Markus Lampert 7da5c447e4 Load PathGui for property bag view provider to function properly 2021-02-14 23:21:10 -08:00
mlampert cc62aff0ae Merge branch 'master' into bugfix/path-invalid-base-geometry-robustness 2021-02-14 18:16:12 -08:00
mlampert ff01e4f4a8 Merge branch 'master' into feature/add-experimental-features-to-preferences 2021-02-14 17:54:04 -08:00
sliptonic 62ed39e010 Merge pull request #4443 from mlampert/bugfix/deburr-offset-part
[Path]: Added support for Part.OffsetCurve to flipEdge.
2021-02-14 17:36:01 -06:00
sliptonic e071d613db Merge pull request #4441 from mlampert/bugfix/path-ellipsis-cmdsForEdge
[Path]: bugfix/cmdsForEdge for ellipse edge
2021-02-14 17:35:44 -06:00
sliptonic 02b3074ab8 Merge pull request #4384 from Russ4262/feature_useoutline_to_adaptive
[0.19] [Path] Add `UseOutline` feature to Adaptive op [1 of 3 per dev conversation]
2021-02-14 17:07:45 -06:00
mlampert f7a467cbdc Merge branch 'master' into bugfix/path-invalid-base-geometry-robustness 2021-02-14 11:19:07 -08:00
mlampert 086746228d Merge branch 'master' into bugfix/path-ellipsis-cmdsForEdge 2021-02-14 11:18:51 -08:00
mlampert 696e17c894 Merge branch 'master' into bugfix/deburr-offset-part 2021-02-14 11:18:35 -08:00
mlampert 57cfd3c17a Merge branch 'master' into feature/add-experimental-features-to-preferences 2021-02-14 11:17:31 -08:00
Lee Jones 6ba2d3ac48 PathToolBitLibraryGui: Fix LinuxCNC tool table format
The currently exported tool table for LinuxCNC results in the following warning:

  "Requested tool 1 not found in the tool table"

The debug output provides:

  "File: default_tool_table.tbl Unrecognized line skipped: \
      T1 P X0 Y0 Z0 A0 B0 C0 U0 V0 W0 D4.00 I0 J0 Q0;      \
      4mm_2F_Compression_Carbide_Endmill"

This is due to a missing/blank P (pocket) entry.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
2021-02-14 17:56:32 +00:00
luz paz fb52f3177d Path: fix typos in comments [skip ci]
Found via codespell
2021-02-14 10:45:38 +01:00
Markus Lampert da85fde409 Split OCL and experimental features to allow enabling independently. 2021-02-13 16:03:00 -08:00
Markus Lampert 63cd587e07 Added 'Advanced' preferences page, moved warning suppression there and experimental feature support. 2021-02-13 16:03:00 -08:00