electron-rare/FreeCAD
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
29,259 Commits 36 Branches 99 Tags
89ecdae088dbfcb6000402a4df86e41c19eca431
Commit Graph

70 Commits

Author SHA1 Message Date
Uwe 89ecdae088 [PD] fix Pad/Pocket logic issue 
- fixes the bug reported in https://forum.freecadweb.org/viewtopic.php?f=3&t=70266
  as Method #2
  -> When switching to two dimensions, symmetric must be unchecked if it is checked
 2022-07-17 03:24:19 +02:00
Uwe 61d54b6078 [PD] Pad and Pocket: remove unused includes 2022-02-19 17:57:11 +01:00
Uwe cfdf334b7f [PD] add option to create tapered Pad / Pocket 
This PR adds the same functionality as provided by Part Extrude.
The used code parts are sorted out to a new helper function that is used by Part and PartDesign.
 2022-02-02 01:04:06 +01:00
wmayer ad7ab573eb PD: PrefQuantitySpinBox now requires an explicit entry name for the parameter group 2022-01-31 16:47:08 +01:00
Uwe 66864bbe7b [PD] Pad/Pocket: sort out duplicated code 
the checkboxes are almost identical and it avoids work to have them in one location
 2022-01-14 13:17:25 +01:00
Uwe 626425526b [PD] sort out more Pad/Pocket code 
as suggested in #5349
 2022-01-10 14:33:02 +01:00
Uwe 5aadc54d18 [PD] Pad/Pocket: fix reverse behavior 
- bring back intended behavior as in FC 0.19:
 - if 2 lengths, then midplane is invisible
 - if reversed checked, then no symmetric and if symmetric then no reverse
- unify the code for Pad and Pocket (reversed is always visible)
- fix a typo in a bool name
 2022-01-08 01:15:23 +01:00
Uwe 7c158a3751 [PD] rename a UI file 
Pad and Pocket share the same UI file therefore change the name to make this clear that changes in that file must be handled for Pad and Pocket
 2022-01-07 20:36:29 +01:00
wmayer cb8330d5bd PD: code-refactoring of TaskExtrudeParameters 2021-11-27 01:45:08 +01:00
wmayer e412c3f4cc PD: add enum class to TaskPadParameters to avoid to work with magic numbers 2021-11-26 16:58:59 +01:00
wmayer 828b1b6d0a PD: add enum class to TaskPocketParameters to avoid to work with magic numbers 2021-11-26 16:46:58 +01:00
wmayer 6a0cf8233a PD: create a common base class of TaskPocketParameters and TaskPocketParameters to reduce code duplications 2021-11-26 16:23:45 +01:00
Uwe 1da079b34b [PD] better solution for reversed pad/pocket handling 
- let FeatureExtrude set the right direction
- use the UI as once intended: custom vector values are always taken as they are, so reversing a custom direction will not lead to a negation of the custom vector in the UI. The logic is: "take the vector as it is, and when Reversed is on, negate it additionally"
 2021-11-23 04:22:37 +01:00
Uwe 4c72df3480 [PD] fix pad/pocket UI issues 
- update the preview when the direction is changed in the dialog
- don't uncheck the direction viewbox without any reason
- only recompute once
- update the direction information on reversion
- only pocket: add missing code we have in pad (proper code merging will follow the next days)
 2021-11-23 02:48:25 +01:00
wmayer 3dc9acef62 PD: [skip ci] fix warning -Wunused-variable 2021-11-17 19:06:35 +01:00
Uwe 838bdf93bc [PD] fix issue 0004785 
- then the profile of a pad/pocket was a face, the direction handling was completely broken
 2021-11-15 15:44:28 +01:00
Uwe 4a4db353a5 [PD] fix pad/pocket direction issue 
- the info if a custom direction is used, was incorrectly determined by checking a checkbox that only displays the vector value, no matter if it is a custom vector or not
 2021-11-13 04:03:04 +01:00
Uwe 0995c81240 [PD] add feature to set direction for pockets 
This PR adds the functionality of pads to pad along either a custom direction or along an edge to pockets.

So with this PR Pad and Pocket are on the same level of functionality.
 2021-11-11 15:55:42 -06:00
Uwe e06034e772 [PD] fix a typo 
- also some sorting
 2021-11-10 03:26:23 +01:00
0penBrain 586955e31b [PartDesign] Enable reverse ability for Pocket/UpToFace mode as it makes sense for curved faces 2021-08-17 12:07:02 +02:00
0penBrain 39ca142d5f [PartDesign] Restore 'Reversed' ability into Pocket/2dims mode 2021-08-17 12:07:02 +02:00
donovaly 2ac84872ec [PD] make pointers to the UI std::unique_ptr 
Same as PR #4293, just for PartDesign

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all PartDesign dialogs that don't already use a unique_ptr.
 2021-02-05 18:01:57 +01:00
donovaly acecdd8c57 [PD] allow expression for pocket offset 
- also disable KeyboardTracking for some fields to avoid unnecessary and often time consuming recomputes while typing in
 2020-08-10 13:39:50 +02:00
Zheng, Lei 11a93a0578 PartDesign changes 
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
 2019-08-17 15:15:47 +02:00
Abdullah Tahiri 663e4ee369 PartDesign: Extension of Pocket Feature to have two dimensions 
fixes #2915
 2018-01-20 16:15:38 +01:00
wmayer f6ff4ed590 improve UpToFace option of pad/pocket for datum planes 2018-01-06 17:36:14 +01:00
luzpaz 56af703746 Fix Techdraw UI typo found via crowdin + misc. typos 
Ref: https://crowdin.com/translate/freecad/27911/en-eu#6503377
 2017-11-26 15:48:20 +01:00
Kunda 99c99006b8 source typo fixes pt4 (only on py3 merged code) 2017-03-02 13:47:21 +01:00
wmayer de7978434d fix Coverity issues 2016-08-19 22:51:33 +02:00
Mateusz Skowroński b5519922d8 QString::fromAscii() is obsolete in Qt5. Replace it with fromLatin1(). 
This change is Qt4/Qt5 neutral.
 2016-04-15 11:55:12 +02:00
Alexander Golubev d43525370c PartDesignGui: small rework to sketch-based task parameters 
This done mostly for thurther unification them with other task
parameters/dialogs.
 2016-04-12 18:12:21 +02:00
Alexander Golubev c782a11aab PartDesign/Gui: Move various utility stuff from Workbench to a separate file 
Also do some header cleanup.
 2016-04-12 18:12:17 +02:00
Alexander Golubev 5ee0cea467 PartDesign/Gui: start to unify view providers code 
- Moved all common code for part design features view providers to a base
   class.
 - Move shared code for Sketch based features to newly created
   ViewProviderSketchBased class
 - Add ViewProviderSketchBased to initialization
 - Make Pad and Pocket ViewProviders to use the shared code
 - Minor fixes to TaskFeatureParameters and some derived classes
 2016-04-12 18:12:15 +02:00
Alexander Golubev 0ca40ed48b PartDesign/Task{Pad,Pocket}Parameters: massive refactoring 
Give a massive refactoring to Task dialogs for pocket and pad.
This commit features:
 * Make Task dialogs for pocket and pad look nice in side-by side diff and
   cross import features missing in each other.
 * As a result it fixes several minor bugs.
 * Gives a rework to the UpdateUI function.
 * This one also fixes offset option support and migrates it to use unit
   framework.
 2016-04-12 18:12:15 +02:00
Alexander Golubev 11a71d46e3 PartDesignGui: move signal connections in several parameter dialogs after ui initialization 2016-04-12 18:12:15 +02:00
Alexander Golubev f16829baee PartDesignGui: Make DressUp and SketchSupport propertie dialogs use common accept() structure 2016-04-12 18:12:15 +02:00
Alexander Golubev a6ebfa496f PartDesign/Gui/TaskDlgSketchBasedParameters: emhance object hiding/unhiding on reject() 2016-04-12 18:12:14 +02:00
DeepSOIC 03be8e1bba PartDesign: tidy up sketch support and base feature confusion 
Not complete, transformPlacement and positionBySketch are pending...
 2016-04-12 18:12:11 +02:00
jrheinlaender f1b5a6044d Allow extruding from a datum plane to another face or plane, optionally with an offset 2016-04-12 18:11:53 +02:00
jrheinlaender 7983862b52 Some code unification for sketchbased features 2016-04-12 18:11:51 +02:00
jrheinlaender b18958b3d9 Miscellaneous fixes 2016-04-12 18:11:51 +02:00
jrheinlaender 4645fdcd37 Miscellaneous fixes 2016-04-12 18:11:50 +02:00
jrheinlaender 1f42d4e3a3 bugfix for extrude to datum plane 2016-04-12 18:11:50 +02:00
jrheinlaender f954a51430 Pad/Pocket: Allow extrude up to a datum plane 2016-04-12 18:11:50 +02:00
jrheinlaender b815656649 Refactored code of SketchBased features to have common code in an abstract superclass 2016-04-12 18:11:50 +02:00
jrheinlaender 0bcdb0511f Added Reversed button to Pocket UI if the sketch plane is a datum plane 2016-04-12 18:11:50 +02:00
jrheinlaender 63f782d8f0 More bug fixes for Body insertion/deletion of features 2016-04-12 18:11:48 +02:00
jrheinlaender ee47c53339 Bug fixes for Body feature insert/remove functionality 2016-04-12 18:11:48 +02:00
Mateusz Skowroński cd2db00f22 QString::fromAscii() is obsolete in Qt5. Replace it with fromLatin1(). 
This change is Qt4/Qt5 neutral.
 2016-01-05 16:07:25 +01:00
Eivind Kvedalen ddfbe349cf PartDesign: Added support for expressions. 2015-09-21 14:51:09 +02:00