Commit Graph

2057 Commits

Author SHA1 Message Date
jim 6e818208bf Merge branch 'patharray_multibase' of https://github.com/jimzim111/FreeCAD into patharray_multibase 2021-05-24 21:22:10 -07:00
jim a3f37025b1 Fix row-ordering logic when SwapDirection==True 2021-05-24 21:21:17 -07:00
jimzim111 3a5627553b Merge branch 'FreeCAD:master' into patharray_multibase 2021-05-24 21:04:37 -07:00
jim daddf550aa Add PathArray "Jitter" capability to offset each copy by a random distance. Helps create an imperfect "hand-crafted" appearance.
Adds properties:
 - JitterPercent: % of copies that will be randomly offset
 - JitterMagnitude: Maximum distance to offset copies
2021-05-24 21:00:45 -07:00
sliptonic b0364e466a Merge pull request #4680 from ChrisNisbet01/Fix_vcarve_depth_calculation
Path: vcarve - Fix depth calculation
2021-05-24 12:47:46 -05:00
sliptonic 98ec3dda9d Merge pull request #4765 from sliptonic/bug/toolnumbers
[PATH] fix bug adding TC from job dialog.
2021-05-24 12:46:21 -05:00
sliptonic 224f49af28 Merge pull request #4617 from Russ4262/fix_pocketshape_circular_extension
[Path] Fix outside `Extensions` of circular faces with inner holes
2021-05-24 12:45:13 -05:00
sliptonic 6e622fab9d Merge pull request #4637 from Russ4262/fix_update_default_extension_length
[Path] Fix update of Extensions `Default Length` GUI spin box
2021-05-24 12:34:35 -05:00
sliptonic c3878ea58f Merge pull request #4523 from Russ4262/slot_fixes
[Path] Stability fixes for experimental Slot operation
2021-05-24 11:53:44 -05:00
sliptonic 77c44170f3 Merge pull request #4796 from heewa/fix-path-errors
Path: check for empty before using - fixes #4645
2021-05-24 11:51:53 -05:00
jim 0495310984 fix whitespace 2021-05-23 19:28:36 -07:00
jim db8a6116da Path: Add PathArray "SwapDirection" property to process copies along X axis before Y axis 2021-05-23 19:25:52 -07:00
jim e8e1b4ce94 PathArray support for multiple paths as base 2021-05-23 19:24:30 -07:00
Heewa Barfchin 2f49d4ee56 Path: check for empty before using - fixes #4645
In a few locations, python objects are used without checking if they
exist and are non-null, which throws missing attribute exceptions. The
fix is to simply check first.
2021-05-17 18:45:11 -04:00
Daniel Wood 1bed2fff86 Use defaults for retract height
Use the StartDepth + SafeHeightOffset to calculate the retract height in relation to the hole start height.
2021-05-06 08:09:43 +01:00
Daniel Wood e9de8d4e98 use correct feedrate for rapid moves 2021-05-05 20:33:26 +01:00
Daniel Wood 034d9ec21a use toolbits with tooltip calculation 2021-05-04 15:56:45 +01:00
Daniel Wood dc3e121580 Rapid to safe height above the hole 2021-05-04 14:06:30 +01:00
Daniel Wood 02e26061e3 fixes for drilling operation start depth 2021-05-04 13:41:50 +01:00
sliptonic 719f0db263 fix bug adding TC from job dialog.
When adding tool controllers from the job dialog, it will now
try to match the toolbit file with the currently selected library
and add use the toolnumber from there.  If no match is found,
it will autoincrement from the existing tool controllers
in the job
2021-04-27 14:56:05 -05:00
sliptonic 657b33d892 adjust tool position during inspect 2021-04-20 18:32:09 -05:00
Russell Johnson 9fa93de188 Path: Correct GUI visualization of circular-face visualizations
Path: Fix internal circular extension visualization
2021-04-10 14:09:22 -05:00
Russell Johnson 0ecd0dba65 Path: Fix outside extension of circular faces with inner holes
Fix bug identified by MLampert.  This fix addresses extensions for circular faces that have non-extended holes in the face.
.
Unlike polygon extensions that only need one wire to define the extension shape, some circular extensions require two wires (a face would be better) to define the extension area.
.
Restructure to accommodate future `Extensions` improvements
2021-04-10 14:09:22 -05:00
Russell Johnson 926baf8ce8 Path: Improve horizontal-planar and curved face handling
These changes allow for better identification of horizontally planar faces, and also improve handling of circular arc faces that failed previously for use with ball-end bits.
This fix also improves slot creation based on selection of two arc edges for ball-end slot creation.
2021-04-08 22:43:33 -05:00
Russell Johnson 16d1422bb0 Path: Fix comment syntax 2021-04-08 22:43:33 -05:00
Russell Johnson fc2e249943 Path: Fix variable naming to use lowercase 2021-04-08 22:43:33 -05:00
Russell Johnson 4a5513cc58 Path: Fix error when no obj.Base features selected 2021-04-08 22:43:32 -05:00
Russell Johnson d1174dc4b3 Path: Add check for CustomPoint input
If custom points are same, the user has not entered acceptable values for path generation with custom points.
2021-04-08 22:43:32 -05:00
Russell Johnson 90564ea3fd Path: Set CustomPoint2 and CustomPoint1 defaults equal
Setting these two default values equal will aid in code execution and error detection.  Subsequent fixes will rely on this condition.
2021-04-08 22:43:32 -05:00
Russell Johnson b1ffa159a2 Path: Fix update of Extensions Default Length GUI spin box
Fix the bug hindering update of the Default Length spin box in the Extensions tab after editing and change of focus. 
With the fix, the spin box updates after change of focus, as do other spin boxes in the Path workbench.
Used method found in PathDrillingGui module.
2021-04-08 22:27:02 -05:00
luz paz 15c16610c8 fix source comment typos [skip ci]
Found via  codespell v2.1.dev0
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,parms,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu
```
2021-03-28 10:57:24 +02:00
Chris Nisbet 67f89ac557 Path: vcarve - Fix depth calculation
Depths were being calculated incorrectly due to MIC distance getting
divided by scaling factor rather than multiplied by it.

The scaling factor is the inverse of the tan of half the cutting tool
angle, so for a 30 degree bit (say), the scaling factor would be
1 / tan(30/2), or 3.7320.

When given an MIC (which is a radius) of 3.175 (say), and cutting to the
same width with a 30 degree bit, the depth should be 3.175 * 3.7320
(11..849), not 3.175 / 3.7320 (0.8509) as it is currently.
2021-03-28 16:56:47 +13:00
sliptonic 182a578c43 Merge pull request #4664 from papaathome/uccnc_postprocessor
Path: Added UC-CNC postprocessor script.
2021-03-26 15:26:05 -05:00
andre 19fa532e2a Aplied Flake8 formatting and removed redundant global declarations.
Line limit used: 100 characters, still 3 lines longer than that.
2021-03-26 17:53:02 +01:00
andre 5abd19f121 Included bugfix as in FreeCAD PR. #4673 'Fix proxy error bug that occurs when postprocessing' (review recommendation) 2021-03-26 09:33:40 +01:00
sliptonic 515c7deb21 Merge pull request #4634 from mlampert/bugfix/issue-2839-dogbone-visualisation
[Path]: Bugfix/issue 2839 dogbone visualisation
2021-03-25 22:17:31 -05:00
sliptonic 837cf18153 Merge pull request #4639 from claasahl/claasahl-patch-1
[Path] post procesing for GRBL with option "--translate_drill" should also suppress G99
2021-03-25 17:43:34 -05:00
andre 232969348a Added UC-CNC postprocessor script. 2021-03-24 17:13:42 +01:00
sliptonic 05b0ff2fd1 Merge pull request #4624 from mlampert/bugfix/dogbone-on-straight-edges-and-noop-moves
[Path]: Bugfix/dogbone on straight edges and noop moves
2021-03-23 12:58:44 -05:00
mlampert a5c4d19a10 Merge branch 'master' into bugfix/issue-2839-dogbone-visualisation 2021-03-22 22:42:53 -07:00
mlampert c81a43a256 Merge branch 'master' into bugfix/dogbone-on-straight-edges-and-noop-moves 2021-03-22 14:45:41 -07:00
mlampert 5fccb4fc9b Merge branch 'master' into bugfix/job-setup 2021-03-22 14:44:44 -07:00
sliptonic 7d118f31b7 Merge pull request #4615 from Russ4262/fix_pocketshape_combine_shapes
[Path] Fix connected multi-face clearing bug
2021-03-22 13:53:55 -05:00
Claas Ahlrichs f0f25af3f5 Update grbl_post.py 2021-03-20 10:27:46 +01:00
Markus Lampert 67555d2cc3 Fixed coin import for py3 class initialisation 2021-03-18 18:00:55 -07:00
Markus Lampert e510d095c4 Moved coin import under GuiUp clause 2021-03-18 11:44:57 -07:00
Markus Lampert 1704f42fb4 Cleanup marker after deleting them 2021-03-17 20:06:01 -07:00
Markus Lampert c343533604 Added visualisation for dogbones during editing 2021-03-17 19:46:51 -07:00
Markus Lampert fb49fb2470 Dogbone resiliency against noop moves 2021-03-15 22:39:27 -07:00
Markus Lampert ef6d526bc3 Dogbone resiliency against comments between moves 2021-03-15 22:39:18 -07:00