Commit Graph

56 Commits

Author SHA1 Message Date
sliptonic 17de45a228 translation cleanup circularholebase 2022-01-26 18:36:06 -06:00
sliptonic fc2d6c172b Make CircularHoleBase use drillableLib
debugs

remove deprecated PathUtils.isDrillable

drillableLib cmake

make PathProfile use new drillableLib
2022-01-15 15:34:17 -06:00
sliptonic 730159d088 purge archpanel support 2021-09-01 08:34:46 -05:00
Russell Johnson 16015f66e3 Path: Remove first-draft rotational code Path
Remove all first-draft rotational-related code from Path workbench to make way for more stable, long-term integration of a rotational indexing capability.
2021-05-27 10:04:31 -05:00
Markus Lampert b29d168132 Add basic thread milling op 2020-12-03 18:15:36 -08:00
Russell Johnson 2461d942af Path: Delete unnecessary comment block 2020-11-30 21:09:58 -06:00
Russell Johnson 99beebc2af Path: Replace all-caps variable name 2020-11-30 21:09:58 -06:00
Russell Johnson 43d54e7f18 Path: Simplify ActiveDocument references 2020-11-30 21:09:58 -06:00
Russell Johnson d52a96f2b5 Path: Fix rotational errors and organize/simplify some rotational code
Fix rotational alignment and drilling depth issues for rotational drilling ops.
Issues identified in forum at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=52262.
Path:
2020-11-30 20:57:25 -06:00
Russell Johnson 43cd864f8f Path: Clean up comments and simplify one code block 2020-11-30 20:57:25 -06:00
Russell Johnson 693db4e4b6 Path: Synchronize methods with same in PathAreaOp module
The affected methods exist in the PathAreaOp module.  This commit synchronizes the versions here with those.
2020-11-30 20:57:25 -06:00
Russell Johnson aa2d35cad8 Path: Apply the user's Final Depth value 2020-11-30 20:57:25 -06:00
Daniel Wood 5807c38416 [Path] Fix Typo - Stock object requires uppercase 'S' 2020-11-06 20:01:56 +01:00
luz paz b75cd3dd52 Path: Fix header uniformity and remove trailing whitespace
This PR fixes header uniformity across all Path files. It also removes all trailing whitespace.
2020-11-05 19:57:21 +01:00
Eric Trombly 7fe094ac02 add lazyloader support
lazy_loader is copied to Ext now, modified external imports to lazy_load

add a few more imports to be lazy loaded, think the install path is correct now

[TD]"<" symbol embedded in html

revert changes to path modules for testing

use lazyloader in PathAreaOp.py

add back in deferred loading

temp change to print error message in tests

temp change to print error message in tests

add _init__.py to lazy_loader

make install in CMakeLists.txt one line
2020-04-13 21:14:34 -05:00
Patrick F b8a32610c8 Bugfix for circular hole base 2020-04-02 19:38:21 +02:00
Patrick Felixberger c094889aac Fixed broken final depth calculation for rotational axis in pocket, profile and drill; Added EnableRotation to GUI; Fix some weird gcode generation 2020-03-11 21:16:21 +01:00
Russell Johnson 6af211fbd5 Restore manual override of FinalDepth values
Manual entries of FinalDepth values are now respected, even if below the calculated bottom of selected geometry.
Affected modules include PathPocketShape, PathPocket, PathCircularHoleBase, and PathAreaOp-based operations.

Fix format syntax issues
2020-02-14 19:38:35 -06:00
Markus Lampert 81f809cfcf Removed dead code for debugging shortcut warnings. 2020-01-03 23:13:55 -08:00
Markus Lampert b182d7b169 Fixed some pylint issues and whitelisted some 2019-11-28 17:31:36 -08:00
Markus Lampert 296058d6dd Added ToolController creation 2019-11-28 17:31:35 -08:00
luz.paz f22ae848ea Fix misc. typos, whitespace, and http:// to https:// issues 2019-09-03 11:11:43 -03:00
Daniel Wood bdcccc08b1 Add coolant feature to Ops 2019-08-28 19:40:08 +01:00
IMback cf4804ebc0 Improve irregular hole detection. 2019-08-11 20:56:17 +02:00
IMback 3148d92d6e Changed hole diameter detection to avoid tessilation inaccuracies in more cases. 2019-08-11 17:16:22 +02:00
Russell Johnson 47f1213f7c Re-enable Final Depths below hole bottom
Also some flake8 cleanup and removal of unnecessary comments and code.
2019-07-26 14:17:57 -05:00
Markus Lampert 6053c08c2c Downgrading debug msg 2019-07-14 22:25:57 -07:00
Markus Lampert 931aa851ba Return diameter 0 for invalid holes in order to let the UI initialize completely 2019-07-14 22:24:01 -07:00
Markus Lampert f9e23d21e3 Make Helix op robust against features that don't exist anymore 2019-07-14 21:30:38 -07:00
Russell Johnson ea5a1393f3 PathHelix: Add simple x,y path sorting
Same PathUtils.sort_jobs() method copied from PathDrilling
Change feedback comment to debug category
2019-07-12 10:05:18 -05:00
Russell Johnson 4e7e9a55e7 4th-axis rotation analysis Z-orientation fix
orientation == 'Z' was failing in some cases due to undefined "axis" variable. "axis" declaration was commented out in an earlier commit. Declaration now restored for all orientations.
2019-07-12 01:17:26 -05:00
luz.paz 752e74c396 Misc. typo fixes
Found via `codespell -q 2`
2019-07-11 19:17:07 +02:00
Markus Lampert 2a25993483 Catching new warnings due to merge 2019-07-01 15:32:54 -07:00
Markus Lampert f34ac89266 switched to pylint3 and fixed additional warnings 2019-07-01 15:32:54 -07:00
Russell Johnson 4fc39dfb36 PathDrilling 4th-axis integration
Initial integration of 4th-axis functionality to the Drilling op in PathWB
2019-06-30 14:14:38 -05:00
sliptonic b55c210f39 remove unnecessary imports. normalize debug log levels 2019-06-21 13:01:01 -05:00
luz.paz aedb888ae3 Path: source comment typo fixes
Found via `codespell`
2019-05-30 19:57:25 +02:00
sliptonic 094dda5900 Path: per Werner, fixing bug for function removed from string module
in py3
2019-03-18 08:35:37 -05:00
Markus Lampert f01eb07375 Added multi base model support to CircularHoleBase op 2018-09-11 07:24:34 +02:00
Markus Lampert 5f7faa25af Fixed hole detection for bottom faces. 2017-12-04 01:39:25 -08:00
Markus Lampert 25e92ca25b Added circular faces to drillable targets. 2017-12-03 15:08:20 -08:00
Markus Lampert 04ea26a66a Fix for missing base class initialisation during creation. 2017-12-02 11:06:45 -08:00
pekkaroi df1011d94f Path: Allow removing of all base objects in Circular hole tools 2017-11-21 17:19:57 -03:00
luzpaz 700c6bc3d2 Path: misc typo
[skip ci]
2017-10-02 01:14:09 +02:00
Markus Lampert 11db427b2e Fixed drilling depths and circular hole remove logic. 2017-09-28 11:27:47 -07:00
Markus Lampert e804977558 Consolidated all depth calculations. 2017-09-28 11:27:47 -07:00
Markus Lampert b432364830 Implemented interface functions in base classes. 2017-09-26 10:51:17 -03:00
Markus Lampert 5741e6f202 Fixed circular hole diameter for cases where the selected edge is not the full circle. 2017-09-21 11:35:00 -07:00
Markus Lampert 353ebde7ab Reduced log level to info. 2017-08-28 11:52:10 -03:00
Markus Lampert 1f1e887103 Fixed error in circular hole when created with invalid features. Not sure how they get through but they should not cause an exception. 2017-08-22 10:16:58 -03:00