Commit Graph

1176 Commits

Author SHA1 Message Date
Russell Johnson 082c44464b 3D Pocket: upgrade to adaptive start and finish
apply algorithms to some pockets to eliminate air milling and adapt start and finish heights and paths to top and bottom of certain pockets.
Depth correction & flake8 formatting
use list to track successive cuts so variations of settings are tracked and applied correctly
Apply faceType specific depth calculations
Planar face requires one depth source, non-planar requires a different source.
2019-07-21 21:21:24 -05:00
Markus Lampert 6053c08c2c Downgrading debug msg 2019-07-14 22:25:57 -07:00
Markus Lampert 931aa851ba Return diameter 0 for invalid holes in order to let the UI initialize completely 2019-07-14 22:24:01 -07:00
Markus Lampert f9e23d21e3 Make Helix op robust against features that don't exist anymore 2019-07-14 21:30:38 -07:00
Russell Johnson ea5a1393f3 PathHelix: Add simple x,y path sorting
Same PathUtils.sort_jobs() method copied from PathDrilling
Change feedback comment to debug category
2019-07-12 10:05:18 -05:00
Russell Johnson 4e7e9a55e7 4th-axis rotation analysis Z-orientation fix
orientation == 'Z' was failing in some cases due to undefined "axis" variable. "axis" declaration was commented out in an earlier commit. Declaration now restored for all orientations.
2019-07-12 01:17:26 -05:00
luz.paz 752e74c396 Misc. typo fixes
Found via `codespell -q 2`
2019-07-11 19:17:07 +02:00
Markus Lampert fb0a5c8fa5 pylint3 cleanup of (most) post processors 2019-07-09 21:12:46 -07:00
Markus Lampert 5659a0ecc0 Cleaned up Path op utilities 2019-07-09 19:48:26 -07:00
Russell Johnson 8da553bd60 Add new property to SetupProperties()
StartRadius property addedd
2019-07-03 19:52:02 -05:00
sliptonic f705f6f40a Path: add helix start radius 2019-07-03 19:21:41 -05:00
Russell Johnson d5356d2c38 Fix EnableRotation property
PathCircularHoleBase uses `EnableRotation` property
2019-07-03 11:45:53 -05:00
Markus Lampert 6a7cd2c403 Fixed import of PostUtils 2019-07-02 21:16:53 -07:00
Markus Lampert 4527f7651b Fixed Job creation 2019-07-02 21:16:38 -07:00
Markus Lampert d6a20be999 Fixed typo and py3 exception printing 2019-07-02 21:03:28 -07:00
sliptonic 0a1067801e Merge pull request #2313 from sliptonic/lgtm3
Additional LGTM cleanup of post processors and unneeded imports
2019-07-02 09:17:27 -05:00
Russell Johnson af825250d8 Fix SetupProperties() property syntax issue
fix for SetupProperties() issue presented at:
https://forum.freecadweb.org/viewtopic.php?f=15&t=37368#p318253
2019-07-01 22:02:18 -05:00
Markus Lampert c5c976f204 Addressed pylint warnings for PathGeom 2019-07-01 15:58:34 -07:00
Markus Lampert ed8911c9b7 Addressed pylint warnings for PathAreaOp 2019-07-01 15:49:38 -07:00
Markus Lampert fe9e341835 Fixing additional warnings after merge 2019-07-01 15:49:31 -07:00
Markus Lampert 2a25993483 Catching new warnings due to merge 2019-07-01 15:32:54 -07:00
Markus Lampert f34ac89266 switched to pylint3 and fixed additional warnings 2019-07-01 15:32:54 -07:00
Markus Lampert 04b4db1d8d Addressed pylint warnings for PathDressups 2019-07-01 15:32:54 -07:00
Markus Lampert f16703e949 Addressed pylint warnings for PathPost 2019-07-01 15:32:54 -07:00
Markus Lampert b552853027 Addressed pylint warnings for PathPreferences 2019-07-01 15:32:54 -07:00
Markus Lampert 71994e55fa Addressed pylint warnings for PathProfileFaces 2019-07-01 15:32:54 -07:00
Markus Lampert 68f839d86a Fixed pylint warnings for PathGui family 2019-07-01 15:32:54 -07:00
Markus Lampert 4e46bbf811 Fixed pylint warnings for PathUtil family 2019-07-01 15:32:54 -07:00
Markus Lampert 7518226d0f Cleanup of PathLog for pylint warnings 2019-07-01 15:32:54 -07:00
Markus Lampert fad9f77026 Cleanup of PathJobGui for pylint warnings 2019-07-01 15:32:54 -07:00
Markus Lampert aaec4c0b37 Cleanup of PathMillFaceGui for pylint warnings 2019-07-01 15:32:54 -07:00
Markus Lampert b7ace85341 Cleanup of PathIconViewProvider for pylint warnings 2019-07-01 15:32:54 -07:00
Markus Lampert 253f356285 Cleaned up pylint warnings for PathGetPoint 2019-07-01 15:32:54 -07:00
Markus Lampert aef9969b13 Addressed pylint warnings for PathTool family 2019-07-01 15:32:54 -07:00
Markus Lampert c870d3388d pylint warnings for PathSelection 2019-07-01 15:32:54 -07:00
Markus Lampert 80e991a056 addressing pylint warnings for PathProfile family 2019-07-01 15:32:54 -07:00
Markus Lampert 7abb496144 addressed pylint warnings for PathPocket family 2019-07-01 15:32:54 -07:00
Markus Lampert 3098d75073 pylint cleanup for path setup sheet 2019-07-01 15:29:51 -07:00
Markus Lampert 2a97d558e8 pylint warning for PathDeburr 2019-07-01 15:29:51 -07:00
Markus Lampert 8896a84372 More dogbond pylint cleanup 2019-07-01 15:29:51 -07:00
Markus Lampert a9b2e8e96f Cleaned up warnings for PathEngraveBase 2019-07-01 15:29:51 -07:00
Markus Lampert 8769618cab Fixed pylint warnings for PathDressupDogbone 2019-07-01 15:29:51 -07:00
Markus Lampert c17989fede Fixed pylint warnings for PathDressupTag 2019-07-01 15:29:51 -07:00
Markus Lampert ef74365142 Fixed pylint warnings for PathSetupSheet 2019-07-01 15:29:51 -07:00
Markus Lampert 64bd8105a6 Some more pylint warning cleanup 2019-07-01 15:29:51 -07:00
Markus Lampert 6f52808e91 fixed pylint warning for PathOp 2019-07-01 15:29:51 -07:00
Markus Lampert 83581d7047 fixed pylint warning for PathJob 2019-07-01 15:29:51 -07:00
sliptonic ecc3994337 path: LGTM cleanup post processors 2019-07-01 17:18:15 -05:00
sliptonic 02b68f36fb Path: lgtm cleanup PathAreaOp 2019-07-01 17:18:15 -05:00
Russell Johnson 1ac8f4cfe9 4th-axis update (#2311)
Improve property creation
Improve property setup
Implement PathLog.debug() for troubleshooting.
Improve default property values.
Remove unused and incomplete method
Remove unnecessary comments; fix final depth issue
4th-axis improvements
rotation method improvements
remove extra comment blocks
fix incorrect variable references
fix -0.0 re-introduction after initial filter
negative zero re-introduced causes problems with naming method for temp clones
Update faceRotationAnalaysis() method
update opFeatures()
Commented out call to PathOp.FeatureRotation
This feature not yet implemented.
delete call to removed method - self.reportThis()
Remove unnecessary comments
2019-07-01 09:30:58 -05:00