Commit Graph

753 Commits

Author SHA1 Message Date
Uwe 07ddfc88de [PD] App: remove superfluous nullptr checks
- also Body: get rid of some nasty single-letter variables
2022-07-17 18:07:00 +02:00
wmayer 656408615a PD: fix ProfileBased::getSupportFace() to also handle the case where a support face is selected 2022-07-16 16:08:09 +02:00
wmayer 882125c1c6 PD: rename getUpToFaceFromLinkSub to getFaceFromLinkSub 2022-07-16 15:59:54 +02:00
wmayer 8ae3185e3b Part: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 13:31:10 +02:00
Uwe c5678ef373 [PD] FeatureDressUp.cpp: add missing include 2022-07-03 21:20:01 +02:00
Uwe 1b2f0063a1 [PD] Hole initialization bugfix
- by default there is no hole head cut and therefore its parameter must be initialized as read-only (will be enably when user sets a head cut)

- also fix a typo

- also fix a UI file issue (automatically done by Qt Designer)
2022-06-25 16:36:50 +02:00
andrea 93525ff7eb removed references to OCC<7 2022-06-25 14:29:24 +02:00
wmayer 5a432fe9ac PD: allow to clear the shape when nullifying the Support property 2022-06-12 14:01:19 +02:00
wmayer d492ac3083 PD: fixes #6451: Face color of PartDesign Body not exported to STEP 2022-05-24 16:42:27 +02:00
Ajinkya Dahale a59dac1675 [PD] Do both fuse and cut in FeatureTransformed if applicable 2022-04-23 17:55:18 +02:00
Ajinkya Dahale 4358a9ba70 [PD] Delete "Overlap" property for FeatureTransformed
This property became redundant after 5ab7d17f67.
2022-04-21 01:21:59 +02:00
wmayer 5ab7d17f67 PD: issue #6641: polar pattern fails 2022-04-12 16:32:54 +02:00
Uwe c27e016521 [PD] shape binder: code style improvements
all done by MSVC
2022-03-27 21:48:09 +02:00
Uwe 66e4c37a25 fix some occurrences where size() is misused as Boolean
- as suggested by @wwmayer: https://github.com/FreeCAD/FreeCAD/commit/4d51d1d0b1c2cd33cd443d477c60eb575fc0e52f#r69648152
2022-03-27 21:38:15 +02:00
wmayer 37f1004db2 PD: include header with export macros 2022-03-24 21:09:19 +01:00
wmayer 97330443a2 All: modernize C++11
* replace deprecated headers
2022-03-23 22:44:18 +01:00
Uwe ea81ce76b4 [PD] fix #6482
The idea with the large factor, introduced in #5363 fixed real bugs, so it should not be reverted.
However we must compensate the factor at the path position movement. Otherwise we get wrong helix positions when the angle is negative.

The PR was tested with the files in the bug reports:
https://forum.freecadweb.org/viewtopic.php?f=3&t=65136
https://forum.freecadweb.org/viewtopic.php?p=572618#p572618
2022-03-23 19:29:02 +01:00
wmayer 3608ee7f51 PD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Uwe b037d8e240 [PD] remove unused Xerces 2022-03-20 20:43:02 +01:00
wmayer c9a0fae9db lgtm: [skip ci] FIXME comment
Change FIXME or remove it
2022-03-20 16:51:23 +01:00
Uwe d06dc1527c [PD] remove Python.h from headers
seems not to be necessary anymore
2022-03-20 14:16:41 +01:00
wmayer 0054cbddaa Fix coverity issue:
* CID 332682: Resource leak
* CID 350607: Resource leak
* CID 332677: Resource leak
2022-03-14 11:35:04 +01:00
wmayer 55f8d68b4e PD: Fix coverity issue:
* CID 350645: Uncaught exception
2022-03-13 17:24:07 +01:00
wmayer 02bd57ac82 PD: Fix several coverity issues:
* CID 350622: Negative array index read
* CID 350613: Negative array index read
* CID 166163: Negative array index read
* refactor Hole::updateDiameterParam()
2022-03-13 12:10:01 +01:00
mwganson 3e18c76d4f PartDesign::SubShapeBinder add 2D offsetting 2022-03-12 23:30:09 +01:00
Zheng, Lei b47e6723dc PD: add SubShapeBinder 'Refine' property
Respect setting in BaseApp/Preferences/Mod/PartDesign/RefineModel
2022-03-12 02:45:13 +01:00
Zheng, Lei e56bcbc924 PD: fix SubShapeBinder 'Fuse' function 2022-03-12 02:45:13 +01:00
Uwe b5163ab49f [PD] Boolean: re-add necessary include 2022-03-02 02:50:46 +01:00
Uwe 1e640865a9 [PD] Boolean: remove unused include 2022-03-02 02:30:28 +01:00
mosfet80 ebe57601cd PD: remove duplicate verifications 2022-03-01 17:41:09 +01:00
wmayer 5e0789e2f1 PD: fix const correctness in ProfileBased 2022-02-28 18:10:58 +01:00
wmayer b05fb73196 PD: [skip ci] refactor Hole feature 2022-02-26 17:06:38 +01:00
wmayer 3ce87cb2fa PD: [skip ci] refactor Hole feature 2022-02-26 16:48:37 +01:00
wmayer 9ddfcb89a5 PD: [skip ci] fix const correctness in Hole feature 2022-02-26 16:34:44 +01:00
wmayer df0fac1de8 PD: [skip ci] refactor Hole feature 2022-02-26 16:18:20 +01:00
wmayer 4753b0232d PD: fix error 'gp_Dir::Crossed() - result vector has zero norm'
As reported here: https://forum.freecadweb.org/viewtopic.php?f=3&t=65826
2022-02-26 16:07:35 +01:00
Uwe 7162c1a1f4 [PD] final work to remove unused includes 2022-02-22 02:18:49 +01:00
Uwe 660436d50b [PD] remove some more unused includes 2022-02-21 15:13:54 +01:00
Uwe 02c8b0452e [PD] some more work to remove unused includes 2022-02-21 02:50:16 +01:00
Uwe fd19d1a7b0 [PD] more work to remove unused includes 2022-02-21 02:18:17 +01:00
Uwe 4b08dd8142 [PD] Boolean to Groove: remove unused includes 2022-02-21 01:07:36 +01:00
Uwe fc151aa8b5 [PD] Workbench and Command: remove unused includes 2022-02-20 21:55:15 +01:00
Uwe c7e48869b6 [PD] Body and utils: remove unused includes 2022-02-20 21:23:05 +01:00
Uwe 7c44008e2d [PD] App: remove unused includes 2022-02-20 20:41:46 +01:00
Syres916 7200915317 [PartDesign] OCC7.3 regression replace include.. (#6402)
* [PD] OCC 7.3 needs Precision.hxx in header
2022-02-20 18:44:06 +01:00
Uwe c1fbf28e22 [PD] Datums: remove unused includes 2022-02-19 19:32:00 +01:00
Uwe 7c8031d356 [PD] Hole, Pipe and Revolution: remove unused includes 2022-02-19 18:47:26 +01:00
Uwe 61d54b6078 [PD] Pad and Pocket: remove unused includes 2022-02-19 17:57:11 +01:00
Uwe 9b7572e9a9 [PD] FeatureHelix: simplify code
- also rename some variables for better readability
- remove unused includes
2022-02-19 00:48:11 +01:00
wmayer 95f583a677 Part: fix typos in make* functions 2022-02-16 12:48:02 +01:00