From b0e11e286b4ec29b0f2b4e0e6730ab35d3d4f317 Mon Sep 17 00:00:00 2001 From: wandererfan Date: Wed, 18 Feb 2026 14:47:46 -0500 Subject: [PATCH 1/2] [TD]use thin line for smooth edges --- src/Mod/TechDraw/Gui/QGIViewPart.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Mod/TechDraw/Gui/QGIViewPart.cpp b/src/Mod/TechDraw/Gui/QGIViewPart.cpp index 4d1744be9c..2c5d48fe3a 100644 --- a/src/Mod/TechDraw/Gui/QGIViewPart.cpp +++ b/src/Mod/TechDraw/Gui/QGIViewPart.cpp @@ -393,7 +393,7 @@ void QGIViewPart::drawAllEdges() const TechDraw::BaseGeomPtrVector& geoms = dvp->getEdgeGeometry(); TechDraw::BaseGeomPtrVector::const_iterator itGeom = geoms.begin(); - QGIEdge* item; + QGIEdge* item{}; for (int iEdge = 0; itGeom != geoms.end(); itGeom++, iEdge++) { bool showItem = true; if (!showThisEdge(*itGeom)) { @@ -444,8 +444,11 @@ void QGIViewPart::drawAllEdges() item->setZValue(ZVALUE::HIDEDGE); } else { // unformatted visible line, draw as continuous line - item->setLinePen(m_dashedLineGenerator->getLinePen(1, vp->LineWidth.getValue())); - item->setWidth(Rez::guiX(vp->LineWidth.getValue())); + // "smooth" edges should use the "thin" width as used for hidden lines. + double width = (*itGeom)->getClassOfEdge() == EdgeClass::SMOOTH ? + vp->HiddenWidth.getValue() : vp->LineWidth.getValue(); + item->setLinePen(m_dashedLineGenerator->getLinePen(1, width)); + item->setWidth(Rez::guiX(width)); } } } From ba24ab8a49ccfa75e5e3b831dcee2a2e66867ee4 Mon Sep 17 00:00:00 2001 From: wandererfan Date: Wed, 18 Feb 2026 18:34:08 -0500 Subject: [PATCH 2/2] [TD]fix unhelpful warning message --- src/Mod/TechDraw/Gui/QGIViewPart.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Mod/TechDraw/Gui/QGIViewPart.cpp b/src/Mod/TechDraw/Gui/QGIViewPart.cpp index 2c5d48fe3a..be1af4c2f5 100644 --- a/src/Mod/TechDraw/Gui/QGIViewPart.cpp +++ b/src/Mod/TechDraw/Gui/QGIViewPart.cpp @@ -418,8 +418,10 @@ void QGIViewPart::drawAllEdges() showItem = formatGeomFromCenterLine(cTag, item); } else { - Base::Console().message("QGIVP::drawVP - cosmetic edge: %d is confused - source: %d\n", - iEdge, static_cast(source)); + // there are 3 source types (GEOMETRY, COSMETICEDGE, CENTERLINE). Something broke if we + // get here for for an edge that claims to be cosmetic. + Base::Console().warning("In %s, cosmetic edge: %d is neither COSMETICEDGE nor CENTERLINE - actual source type: %d\n", + dvp->Label.getValue(), iEdge, static_cast(source)); } } else { // geometry edge - apply format if applicable