From 80dc19d0c042a9a0a96ca495ee1b8b146f571eb9 Mon Sep 17 00:00:00 2001 From: Alfredo Monclus Date: Fri, 20 Mar 2026 03:48:36 -0300 Subject: [PATCH] Merge pull request #28461 from alfrix/fix_no_sketch PD: hole fix cosmetic threads not working without sketches --- src/Mod/PartDesign/Gui/ViewProviderHole.cpp | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/Mod/PartDesign/Gui/ViewProviderHole.cpp b/src/Mod/PartDesign/Gui/ViewProviderHole.cpp index 72c4210192..3137367dfc 100644 --- a/src/Mod/PartDesign/Gui/ViewProviderHole.cpp +++ b/src/Mod/PartDesign/Gui/ViewProviderHole.cpp @@ -333,15 +333,11 @@ std::optional ViewProviderHole::getHoleOrigin(const PartDesign::Hole* pc if (!pcHole) { return std::nullopt; } - - auto* sketch = freecad_cast(pcHole->Profile.getValue()); - - if (!sketch) { - return std::nullopt; + if (auto* profile = pcHole->Profile.getValue()) { + const Base::Vector3d pos = profile->getPlacement().getPosition(); + return Base::convertTo(pos); } - - const Base::Vector3d& pos = sketch->Placement.getValue().getPosition(); - return Base::convertTo(pos); + return std::nullopt; } std::vector ViewProviderHole::collectBoreFaces(const PartDesign::Hole* pcHole) const