diff --git a/src/Mod/Fem/App/FemPostFilter.cpp b/src/Mod/Fem/App/FemPostFilter.cpp index 5b922016b1..ef773e558f 100644 --- a/src/Mod/Fem/App/FemPostFilter.cpp +++ b/src/Mod/Fem/App/FemPostFilter.cpp @@ -28,10 +28,10 @@ # include #endif +#include + #include "FemPostFilter.h" #include "FemPostPipeline.h" -#include -#include #include @@ -459,10 +459,10 @@ FemPostScalarClipFilter::~FemPostScalarClipFilter() { DocumentObjectExecReturn* FemPostScalarClipFilter::execute(void) { std::string val; - if (m_scalarFields.getEnums() && Scalars.getValue() >= 0) + if (Scalars.getValue() >= 0) val = Scalars.getValueAsString(); - std::vector array; + std::vector ScalarsArray; vtkSmartPointer data = getInputData(); if (!data || !data->IsA("vtkDataSet")) @@ -471,18 +471,21 @@ DocumentObjectExecReturn* FemPostScalarClipFilter::execute(void) { vtkDataSet* dset = vtkDataSet::SafeDownCast(data); vtkPointData* pd = dset->GetPointData(); + // get all scalar fields for (int i = 0; i < pd->GetNumberOfArrays(); ++i) { if (pd->GetArray(i)->GetNumberOfComponents() == 1) - array.push_back(pd->GetArrayName(i)); + ScalarsArray.emplace_back(pd->GetArrayName(i)); } App::Enumeration empty; Scalars.setValue(empty); - m_scalarFields.setEnums(array); + m_scalarFields.setEnums(ScalarsArray); Scalars.setValue(m_scalarFields); - std::vector::iterator it = std::find(array.begin(), array.end(), val); - if (!val.empty() && it != array.end()) + // search if the current field is in the available ones and set it + std::vector::iterator it = + std::find(ScalarsArray.begin(), ScalarsArray.end(), val); + if (!val.empty() && it != ScalarsArray.end()) Scalars.setValue(val.c_str()); //recalculate the filter @@ -510,11 +513,10 @@ short int FemPostScalarClipFilter::mustExecute(void) const { if (Value.isTouched() || InsideOut.isTouched() || - Scalars.isTouched()) { - + Scalars.isTouched()) return 1; - } - else return App::DocumentObject::mustExecute(); + else + return App::DocumentObject::mustExecute(); } void FemPostScalarClipFilter::setConstraintForField() { @@ -562,10 +564,10 @@ FemPostWarpVectorFilter::~FemPostWarpVectorFilter() { DocumentObjectExecReturn* FemPostWarpVectorFilter::execute(void) { std::string val; - if (m_vectorFields.getEnums() && Vector.getValue() >= 0) + if (Vector.getValue() >= 0) val = Vector.getValueAsString(); - std::vector array; + std::vector VectorArray; vtkSmartPointer data = getInputData(); if (!data || !data->IsA("vtkDataSet")) @@ -574,18 +576,21 @@ DocumentObjectExecReturn* FemPostWarpVectorFilter::execute(void) { vtkDataSet* dset = vtkDataSet::SafeDownCast(data); vtkPointData* pd = dset->GetPointData(); + // get all vector fields for (int i = 0; i < pd->GetNumberOfArrays(); ++i) { if (pd->GetArray(i)->GetNumberOfComponents() == 3) - array.push_back(pd->GetArrayName(i)); + VectorArray.emplace_back(pd->GetArrayName(i)); } App::Enumeration empty; Vector.setValue(empty); - m_vectorFields.setEnums(array); + m_vectorFields.setEnums(VectorArray); Vector.setValue(m_vectorFields); - std::vector::iterator it = std::find(array.begin(), array.end(), val); - if (!val.empty() && it != array.end()) + // search if the current field is in the available ones and set it + std::vector::iterator it = + std::find(VectorArray.begin(), VectorArray.end(), val); + if (!val.empty() && it != VectorArray.end()) Vector.setValue(val.c_str()); //recalculate the filter @@ -594,13 +599,11 @@ DocumentObjectExecReturn* FemPostWarpVectorFilter::execute(void) { void FemPostWarpVectorFilter::onChanged(const Property* prop) { - if (prop == &Factor) { + if (prop == &Factor) m_warp->SetScaleFactor(Factor.getValue()); - } - else if (prop == &Vector && (Vector.getValue() >= 0)) { + else if (prop == &Vector && (Vector.getValue() >= 0)) m_warp->SetInputArrayToProcess(0, 0, 0, vtkDataObject::FIELD_ASSOCIATION_POINTS, Vector.getValueAsString()); - } Fem::FemPostFilter::onChanged(prop); } @@ -608,11 +611,10 @@ void FemPostWarpVectorFilter::onChanged(const Property* prop) { short int FemPostWarpVectorFilter::mustExecute(void) const { if (Factor.isTouched() || - Vector.isTouched()) { - + Vector.isTouched()) return 1; - } - else return App::DocumentObject::mustExecute(); + else + return App::DocumentObject::mustExecute(); } diff --git a/src/Mod/Fem/femsolver/elmer/tasks.py b/src/Mod/Fem/femsolver/elmer/tasks.py index d72e74c924..b0eb0b9831 100644 --- a/src/Mod/Fem/femsolver/elmer/tasks.py +++ b/src/Mod/Fem/femsolver/elmer/tasks.py @@ -237,7 +237,6 @@ class Results(run.Results): # at the moment we scale the mesh back using Elmer # this might be changed in future, therefore leave this #self.solver.ElmerResult.scale(1000) - self.solver.ElmerResult.getLastPostObject().touch() self.solver.ElmerResult.recomputeChildren() self.solver.Document.recompute()