From 5c6bf5461da7c28dbd827eb5fa52af464d872a6d Mon Sep 17 00:00:00 2001 From: theo-vt Date: Wed, 25 Feb 2026 22:25:29 -0500 Subject: [PATCH] Remove most activate-deactivate --- src/Mod/Fem/Gui/TaskDlgCreateNodeSet.cpp | 10 --------- src/Mod/Fem/Gui/TaskDlgCreateNodeSet.h | 3 --- src/Mod/Fem/Gui/TaskFemConstraint.cpp | 9 -------- src/Mod/Fem/Gui/TaskFemConstraint.h | 3 --- src/Mod/Measure/Gui/TaskMeasure.cpp | 4 ---- src/Mod/Part/Gui/DlgExtrusion.cpp | 9 -------- src/Mod/Part/Gui/DlgExtrusion.h | 2 -- src/Mod/Part/Gui/DlgFilletEdges.cpp | 9 -------- src/Mod/Part/Gui/DlgFilletEdges.h | 2 -- src/Mod/Part/Gui/DlgProjectionOnSurface.cpp | 18 --------------- src/Mod/Part/Gui/DlgProjectionOnSurface.h | 4 ---- src/Mod/Part/Gui/DlgRevolution.cpp | 19 ++-------------- src/Mod/Part/Gui/DlgRevolution.h | 3 --- src/Mod/Part/Gui/Mirroring.cpp | 9 -------- src/Mod/Part/Gui/Mirroring.h | 2 -- src/Mod/Part/Gui/TaskAttacher.cpp | 12 ---------- src/Mod/Part/Gui/TaskAttacher.h | 3 --- src/Mod/Part/Gui/TaskFaceAppearances.cpp | 9 -------- src/Mod/Part/Gui/TaskFaceAppearances.h | 2 -- src/Mod/Part/Gui/TaskShapeBuilder.cpp | 9 -------- src/Mod/Part/Gui/TaskShapeBuilder.h | 2 -- .../PartDesign/Gui/TaskBooleanParameters.cpp | 9 -------- .../PartDesign/Gui/TaskBooleanParameters.h | 2 -- .../PartDesign/Gui/TaskDressUpParameters.cpp | 9 -------- .../PartDesign/Gui/TaskDressUpParameters.h | 2 -- .../PartDesign/Gui/TaskFeatureParameters.cpp | 22 ------------------- .../PartDesign/Gui/TaskFeatureParameters.h | 2 -- src/Mod/PartDesign/Gui/TaskFeaturePick.cpp | 8 ------- src/Mod/PartDesign/Gui/TaskFeaturePick.h | 3 --- src/Mod/PartDesign/Gui/TaskShapeBinder.cpp | 8 ------- src/Mod/PartDesign/Gui/TaskShapeBinder.h | 2 -- .../Gui/TaskTransformedParameters.cpp | 9 -------- .../Gui/TaskTransformedParameters.h | 3 --- src/Mod/Surface/Gui/TaskFilling.cpp | 17 -------------- src/Mod/Surface/Gui/TaskFilling.h | 2 -- src/Mod/Surface/Gui/TaskGeomFillSurface.cpp | 8 ------- src/Mod/Surface/Gui/TaskGeomFillSurface.h | 2 -- src/Mod/Surface/Gui/TaskSections.cpp | 9 -------- src/Mod/Surface/Gui/TaskSections.h | 2 -- 39 files changed, 2 insertions(+), 260 deletions(-) diff --git a/src/Mod/Fem/Gui/TaskDlgCreateNodeSet.cpp b/src/Mod/Fem/Gui/TaskDlgCreateNodeSet.cpp index 0b0d1a4bd2..49c160ba07 100644 --- a/src/Mod/Fem/Gui/TaskDlgCreateNodeSet.cpp +++ b/src/Mod/Fem/Gui/TaskDlgCreateNodeSet.cpp @@ -102,14 +102,4 @@ bool TaskDlgCreateNodeSet::reject() void TaskDlgCreateNodeSet::helpRequested() {} -void TaskDlgCreateNodeSet::activate() -{ - param->attachSelection(); - param->setSelectionGate(); -} -void TaskDlgCreateNodeSet::deactivate() -{ - param->detachSelection(); -} - #include "moc_TaskDlgCreateNodeSet.cpp" diff --git a/src/Mod/Fem/Gui/TaskDlgCreateNodeSet.h b/src/Mod/Fem/Gui/TaskDlgCreateNodeSet.h index 201b658602..a6e38bbc0a 100644 --- a/src/Mod/Fem/Gui/TaskDlgCreateNodeSet.h +++ b/src/Mod/Fem/Gui/TaskDlgCreateNodeSet.h @@ -62,9 +62,6 @@ public: /// is called by the framework if the user press the help button void helpRequested() override; - void activate() override; - void deactivate() override; - /// returns for Close and Help button QDialogButtonBox::StandardButtons getStandardButtons() const override { diff --git a/src/Mod/Fem/Gui/TaskFemConstraint.cpp b/src/Mod/Fem/Gui/TaskFemConstraint.cpp index 0850f09e79..00a58286d6 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraint.cpp +++ b/src/Mod/Fem/Gui/TaskFemConstraint.cpp @@ -273,13 +273,4 @@ bool TaskDlgFemConstraint::reject() return true; } -void TaskDlgFemConstraint::activate() -{ - parameter->attachSelection(); -} -void TaskDlgFemConstraint::deactivate() -{ - parameter->detachSelection(); -} - #include "moc_TaskFemConstraint.cpp" diff --git a/src/Mod/Fem/Gui/TaskFemConstraint.h b/src/Mod/Fem/Gui/TaskFemConstraint.h index dd1746d704..6ef6a25051 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraint.h +++ b/src/Mod/Fem/Gui/TaskFemConstraint.h @@ -112,9 +112,6 @@ public: /// is called by the framework if the dialog is rejected (Cancel) bool reject() override; - void activate() override; - void deactivate() override; - bool isAllowedAlterDocument() const override { return false; diff --git a/src/Mod/Measure/Gui/TaskMeasure.cpp b/src/Mod/Measure/Gui/TaskMeasure.cpp index e3a0a44491..44042ba39a 100644 --- a/src/Mod/Measure/Gui/TaskMeasure.cpp +++ b/src/Mod/Measure/Gui/TaskMeasure.cpp @@ -626,14 +626,10 @@ void TaskMeasure::reset() void TaskMeasure::activate() { updateSelectionType(); - // engage the selectionObserver - attachSelection(); qApp->installEventFilter(this); } void TaskMeasure::deactivate() { - Gui::Selection().setSelectionStyle(SelectionStyle::NormalSelection); - detachSelection(); qApp->removeEventFilter(this); } diff --git a/src/Mod/Part/Gui/DlgExtrusion.cpp b/src/Mod/Part/Gui/DlgExtrusion.cpp index f85dd1983d..556981a801 100644 --- a/src/Mod/Part/Gui/DlgExtrusion.cpp +++ b/src/Mod/Part/Gui/DlgExtrusion.cpp @@ -936,14 +936,5 @@ void TaskExtrusion::clicked(int id) }; } } -void TaskExtrusion::activate() -{ - widget->setSelectionGate(); - widget->attachSelection(); -} -void TaskExtrusion::deactivate() -{ - widget->detachSelection(); -} #include "moc_DlgExtrusion.cpp" diff --git a/src/Mod/Part/Gui/DlgExtrusion.h b/src/Mod/Part/Gui/DlgExtrusion.h index 775f5e80a7..fb182294c0 100644 --- a/src/Mod/Part/Gui/DlgExtrusion.h +++ b/src/Mod/Part/Gui/DlgExtrusion.h @@ -117,8 +117,6 @@ public: bool accept() override; bool reject() override; void clicked(int) override; - void activate() override; - void deactivate() override; QDialogButtonBox::StandardButtons getStandardButtons() const override { diff --git a/src/Mod/Part/Gui/DlgFilletEdges.cpp b/src/Mod/Part/Gui/DlgFilletEdges.cpp index de35b0184b..9268a6564b 100644 --- a/src/Mod/Part/Gui/DlgFilletEdges.cpp +++ b/src/Mod/Part/Gui/DlgFilletEdges.cpp @@ -1197,15 +1197,6 @@ bool TaskFilletEdges::reject() Gui::Command::doCommand(Gui::Command::Gui, "Gui.activeDocument().resetEdit()"); return true; } -void TaskFilletEdges::activate() -{ - widget->setSelectionGate(); - widget->attachSelection(); -} -void TaskFilletEdges::deactivate() -{ - widget->detachSelection(); -} // -------------------------------------------------------------- diff --git a/src/Mod/Part/Gui/DlgFilletEdges.h b/src/Mod/Part/Gui/DlgFilletEdges.h index 798d00ed37..dc4ede763b 100644 --- a/src/Mod/Part/Gui/DlgFilletEdges.h +++ b/src/Mod/Part/Gui/DlgFilletEdges.h @@ -187,8 +187,6 @@ public: void clicked(int) override; bool accept() override; bool reject() override; - void activate() override; - void deactivate() override; QDialogButtonBox::StandardButtons getStandardButtons() const override { diff --git a/src/Mod/Part/Gui/DlgProjectionOnSurface.cpp b/src/Mod/Part/Gui/DlgProjectionOnSurface.cpp index cb778d002d..b376ac3598 100644 --- a/src/Mod/Part/Gui/DlgProjectionOnSurface.cpp +++ b/src/Mod/Part/Gui/DlgProjectionOnSurface.cpp @@ -1225,15 +1225,6 @@ bool TaskProjectionOnSurface::reject() widget->reject(); return true; } -void TaskProjectionOnSurface::activate() -{ - widget->setSelectionGate(); - widget->attachSelection(); -} -void TaskProjectionOnSurface::deactivate() -{ - widget->detachSelection(); -} void TaskProjectionOnSurface::clicked(int id) { @@ -1661,14 +1652,5 @@ bool TaskProjectOnSurface::reject() resetEdit(); return true; } -void TaskProjectOnSurface::activate() -{ - widget->setSelectionGate(); - widget->attachSelection(); -} -void TaskProjectOnSurface::deactivate() -{ - widget->detachSelection(); -} #include "moc_DlgProjectionOnSurface.cpp" diff --git a/src/Mod/Part/Gui/DlgProjectionOnSurface.h b/src/Mod/Part/Gui/DlgProjectionOnSurface.h index 78a2c354d7..a2694294f2 100644 --- a/src/Mod/Part/Gui/DlgProjectionOnSurface.h +++ b/src/Mod/Part/Gui/DlgProjectionOnSurface.h @@ -172,8 +172,6 @@ public: bool accept() override; bool reject() override; void clicked(int id) override; - void activate() override; - void deactivate() override; QDialogButtonBox::StandardButtons getStandardButtons() const override { @@ -250,8 +248,6 @@ public: public: bool accept() override; bool reject() override; - void activate() override; - void deactivate() override; QDialogButtonBox::StandardButtons getStandardButtons() const override { diff --git a/src/Mod/Part/Gui/DlgRevolution.cpp b/src/Mod/Part/Gui/DlgRevolution.cpp index 722716fa4f..6a59d21fe9 100644 --- a/src/Mod/Part/Gui/DlgRevolution.cpp +++ b/src/Mod/Part/Gui/DlgRevolution.cpp @@ -528,19 +528,13 @@ void DlgRevolution::accept() QDialog::accept(); } -void DlgRevolution::setSelectionGate() -{ - if (filterSelection) { - filter = new EdgeSelection(); - Gui::Selection().addSelectionGate(filter); - } -} void DlgRevolution::onSelectLineClicked() { if (!filterSelection) { filterSelection = true; - setSelectionGate(); + filter = new EdgeSelection(); + Gui::Selection().addSelectionGate(filter); ui->selectLine->setText(tr("Selecting… (Line or Arc)")); } else { @@ -677,14 +671,5 @@ bool TaskRevolution::accept() widget->accept(); return (widget->result() == QDialog::Accepted); } -void TaskRevolution::activate() -{ - widget->setSelectionGate(); - widget->attachSelection(); -} -void TaskRevolution::deactivate() -{ - widget->detachSelection(); -} #include "moc_DlgRevolution.cpp" diff --git a/src/Mod/Part/Gui/DlgRevolution.h b/src/Mod/Part/Gui/DlgRevolution.h index 236e9a2b5e..36722d1e01 100644 --- a/src/Mod/Part/Gui/DlgRevolution.h +++ b/src/Mod/Part/Gui/DlgRevolution.h @@ -42,7 +42,6 @@ public: explicit DlgRevolution(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~DlgRevolution() override; void accept() override; - void setSelectionGate(); Base::Vector3d getDirection() const; Base::Vector3d getPosition() const; @@ -96,8 +95,6 @@ public: public: bool accept() override; - void activate() override; - void deactivate() override; QDialogButtonBox::StandardButtons getStandardButtons() const override { diff --git a/src/Mod/Part/Gui/Mirroring.cpp b/src/Mod/Part/Gui/Mirroring.cpp index 7476465bbb..47cb363947 100644 --- a/src/Mod/Part/Gui/Mirroring.cpp +++ b/src/Mod/Part/Gui/Mirroring.cpp @@ -421,14 +421,5 @@ bool TaskMirroring::reject() { return widget->reject(); } -void TaskMirroring::activate() -{ - widget->setSelectionGate(); - widget->attachSelection(); -} -void TaskMirroring::deactivate() -{ - widget->detachSelection(); -} #include "moc_Mirroring.cpp" diff --git a/src/Mod/Part/Gui/Mirroring.h b/src/Mod/Part/Gui/Mirroring.h index 402eb43a51..a5a38072e8 100644 --- a/src/Mod/Part/Gui/Mirroring.h +++ b/src/Mod/Part/Gui/Mirroring.h @@ -73,8 +73,6 @@ public: public: bool accept() override; bool reject() override; - void activate() override; - void deactivate() override; QDialogButtonBox::StandardButtons getStandardButtons() const override { diff --git a/src/Mod/Part/Gui/TaskAttacher.cpp b/src/Mod/Part/Gui/TaskAttacher.cpp index bf044c94f9..2a48b7407b 100644 --- a/src/Mod/Part/Gui/TaskAttacher.cpp +++ b/src/Mod/Part/Gui/TaskAttacher.cpp @@ -1554,17 +1554,5 @@ bool TaskDlgAttacher::reject() return true; } -void TaskDlgAttacher::activate() -{ - if (parameter) { - parameter->attachSelection(); - } -} -void TaskDlgAttacher::deactivate() -{ - if (parameter) { - parameter->detachSelection(); - } -} #include "moc_TaskAttacher.cpp" diff --git a/src/Mod/Part/Gui/TaskAttacher.h b/src/Mod/Part/Gui/TaskAttacher.h index 09608ff218..dc6e673eb2 100644 --- a/src/Mod/Part/Gui/TaskAttacher.h +++ b/src/Mod/Part/Gui/TaskAttacher.h @@ -215,9 +215,6 @@ public: /// is called by the framework if the dialog is rejected (Cancel) bool reject() override; - void activate() override; - void deactivate() override; - bool isAllowedAlterDocument() const override { return false; diff --git a/src/Mod/Part/Gui/TaskFaceAppearances.cpp b/src/Mod/Part/Gui/TaskFaceAppearances.cpp index 72e6859c1b..d73e77fc7b 100644 --- a/src/Mod/Part/Gui/TaskFaceAppearances.cpp +++ b/src/Mod/Part/Gui/TaskFaceAppearances.cpp @@ -545,14 +545,5 @@ bool TaskFaceAppearances::reject() { return widget->reject(); } -void TaskFaceAppearances::activate() -{ - widget->setSelectionGate(); - widget->attachSelection(); -} -void TaskFaceAppearances::deactivate() -{ - widget->detachSelection(); -} #include "moc_TaskFaceAppearances.cpp" diff --git a/src/Mod/Part/Gui/TaskFaceAppearances.h b/src/Mod/Part/Gui/TaskFaceAppearances.h index 7e9a1b1a34..2c921f4ab2 100644 --- a/src/Mod/Part/Gui/TaskFaceAppearances.h +++ b/src/Mod/Part/Gui/TaskFaceAppearances.h @@ -90,8 +90,6 @@ public: bool accept() override; bool reject() override; void clicked(int) override; - void activate() override; - void deactivate() override; QDialogButtonBox::StandardButtons getStandardButtons() const override { diff --git a/src/Mod/Part/Gui/TaskShapeBuilder.cpp b/src/Mod/Part/Gui/TaskShapeBuilder.cpp index bfccef4114..7273ca1b06 100644 --- a/src/Mod/Part/Gui/TaskShapeBuilder.cpp +++ b/src/Mod/Part/Gui/TaskShapeBuilder.cpp @@ -644,14 +644,5 @@ bool TaskShapeBuilder::reject() { return widget->reject(); } -void TaskShapeBuilder::activate() -{ - widget->setSelectionGate(); - widget->attachSelection(); -} -void TaskShapeBuilder::deactivate() -{ - widget->detachSelection(); -} #include "moc_TaskShapeBuilder.cpp" diff --git a/src/Mod/Part/Gui/TaskShapeBuilder.h b/src/Mod/Part/Gui/TaskShapeBuilder.h index 8ceab390cf..b1fc60e08c 100644 --- a/src/Mod/Part/Gui/TaskShapeBuilder.h +++ b/src/Mod/Part/Gui/TaskShapeBuilder.h @@ -79,8 +79,6 @@ public: bool accept() override; bool reject() override; void clicked(int) override; - void activate() override; - void deactivate() override; QDialogButtonBox::StandardButtons getStandardButtons() const override { diff --git a/src/Mod/PartDesign/Gui/TaskBooleanParameters.cpp b/src/Mod/PartDesign/Gui/TaskBooleanParameters.cpp index d2bbd86654..e2ce0900fe 100644 --- a/src/Mod/PartDesign/Gui/TaskBooleanParameters.cpp +++ b/src/Mod/PartDesign/Gui/TaskBooleanParameters.cpp @@ -432,14 +432,5 @@ bool TaskDlgBooleanParameters::reject() return true; } -void TaskDlgBooleanParameters::activate() -{ - parameter->attachSelection(); -} -void TaskDlgBooleanParameters::deactivate() -{ - parameter->detachSelection(); -} - #include "moc_TaskBooleanParameters.cpp" diff --git a/src/Mod/PartDesign/Gui/TaskBooleanParameters.h b/src/Mod/PartDesign/Gui/TaskBooleanParameters.h index f3c65083fc..87f14ea01e 100644 --- a/src/Mod/PartDesign/Gui/TaskBooleanParameters.h +++ b/src/Mod/PartDesign/Gui/TaskBooleanParameters.h @@ -112,8 +112,6 @@ public: bool accept() override; /// is called by the framework if the dialog is rejected (Cancel) bool reject() override; - void activate() override; - void deactivate() override; bool isAllowedAlterDocument() const override { diff --git a/src/Mod/PartDesign/Gui/TaskDressUpParameters.cpp b/src/Mod/PartDesign/Gui/TaskDressUpParameters.cpp index e4f3178677..a129e5b7df 100644 --- a/src/Mod/PartDesign/Gui/TaskDressUpParameters.cpp +++ b/src/Mod/PartDesign/Gui/TaskDressUpParameters.cpp @@ -513,14 +513,5 @@ bool TaskDlgDressUpParameters::reject() getViewObject()->highlightReferences(false); return TaskDlgFeatureParameters::reject(); } -void TaskDlgDressUpParameters::activate() -{ - parameter->attachSelection(); - parameter->setSelectionGate(); -} -void TaskDlgDressUpParameters::deactivate() -{ - parameter->detachSelection(); -} #include "moc_TaskDressUpParameters.cpp" diff --git a/src/Mod/PartDesign/Gui/TaskDressUpParameters.h b/src/Mod/PartDesign/Gui/TaskDressUpParameters.h index f20ec3d785..b203d4f0c5 100644 --- a/src/Mod/PartDesign/Gui/TaskDressUpParameters.h +++ b/src/Mod/PartDesign/Gui/TaskDressUpParameters.h @@ -139,8 +139,6 @@ public: /// is called by the framework if the dialog is accepted (Ok) bool accept() override; bool reject() override; - void activate() override; - void deactivate() override; protected: TaskDressUpParameters* parameter; diff --git a/src/Mod/PartDesign/Gui/TaskFeatureParameters.cpp b/src/Mod/PartDesign/Gui/TaskFeatureParameters.cpp index 1f1da97189..5c67248544 100644 --- a/src/Mod/PartDesign/Gui/TaskFeatureParameters.cpp +++ b/src/Mod/PartDesign/Gui/TaskFeatureParameters.cpp @@ -285,27 +285,5 @@ bool TaskDlgFeatureParameters::reject() return true; } -void TaskDlgFeatureParameters::activate() -{ - std::vector subwidgets = getDialogContent(); - for (auto it : subwidgets) { - TaskSketchBasedParameters* param = qobject_cast(it); - if (param) { - param->attachSelection(); - } - } -} -void TaskDlgFeatureParameters::deactivate() -{ - // detach the task panel from the selection to avoid to invoke - // eventually onAddSelection when the selection changes - std::vector subwidgets = getDialogContent(); - for (auto it : subwidgets) { - TaskSketchBasedParameters* param = qobject_cast(it); - if (param) { - param->detachSelection(); - } - } -} #include "moc_TaskFeatureParameters.cpp" diff --git a/src/Mod/PartDesign/Gui/TaskFeatureParameters.h b/src/Mod/PartDesign/Gui/TaskFeatureParameters.h index 74d7f24892..3746aec053 100644 --- a/src/Mod/PartDesign/Gui/TaskFeatureParameters.h +++ b/src/Mod/PartDesign/Gui/TaskFeatureParameters.h @@ -156,8 +156,6 @@ public: bool accept() override; /// is called by the framework if the dialog is rejected (Cancel) bool reject() override; - void activate() override; - void deactivate() override; template T* getViewObject() const diff --git a/src/Mod/PartDesign/Gui/TaskFeaturePick.cpp b/src/Mod/PartDesign/Gui/TaskFeaturePick.cpp index 5d91cd6801..286bdf137c 100644 --- a/src/Mod/PartDesign/Gui/TaskFeaturePick.cpp +++ b/src/Mod/PartDesign/Gui/TaskFeaturePick.cpp @@ -677,14 +677,6 @@ bool TaskDlgFeaturePick::reject() accepted = false; return true; } -void TaskDlgFeaturePick::activate() -{ - pick->attachSelection(); -} -void TaskDlgFeaturePick::deactivate() -{ - pick->detachSelection(); -} void TaskDlgFeaturePick::showExternal(bool val) { diff --git a/src/Mod/PartDesign/Gui/TaskFeaturePick.h b/src/Mod/PartDesign/Gui/TaskFeaturePick.h index 96e8f792bd..4ef06e5802 100644 --- a/src/Mod/PartDesign/Gui/TaskFeaturePick.h +++ b/src/Mod/PartDesign/Gui/TaskFeaturePick.h @@ -130,9 +130,6 @@ public: /// is called by the framework if the dialog is rejected (Cancel) bool reject() override; - void activate() override; - void deactivate() override; - bool isAllowedAlterDocument() const override { return false; diff --git a/src/Mod/PartDesign/Gui/TaskShapeBinder.cpp b/src/Mod/PartDesign/Gui/TaskShapeBinder.cpp index db1aa26b9f..dfdd8b2b2f 100644 --- a/src/Mod/PartDesign/Gui/TaskShapeBinder.cpp +++ b/src/Mod/PartDesign/Gui/TaskShapeBinder.cpp @@ -461,13 +461,5 @@ bool TaskDlgShapeBinder::reject() } return true; } -void TaskDlgShapeBinder::activate() -{ - parameter->attachSelection(); -} -void TaskDlgShapeBinder::deactivate() -{ - parameter->detachSelection(); -} #include "moc_TaskShapeBinder.cpp" diff --git a/src/Mod/PartDesign/Gui/TaskShapeBinder.h b/src/Mod/PartDesign/Gui/TaskShapeBinder.h index 61f54f9130..f097e61db7 100644 --- a/src/Mod/PartDesign/Gui/TaskShapeBinder.h +++ b/src/Mod/PartDesign/Gui/TaskShapeBinder.h @@ -112,8 +112,6 @@ public: bool accept() override; /// is called by the framework if the dialog is rejected (Cancel) bool reject() override; - void activate() override; - void deactivate() override; protected: TaskShapeBinder* parameter; diff --git a/src/Mod/PartDesign/Gui/TaskTransformedParameters.cpp b/src/Mod/PartDesign/Gui/TaskTransformedParameters.cpp index a4c10bd78b..3896c9d6df 100644 --- a/src/Mod/PartDesign/Gui/TaskTransformedParameters.cpp +++ b/src/Mod/PartDesign/Gui/TaskTransformedParameters.cpp @@ -634,14 +634,5 @@ bool TaskDlgTransformedParameters::reject() parameter->exitSelectionMode(); return TaskDlgFeatureParameters::reject(); } -void TaskDlgTransformedParameters::activate() -{ - parameter->attachSelection(); -} -void TaskDlgTransformedParameters::deactivate() -{ - parameter->detachSelection(); -} - #include "moc_TaskTransformedParameters.cpp" diff --git a/src/Mod/PartDesign/Gui/TaskTransformedParameters.h b/src/Mod/PartDesign/Gui/TaskTransformedParameters.h index 9be92754f6..8f322224db 100644 --- a/src/Mod/PartDesign/Gui/TaskTransformedParameters.h +++ b/src/Mod/PartDesign/Gui/TaskTransformedParameters.h @@ -236,9 +236,6 @@ public: /// is called by the framework if the dialog is rejected (Cancel) bool reject() override; - void activate() override; - void deactivate() override; - protected: TaskTransformedParameters* parameter = nullptr; TaskTransformedMessages* message = nullptr; diff --git a/src/Mod/Surface/Gui/TaskFilling.cpp b/src/Mod/Surface/Gui/TaskFilling.cpp index 5023770b83..60103ff771 100644 --- a/src/Mod/Surface/Gui/TaskFilling.cpp +++ b/src/Mod/Surface/Gui/TaskFilling.cpp @@ -1031,23 +1031,6 @@ bool TaskFilling::reject() return ok; } -void TaskFilling::activate() -{ - widget1->attachSelection(); - widget1->setSelectionGate(); - - widget2->attachSelection(); - widget2->setSelectionGate(); - - widget3->attachSelection(); - widget3->setSelectionGate(); -} -void TaskFilling::deactivate() -{ - widget1->detachSelection(); - widget2->detachSelection(); - widget3->detachSelection(); -} } // namespace SurfaceGui diff --git a/src/Mod/Surface/Gui/TaskFilling.h b/src/Mod/Surface/Gui/TaskFilling.h index 144095fdfc..87a8ad149f 100644 --- a/src/Mod/Surface/Gui/TaskFilling.h +++ b/src/Mod/Surface/Gui/TaskFilling.h @@ -141,8 +141,6 @@ public: void closed() override; bool accept() override; bool reject() override; - void activate() override; - void deactivate() override; QDialogButtonBox::StandardButtons getStandardButtons() const override { diff --git a/src/Mod/Surface/Gui/TaskGeomFillSurface.cpp b/src/Mod/Surface/Gui/TaskGeomFillSurface.cpp index 715d793532..a550293355 100644 --- a/src/Mod/Surface/Gui/TaskGeomFillSurface.cpp +++ b/src/Mod/Surface/Gui/TaskGeomFillSurface.cpp @@ -687,14 +687,6 @@ bool TaskGeomFillSurface::reject() { return widget->reject(); } -void TaskGeomFillSurface::activate() -{ - widget->attachSelection(); -} -void TaskGeomFillSurface::deactivate() -{ - widget->detachSelection(); -} } // namespace SurfaceGui diff --git a/src/Mod/Surface/Gui/TaskGeomFillSurface.h b/src/Mod/Surface/Gui/TaskGeomFillSurface.h index 4c363b4c93..e2f23daa9d 100644 --- a/src/Mod/Surface/Gui/TaskGeomFillSurface.h +++ b/src/Mod/Surface/Gui/TaskGeomFillSurface.h @@ -129,8 +129,6 @@ public: void open() override; bool accept() override; bool reject() override; - void activate() override; - void deactivate() override; QDialogButtonBox::StandardButtons getStandardButtons() const override { diff --git a/src/Mod/Surface/Gui/TaskSections.cpp b/src/Mod/Surface/Gui/TaskSections.cpp index c27d0bfb2e..5ccf8e609d 100644 --- a/src/Mod/Surface/Gui/TaskSections.cpp +++ b/src/Mod/Surface/Gui/TaskSections.cpp @@ -670,15 +670,6 @@ bool TaskSections::reject() return ok; } -void TaskSections::activate() -{ - widget1->setSelectionGate(); - widget1->attachSelection(); -} -void TaskSections::deactivate() -{ - widget1->detachSelection(); -} } // namespace SurfaceGui diff --git a/src/Mod/Surface/Gui/TaskSections.h b/src/Mod/Surface/Gui/TaskSections.h index 6f22d97d96..3f5d024ab1 100644 --- a/src/Mod/Surface/Gui/TaskSections.h +++ b/src/Mod/Surface/Gui/TaskSections.h @@ -132,8 +132,6 @@ public: void open() override; bool accept() override; bool reject() override; - void activate() override; - void deactivate() override; QDialogButtonBox::StandardButtons getStandardButtons() const override {