From 0ea238f90c70dac926ef085e187610364cbc39bb Mon Sep 17 00:00:00 2001 From: Benjamin Nauck Date: Mon, 9 Mar 2026 21:38:03 +0100 Subject: [PATCH 1/2] Sketcher: Fix dangling command context on double-click text edit Remove the openCommand() call in editDoubleClicked() since EditTextDialog already manages its own command lifecycle. The redundant outer command was never closed when the user cancelled the dialog. --- src/Mod/Sketcher/Gui/ViewProviderSketch.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Mod/Sketcher/Gui/ViewProviderSketch.cpp b/src/Mod/Sketcher/Gui/ViewProviderSketch.cpp index 4978ffc988..774f92bbce 100644 --- a/src/Mod/Sketcher/Gui/ViewProviderSketch.cpp +++ b/src/Mod/Sketcher/Gui/ViewProviderSketch.cpp @@ -1352,7 +1352,6 @@ void ViewProviderSketch::editDoubleClicked() } if (textConstrId != -1) { - Gui::Command::openCommand(QT_TRANSLATE_NOOP("Command", "Modify Text constraint")); EditTextDialog editTextDialog(this, textConstrId); editTextDialog.exec(); setSketchMode(STATUS_NONE); From a06be5de68d47c4d76115c41fda7d08bab2d46d0 Mon Sep 17 00:00:00 2001 From: Benjamin Nauck Date: Mon, 9 Mar 2026 21:39:45 +0100 Subject: [PATCH 2/2] Sketcher: Fix void bounding box fall-through in constraint visualization Add missing break after hiding rectangle points for a void bounding box, preventing fall-through to CornerMin()/CornerMax() which would produce undefined values. --- src/Mod/Sketcher/Gui/EditModeConstraintCoinManager.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Mod/Sketcher/Gui/EditModeConstraintCoinManager.cpp b/src/Mod/Sketcher/Gui/EditModeConstraintCoinManager.cpp index 283a5d617c..675356a6bf 100644 --- a/src/Mod/Sketcher/Gui/EditModeConstraintCoinManager.cpp +++ b/src/Mod/Sketcher/Gui/EditModeConstraintCoinManager.cpp @@ -832,6 +832,7 @@ Restart: points[j].setValue(0.0f, 0.0f, 0.0f); } coords->point.finishEditing(); + break; } // 1. Get the original min/max points and dimensions