* fix: add mock reset fixtures and resolve async iterator mock issues
- Add pytest_runtest_setup and pytest_runtest_teardown hooks to reset
shared module-level mocks between tests
- Add module-specific mock reset fixtures for test_qa_fixer and
test_qa_reviewer to prevent test interference
- Fix async iterator mock for receive_response to properly return
an AsyncIteratorMock instance
- Update test_qa_fixer.py and test_qa_reviewer.py with proper mock
setup for isolated test execution
* docs(agents): add CLAUDE.md documentation for agents module
Documents the agents module architecture including:
- Module components (coder, planner, session, memory_manager, base)
- Single-agent architecture without external parallelism
- Subagent architecture clarification
* Revert "docs(agents): add CLAUDE.md documentation for agents module"
This reverts commit bf1ddd7da08f2f34352d11a5d823da981f1a98bb.
* chore: update gitignore to allow agents/tests/
* fix(tests): resolve mock isolation and path permission issues
- Fix test_tool_concurrency_error_detection by patching where functions
are used (qa.fixer) instead of where they're defined
- Add Path.exists/is_dir/glob mocks to avoid permission errors on
nonexistent directories in test_validation_strategy.py
- Add helper function clean_project_index_files() to reduce code
duplication in prereqs_validator tests
- Add comprehensive tests for spec validation validators
(context, prereqs, spec_document)
- Fix similar mock/path issues in test_qa_reviewer.py,
test_service_orchestrator.py, test_ci_discovery.py,
test_prompt_generator.py, test_security_scanner.py
All 2103 tests now pass.
* fix(tests): remove unused imports and fix double assignment
- Remove unused 'patch' import from validator test files
- Remove unused 'pytest' import where not needed
- Fix double assignment typo in test_error_message_includes_filename
* fix(tests): move agents tests to tests/agents/ directory
- Move test_agent_architecture.py, test_agent_configs.py, and
test_agent_flow.py from apps/backend/agents/tests/ to tests/agents/
- Fix path resolution to work from new location
- Remove gitignore exception for agents/tests/ (no longer needed)
This resolves the issue where tests were not included in the PR
because they were in an untracked location.
* fix(tests): simplify conftest.py mock management
- Remove redundant pytest_runtest_teardown and pytest_runtest_call hooks
(autouse fixtures in test files already handle mock reset)
- Add prompts_pkg.project_context to potentially mocked modules list
- Remove prompts_pkg from test_qa_fixer entry (not used there)
This reduces maintenance burden by having mock reset in one place.
* refactor(tests): consolidate duplicate mock setup into shared helper
- Create tests/qa_test_helpers.py with shared mock infrastructure:
- AsyncIteratorMock and ReceiveResponseMock classes
- setup_qa_mocks(), cleanup_qa_mocks(), reset_qa_mocks() functions
- Mock response creation helpers
- Accessor functions for mock objects
- Refactor test_qa_fixer.py to use shared helpers
- Reduces ~80 lines of duplicated code per test file
- Fixes potential mock binding issues by using accessor functions
This addresses code quality issues identified in PR review:
- Duplicate mock setup between test_qa_fixer.py and test_qa_reviewer.py
- Duplicated _AsyncIteratorMock class across files
* refactor(tests): consolidate test_qa_reviewer.py with shared helpers
- Refactor test_qa_reviewer.py to use shared qa_test_helpers
- Remove ~170 lines of duplicated mock setup and helper functions
- Fix unused imports in test_qa_fixer.py (json, sys, MagicMock, etc.)
- Fix rate limit error detection tests to patch where functions are used
- Consolidate duplicated _create_*_response helper methods to module level
Addresses CodeQL warnings about unused imports and reduces code
duplication between test_qa_fixer.py and test_qa_reviewer.py.
* fix(tests): remove unused Path import from test_qa_reviewer.py
* fix(tests): address all PR review findings
PR Review Fixes:
- Remove unused create_mock_qa_approved_response/rejected_response functions
- Guard against overwriting _original_modules on second setup_qa_mocks() call
- Clear _original_modules in cleanup_qa_mocks() to prevent stale state
- Add prompts_pkg.project_context to test_qa_reviewer preserved_mocks in conftest
- Convert asyncio.run() pattern to native async tests in test_agent_flow.py
- Remove redundant @pytest.mark.asyncio decorators (asyncio_mode=auto)
- Remove unused pytest import from qa_test_helpers.py
- Fix structural duplication by keeping fixtures in test files
Code Quality:
- Removed ~100 lines of duplicated/unused code
- Consistent async test patterns across all QA test files
- Proper mock state management to prevent test pollution
* fix(tests): save original modules individually in setup_qa_mocks
The boolean guard `setup_done` prevented saving original modules on
subsequent calls with different parameters. When setup_qa_mocks was
called first with include_prompts_pkg=False, then with True, the
prompts_pkg modules were never saved to _original_modules. During
cleanup, these unsaved modules were deleted from sys.modules instead
of being restored, causing ModuleNotFoundError in subsequent tests.
Now checks each module individually before mocking, ensuring all
originals are saved across multiple setup calls.
* fix(tests): address all PR review findings including low priority
- Fix path in test_no_subtask_worker_config (parent.parent.parent)
- Add guard to prevent double setup in setup_qa_mocks()
- Don't clear _original_modules in cleanup to fix multi-module cleanup
* fix(tests): address PR review follow-up findings
- Fix module-level mock setup ordering dependency: now tracks
include_prompts_pkg config and allows incremental setup when
test_qa_fixer.py (False) is imported before test_qa_reviewer.py (True)
- Remove unused asyncio import from test_agent_flow.py
- Replace os.chdir() with monkeypatch.chdir() in prereqs validator
tests for safe parallel test execution
---------
Co-authored-by: StillKnotKnown <stillknotknown@users.noreply.github.com>
StillKnotKnown
ed93df698b