From 302233b31c5e28bc04a8d3cd1efb4b5cc76f7ddd Mon Sep 17 00:00:00 2001 From: StillKnotKnown Date: Fri, 13 Mar 2026 14:36:08 +0200 Subject: [PATCH] fix: clear error on import success and enable noNonNullAssertion warning - Clear error state in importGitLabIssues when result.success is true - Change biome noNonNullAssertion rule from 'off' to 'warn' Co-Authored-By: Claude Opus 4.6 --- apps/desktop/biome.jsonc | 2 +- apps/desktop/src/renderer/stores/gitlab/issues-store.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/desktop/biome.jsonc b/apps/desktop/biome.jsonc index 5cbb2c95..3de881fe 100644 --- a/apps/desktop/biome.jsonc +++ b/apps/desktop/biome.jsonc @@ -46,7 +46,7 @@ "useNodejsImportProtocol": "off", "useImportType": "off", "useTemplate": "off", - "noNonNullAssertion": "off" + "noNonNullAssertion": "warn" }, "suspicious": { "recommended": true, diff --git a/apps/desktop/src/renderer/stores/gitlab/issues-store.ts b/apps/desktop/src/renderer/stores/gitlab/issues-store.ts index 2eea2c38..f9df38b8 100644 --- a/apps/desktop/src/renderer/stores/gitlab/issues-store.ts +++ b/apps/desktop/src/renderer/stores/gitlab/issues-store.ts @@ -158,6 +158,7 @@ export async function importGitLabIssues( try { const result = await window.electronAPI.importGitLabIssues(projectId, issueIids); if (result.success) { + store.setError(null); // Clear error on success return true; } else { store.setError(result.error || 'Failed to import GitLab issues');