David Mudrák
edb13e3c2d
Previously, the acknowledgement was required only when installing plugins from the ZIP file. It is valid when installing plugins from the Plugins directory, too. So we display it at the validator page now to make sure it is displayed in both cases. There is no need to require the admin to check the acknowledgement box now. We do not do that anywhere in admin UI (and there are more dangerous operations than installing a plugin). Admins still can deploy plugins manually without this tool anyway. And at the end, they are admins. They should know what they are doing. Simply displaying the acknowledgement message before they click the install button is enough.
111 lines
4.2 KiB
PHP
111 lines
4.2 KiB
PHP
<?php
|
|
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/**
|
|
* @package tool_installaddon
|
|
* @subpackage classes
|
|
* @category form
|
|
* @copyright 2013 David Mudrak <david@moodle.com>
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
|
|
defined('MOODLE_INTERNAL') || die();
|
|
|
|
require_once($CFG->libdir.'/formslib.php');
|
|
|
|
/**
|
|
* Defines a simple form for uploading the add-on ZIP package
|
|
*
|
|
* @copyright 2013 David Mudrak <david@moodle.com>
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
class tool_installaddon_installfromzip_form extends moodleform {
|
|
|
|
/**
|
|
* Defines the form elements
|
|
*/
|
|
public function definition() {
|
|
|
|
$mform = $this->_form;
|
|
$installer = $this->_customdata['installer'];
|
|
|
|
$mform->addElement('header', 'general', get_string('installfromzip', 'tool_installaddon'));
|
|
$mform->addHelpButton('general', 'installfromzip', 'tool_installaddon');
|
|
|
|
$mform->addElement('filepicker', 'zipfile', get_string('installfromzipfile', 'tool_installaddon'),
|
|
null, array('accepted_types' => '.zip'));
|
|
$mform->addHelpButton('zipfile', 'installfromzipfile', 'tool_installaddon');
|
|
$mform->addRule('zipfile', null, 'required', null, 'client');
|
|
|
|
$options = $installer->get_plugin_types_menu();
|
|
$mform->addElement('select', 'plugintype', get_string('installfromziptype', 'tool_installaddon'), $options,
|
|
array('id' => 'tool_installaddon_installfromzip_plugintype'));
|
|
$mform->addHelpButton('plugintype', 'installfromziptype', 'tool_installaddon');
|
|
$mform->setAdvanced('plugintype');
|
|
|
|
$mform->addElement('static', 'permcheck', '',
|
|
html_writer::span(get_string('permcheck', 'tool_installaddon'), '',
|
|
array('id' => 'tool_installaddon_installfromzip_permcheck')));
|
|
$mform->setAdvanced('permcheck');
|
|
|
|
$mform->addElement('text', 'rootdir', get_string('installfromziprootdir', 'tool_installaddon'));
|
|
$mform->addHelpButton('rootdir', 'installfromziprootdir', 'tool_installaddon');
|
|
$mform->setType('rootdir', PARAM_PLUGIN);
|
|
$mform->setAdvanced('rootdir');
|
|
|
|
$this->add_action_buttons(false, get_string('installfromzipsubmit', 'tool_installaddon'));
|
|
}
|
|
|
|
/**
|
|
* Switch the form to a mode that requires manual selection of the plugin type
|
|
*/
|
|
public function require_explicit_plugintype() {
|
|
|
|
$mform = $this->_form;
|
|
|
|
$mform->addRule('plugintype', get_string('required'), 'required', null, 'client');
|
|
$mform->setAdvanced('plugintype', false);
|
|
$mform->setAdvanced('permcheck', false);
|
|
|
|
$typedetectionfailed = $mform->createElement('static', 'typedetectionfailed', '',
|
|
html_writer::span(get_string('typedetectionfailed', 'tool_installaddon'), 'error'));
|
|
$mform->insertElementBefore($typedetectionfailed, 'permcheck');
|
|
}
|
|
|
|
/**
|
|
* Validate the form fields
|
|
*
|
|
* @param array $data
|
|
* @param array $files
|
|
* @return array (string)field name => (string)validation error text
|
|
*/
|
|
public function validation($data, $files) {
|
|
|
|
$installer = $this->_customdata['installer'];
|
|
$errors = parent::validation($data, $files);
|
|
|
|
if (!empty($data['plugintype'])) {
|
|
if (!$installer->is_plugintype_writable($data['plugintype'])) {
|
|
$path = $installer->get_plugintype_root($data['plugintype']);
|
|
$errors['plugintype'] = get_string('permcheckresultno', 'tool_installaddon', array('path' => $path));
|
|
}
|
|
}
|
|
|
|
return $errors;
|
|
}
|
|
}
|