Ferran Recio
34ce0eddc0
This patch prevent dropping an activity with delegated sections inside another delegated section. Without this patch the teacher can create a deadlock drag&droping the subsection inside itself. We won't allow subsections inside subsections so any activity with subsection cannot be dropped inside a subsección.
82 lines
2.9 KiB
PHP
82 lines
2.9 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
namespace core_courseformat;
|
|
|
|
/**
|
|
* Section delaegate tests.
|
|
*
|
|
* @package core_course
|
|
* @copyright 2023 Ferran Recio <ferran@moodle.com>
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
* @covers \core_courseformat\sectiondelegate
|
|
* @coversDefaultClass \core_courseformat\sectiondelegate
|
|
*/
|
|
class sectiondelegate_test extends \advanced_testcase {
|
|
|
|
/**
|
|
* Setup to ensure that fixtures are loaded.
|
|
*/
|
|
public static function setUpBeforeClass(): void {
|
|
global $CFG;
|
|
require_once($CFG->libdir . '/tests/fixtures/sectiondelegatetest.php');
|
|
}
|
|
|
|
/**
|
|
* Test that the instance method returns the correct class.
|
|
* @covers ::instance
|
|
*/
|
|
public function test_instance(): void {
|
|
global $DB;
|
|
$this->resetAfterTest();
|
|
|
|
$course = $this->getDataGenerator()->create_course(['format' => 'topics', 'numsections' => 3]);
|
|
|
|
// Section 2 has an existing delegate class.
|
|
course_update_section(
|
|
$course,
|
|
$DB->get_record('course_sections', ['course' => $course->id, 'section' => 2]),
|
|
[
|
|
'component' => 'test_component',
|
|
'itemid' => 1,
|
|
]
|
|
);
|
|
|
|
// Section 3 has a missing delegate class.
|
|
course_update_section(
|
|
$course,
|
|
$DB->get_record('course_sections', ['course' => $course->id, 'section' => 3]),
|
|
[
|
|
'component' => 'missing_component',
|
|
'itemid' => 1,
|
|
]
|
|
);
|
|
|
|
$modinfo = get_fast_modinfo($course->id);
|
|
$sectioninfos = $modinfo->get_section_info_all();
|
|
|
|
$this->assertNull(sectiondelegate::instance($sectioninfos[1]));
|
|
$this->assertInstanceOf('\test_component\courseformat\sectiondelegate', sectiondelegate::instance($sectioninfos[2]));
|
|
$this->assertNull(sectiondelegate::instance($sectioninfos[3]));
|
|
}
|
|
|
|
public function test_has_delegate_class(): void {
|
|
$this->assertFalse(sectiondelegate::has_delegate_class('missing_component'));
|
|
$this->assertFalse(sectiondelegate::has_delegate_class('mod_label'));
|
|
$this->assertTrue(sectiondelegate::has_delegate_class('test_component'));
|
|
}
|
|
}
|