Paul Holden
f1a800bb7c
When instantiating classes that extend `inplace_editable` we can improve performance by passing persistent instances we already have, rather than re-requesting them. Add test coverage to relevant classes.
102 lines
3.9 KiB
PHP
102 lines
3.9 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace core_reportbuilder\output;
|
|
|
|
use advanced_testcase;
|
|
use core_reportbuilder_generator;
|
|
use core_reportbuilder\report_access_exception;
|
|
use core_user\reportbuilder\datasource\users;
|
|
|
|
/**
|
|
* Unit tests for the column aggregation editable class
|
|
*
|
|
* @package core_reportbuilder
|
|
* @covers \core_reportbuilder\output\column_aggregation_editable
|
|
* @copyright 2022 Paul Holden <paulh@moodle.com>
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
class column_aggregation_editable_test extends advanced_testcase {
|
|
|
|
/**
|
|
* Test update method
|
|
*/
|
|
public function test_update(): void {
|
|
global $PAGE;
|
|
|
|
$this->resetAfterTest();
|
|
$this->setAdminUser();
|
|
|
|
/** @var core_reportbuilder_generator $generator */
|
|
$generator = $this->getDataGenerator()->get_plugin_generator('core_reportbuilder');
|
|
|
|
$report = $generator->create_report(['name' => 'My report', 'source' => users::class]);
|
|
$column = $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:lastname']);
|
|
|
|
$editable = column_aggregation_editable::update($column->get('id'), 'count');
|
|
$result = $editable->export_for_template($PAGE->get_renderer('core'));
|
|
$this->assertEquals('count', $result['value']);
|
|
|
|
// Reload persistent, assert update.
|
|
$this->assertEquals('count', $column->read()->get('aggregation'));
|
|
}
|
|
|
|
/**
|
|
* Test update method for a user without permission to edit reports
|
|
*/
|
|
public function test_update_access_exception(): void {
|
|
$this->resetAfterTest();
|
|
|
|
/** @var core_reportbuilder_generator $generator */
|
|
$generator = $this->getDataGenerator()->get_plugin_generator('core_reportbuilder');
|
|
|
|
$report = $generator->create_report(['name' => 'My report', 'source' => users::class]);
|
|
$column = $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:lastname']);
|
|
|
|
$user = $this->getDataGenerator()->create_user();
|
|
$this->setUser($user);
|
|
|
|
$this->expectException(report_access_exception::class);
|
|
$this->expectExceptionMessage('You cannot edit this report');
|
|
column_aggregation_editable::update($column->get('id'), 'New name');
|
|
}
|
|
|
|
/**
|
|
* Test update method via component callback
|
|
*
|
|
* @covers ::core_reportbuilder_inplace_editable
|
|
*/
|
|
public function test_update_callback(): void {
|
|
$this->resetAfterTest();
|
|
$this->setAdminUser();
|
|
|
|
/** @var core_reportbuilder_generator $generator */
|
|
$generator = $this->getDataGenerator()->get_plugin_generator('core_reportbuilder');
|
|
|
|
$report = $generator->create_report(['name' => 'My report', 'source' => users::class]);
|
|
$column = $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:lastname']);
|
|
|
|
$params = ['columnaggregation', $column->get('id'), 'count'];
|
|
$editable = component_callback('core_reportbuilder', 'inplace_editable', $params);
|
|
$this->assertInstanceOf(column_aggregation_editable::class, $editable);
|
|
|
|
// Reload persistent, assert update.
|
|
$this->assertEquals('count', $column->read()->get('aggregation'));
|
|
}
|
|
}
|