Files
moodle/admin/tool/mfa/tests/tool_mfa_trait.php
T
Stevani Andolo 00db83d1bf MDL-78509 tool_mfa: Fixes based on the report and other issues
In this commit, there are couple of fixes based on the report:
1. Removed legacy polyfill from provider.php
2. Fixed phpunit warning detected by CodeChecker
3. Removed unused files
4. Fixed the PHPunit failures by removing "securityquestions"
   from the data_provider due to it has not been included as one of the factors
5. Added PHPunit test to the factors that can be unittested
6. Removed !important rule from tool_mfa/styles.css
7. Added (int) type to sleep method within sleep_timer method due to a php deprecation
in too_mfa/classes/manager.php
8. Changed last param form bool to string in not_enough_factors() when initiating
a new single_button object in tool_mfa/renderer.php
9. Add explanation text to login page
10. Fixed "Access to an undefined property .." from PHPStan
12. Fixed all the "Variable $.. might not be defined" from PHPStan
13. Fixed the issue from https://github.com/catalyst/moodle-tool_mfa/issues/379
2023-08-29 11:06:44 +08:00

68 lines
2.2 KiB
PHP

<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
namespace tool_mfa;
defined('MOODLE_INTERNAL') || die();
global $CFG;
require_once($CFG->libdir.'/adminlib.php');
require_once(__DIR__ . '/../lib.php');
/**
* Trait for testing this plugin
*
* @package tool_mfa
* @author Mikhail Golenkov <golenkovm@gmail.com>
* @author Peter Burnett <peterburnett@catalyst-au.net>
* @copyright Catalyst IT
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
trait tool_mfa_trait {
/**
* Sets the state of the factor, in particular the weight and whether it is enabled
*
* @param string $factorname
* @param int $enabled
* @param int $weight
*/
public function set_factor_state($factorname, $enabled = 0, $weight = 100) {
$factor = \tool_mfa\plugininfo\factor::get_factor($factorname);
$this->set_factor_config($factor, 'enabled', $enabled);
$this->set_factor_config($factor, 'weight', $weight);
}
/**
* Sets config variable for given factor.
*
* @param object $factor object of the factor class
* @param string $key
* @param mixed $value
*/
public function set_factor_config($factor, $key, $value) {
\tool_mfa\manager::set_factor_config([$key => $value], 'factor_' . $factor->name);
if ($key == 'enabled') {
if ($value == 1) {
\tool_mfa\manager::do_factor_action($factor->name, 'enable');
} else {
\tool_mfa\manager::do_factor_action($factor->name, 'disable');
}
}
}
}