00db83d1bf
In this commit, there are couple of fixes based on the report: 1. Removed legacy polyfill from provider.php 2. Fixed phpunit warning detected by CodeChecker 3. Removed unused files 4. Fixed the PHPunit failures by removing "securityquestions" from the data_provider due to it has not been included as one of the factors 5. Added PHPunit test to the factors that can be unittested 6. Removed !important rule from tool_mfa/styles.css 7. Added (int) type to sleep method within sleep_timer method due to a php deprecation in too_mfa/classes/manager.php 8. Changed last param form bool to string in not_enough_factors() when initiating a new single_button object in tool_mfa/renderer.php 9. Add explanation text to login page 10. Fixed "Access to an undefined property .." from PHPStan 12. Fixed all the "Variable $.. might not be defined" from PHPStan 13. Fixed the issue from https://github.com/catalyst/moodle-tool_mfa/issues/379
106 lines
4.0 KiB
PHP
106 lines
4.0 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/**
|
|
* Page to revoke and disable an email code.
|
|
*
|
|
* @package factor_email
|
|
* @author Peter Burnett <peterburnett@catalyst-au.net>
|
|
* @copyright Catalyst IT
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
// Ignore coding standards for login check, this page does not require login.
|
|
// @codingStandardsIgnoreStart
|
|
require_once(__DIR__ . '../../../../../../config.php');
|
|
$instanceid = required_param('instance', PARAM_INT);
|
|
$pass = optional_param('pass', '0', PARAM_INT);
|
|
$secret = optional_param('secret', 0, PARAM_INT);
|
|
// @codingStandardsIgnoreEnds
|
|
|
|
$context = context_system::instance();
|
|
$PAGE->set_context($context);
|
|
$url = new moodle_url('/admin/tool/mfa/factor/email/email.php',
|
|
['instance' => $instanceid, 'pass' => $pass, 'secret' => $secret]);
|
|
$PAGE->set_url($url);
|
|
$PAGE->set_pagelayout('secure');
|
|
$PAGE->set_title(get_string('unauthemail', 'factor_email'));
|
|
$PAGE->set_cacheable(false);
|
|
$instance = $DB->get_record('tool_mfa', ['id' => $instanceid]);
|
|
$factor = \tool_mfa\plugininfo\factor::get_factor('email');
|
|
|
|
// If pass is set, require login to force $SESSION and user, and pass for that session.
|
|
if (!empty($instance) && $pass != 0 && $secret != 0) {
|
|
require_login();
|
|
if ($factor->get_state() === \tool_mfa\plugininfo\factor::STATE_LOCKED) {
|
|
// Redirect through to auth, this will bounce them to the next factor.
|
|
redirect(new moodle_url('/admin/tool/mfa/auth.php'));
|
|
}
|
|
// Check the code with the same measures on the page entry.
|
|
if ($instance->secret != $secret) {
|
|
\tool_mfa\manager::sleep_timer();
|
|
$factor->increment_lock_counter();
|
|
throw new moodle_exception('error:parameters', 'factor_email');
|
|
}
|
|
$factor = \tool_mfa\plugininfo\factor::get_factor('email');
|
|
$factor->set_state(\tool_mfa\plugininfo\factor::STATE_PASS);
|
|
// If wantsurl is already set in session, go to it.
|
|
if (!empty($SESSION->wantsurl)) {
|
|
redirect($SESSION->wantsurl);
|
|
} else {
|
|
redirect(new moodle_url('/'));
|
|
}
|
|
}
|
|
|
|
$form = new \factor_email\form\email($url);
|
|
|
|
if ($form->is_cancelled()) {
|
|
redirect(new moodle_url('/'));
|
|
} else if ($fromform = $form->get_data()) {
|
|
if (empty($instance)) {
|
|
$message = get_string('error:badcode', 'factor_email');
|
|
} else {
|
|
$user = $DB->get_record('user', ['id' => $instance->userid]);
|
|
|
|
// Stop attacker from using email factor at all, by revoking all email until admin fixes.
|
|
$DB->set_field('tool_mfa', 'revoked', 1, ['userid' => $user->id, 'factor' => 'email']);
|
|
|
|
// Remotely logout all sessions for user.
|
|
$manager = \core\session\manager::kill_user_sessions($instance->userid);
|
|
|
|
// Log event.
|
|
$ip = $instance->createdfromip;
|
|
$useragent = $instance->label;
|
|
$event = \factor_email\event\unauth_email::unauth_email_event($user, $ip, $useragent);
|
|
$event->trigger();
|
|
|
|
// Suspend user account.
|
|
if (get_config('factor_email', 'suspend')) {
|
|
$DB->set_field('user', 'suspended', 1, ['id' => $user->id]);
|
|
}
|
|
|
|
$message = get_string('email:revokesuccess', 'factor_email', fullname($user));
|
|
}
|
|
}
|
|
|
|
echo $OUTPUT->header();
|
|
echo $OUTPUT->heading(get_string('unauthemail', 'factor_email'));
|
|
if (!empty($message)) {
|
|
echo $message;
|
|
} else {
|
|
$form->display();
|
|
}
|
|
echo $OUTPUT->footer();
|