Tim Hunt
e101ec9fd7
Whether the comments on manually graded questions were visible to students should have been controlled by the 'Specific feedback' Review option in the quiz settings. However, the quiz was not setting $displayoptions->manualcomment, so it did not work.
376 lines
16 KiB
PHP
376 lines
16 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/**
|
|
* This file contains tests that walks a question through the manual graded
|
|
* behaviour.
|
|
*
|
|
* @package qbehaviour
|
|
* @subpackage manualgraded
|
|
* @copyright 2009 The Open University
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
|
|
|
|
defined('MOODLE_INTERNAL') || die();
|
|
|
|
global $CFG;
|
|
require_once(dirname(__FILE__) . '/../../../engine/lib.php');
|
|
require_once(dirname(__FILE__) . '/../../../engine/tests/helpers.php');
|
|
|
|
|
|
/**
|
|
* Unit tests for the manual graded behaviour.
|
|
*
|
|
* @copyright 2009 The Open University
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
class qbehaviour_manualgraded_walkthrough_testcase extends qbehaviour_walkthrough_test_base {
|
|
public function test_manual_graded_essay() {
|
|
|
|
// The current text editor depends on the users profile setting - so it needs a valid user.
|
|
$this->setAdminUser();
|
|
|
|
// Create an essay question.
|
|
$essay = test_question_maker::make_an_essay_question();
|
|
$this->start_attempt_at_question($essay, 'deferredfeedback', 10);
|
|
|
|
// Check the right model is being used.
|
|
$this->assertEquals('manualgraded', $this->quba->get_question_attempt(
|
|
$this->slot)->get_behaviour_name());
|
|
|
|
// Check the initial state.
|
|
$this->check_current_state(question_state::$todo);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output($this->get_contains_question_text_expectation($essay),
|
|
$this->get_does_not_contain_feedback_expectation());
|
|
|
|
// Simulate some data submitted by the student.
|
|
$this->process_submission(array('answer' => 'This is my wonderful essay!', 'answerformat' => FORMAT_HTML));
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$complete);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output(
|
|
new question_contains_tag_with_attribute('textarea', 'name',
|
|
$this->quba->get_question_attempt($this->slot)->get_qt_field_name('answer')),
|
|
$this->get_does_not_contain_feedback_expectation());
|
|
|
|
// Process the same data again, check it does not create a new step.
|
|
$numsteps = $this->get_step_count();
|
|
$this->process_submission(array('answer' => 'This is my wonderful essay!', 'answerformat' => FORMAT_HTML));
|
|
$this->check_step_count($numsteps);
|
|
|
|
// Process different data, check it creates a new step.
|
|
$this->process_submission(array('answer' => '', 'answerformat' => FORMAT_HTML));
|
|
$this->check_step_count($numsteps + 1);
|
|
$this->check_current_state(question_state::$todo);
|
|
|
|
// Change back, check it creates a new step.
|
|
$this->process_submission(array('answer' => 'This is my wonderful essay!', 'answerformat' => FORMAT_HTML));
|
|
$this->check_step_count($numsteps + 2);
|
|
|
|
// Finish the attempt.
|
|
$this->quba->finish_all_questions();
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$needsgrading);
|
|
$this->check_current_mark(null);
|
|
$this->assertEquals('This is my wonderful essay!',
|
|
$this->quba->get_response_summary($this->slot));
|
|
|
|
// Process a manual comment.
|
|
$this->manual_grade('Not good enough!', 10, FORMAT_HTML);
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$mangrright);
|
|
$this->check_current_mark(10);
|
|
$this->check_current_output(
|
|
new question_pattern_expectation('/' . preg_quote('Not good enough!', '/') . '/'));
|
|
|
|
// Now change the max mark for the question and regrade.
|
|
$this->quba->regrade_question($this->slot, true, 1);
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$mangrright);
|
|
$this->check_current_mark(1);
|
|
}
|
|
|
|
public function test_manual_graded_essay_not_answered() {
|
|
|
|
// The current text editor depends on the users profile setting - so it needs a valid user.
|
|
$this->setAdminUser();
|
|
|
|
// Create an essay question.
|
|
$essay = test_question_maker::make_an_essay_question();
|
|
$this->start_attempt_at_question($essay, 'deferredfeedback', 10);
|
|
|
|
// Check the right model is being used.
|
|
$this->assertEquals('manualgraded', $this->quba->get_question_attempt(
|
|
$this->slot)->get_behaviour_name());
|
|
|
|
// Check the initial state.
|
|
$this->check_current_state(question_state::$todo);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output($this->get_contains_question_text_expectation($essay),
|
|
$this->get_does_not_contain_feedback_expectation());
|
|
|
|
// Finish the attempt.
|
|
$this->quba->finish_all_questions();
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$gaveup);
|
|
$this->check_current_mark(null);
|
|
$this->assertEquals('',
|
|
$this->quba->get_response_summary($this->slot));
|
|
|
|
// Process a manual comment.
|
|
$this->manual_grade('Not good enough!', 1, FORMAT_HTML);
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$mangrpartial);
|
|
$this->check_current_mark(1);
|
|
$this->check_current_output(
|
|
new question_pattern_expectation('/' . preg_quote('Not good enough!') . '/'));
|
|
|
|
// Now change the max mark for the question and regrade.
|
|
$this->quba->regrade_question($this->slot, true, 1);
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$mangrpartial);
|
|
$this->check_current_mark(0.1);
|
|
}
|
|
|
|
public function test_manual_graded_truefalse() {
|
|
|
|
// Create a true-false question with correct answer true.
|
|
$tf = test_question_maker::make_question('truefalse', 'true');
|
|
$this->start_attempt_at_question($tf, 'manualgraded', 2);
|
|
|
|
// Check the initial state.
|
|
$this->check_current_state(question_state::$todo);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output(
|
|
$this->get_contains_question_text_expectation($tf),
|
|
$this->get_does_not_contain_feedback_expectation());
|
|
|
|
// Process a true answer and check the expected result.
|
|
$this->process_submission(array('answer' => 1));
|
|
|
|
$this->check_current_state(question_state::$complete);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output(
|
|
$this->get_contains_tf_true_radio_expectation(true, true),
|
|
$this->get_does_not_contain_correctness_expectation(),
|
|
$this->get_does_not_contain_feedback_expectation());
|
|
|
|
// Finish the attempt.
|
|
$this->quba->finish_all_questions();
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$needsgrading);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output(
|
|
$this->get_does_not_contain_correctness_expectation(),
|
|
$this->get_does_not_contain_specific_feedback_expectation());
|
|
|
|
// Process a manual comment.
|
|
$this->manual_grade('Not good enough!', 1, FORMAT_HTML);
|
|
|
|
$this->check_current_state(question_state::$mangrpartial);
|
|
$this->check_current_mark(1);
|
|
$this->check_current_output(
|
|
$this->get_does_not_contain_correctness_expectation(),
|
|
$this->get_does_not_contain_specific_feedback_expectation(),
|
|
new question_pattern_expectation('/' . preg_quote('Not good enough!', '/') . '/'));
|
|
}
|
|
|
|
public function test_manual_graded_ignore_repeat_sumbission() {
|
|
// Create an essay question.
|
|
$essay = test_question_maker::make_an_essay_question();
|
|
$this->start_attempt_at_question($essay, 'deferredfeedback', 10);
|
|
|
|
// Check the right model is being used.
|
|
$this->assertEquals('manualgraded', $this->quba->get_question_attempt(
|
|
$this->slot)->get_behaviour_name());
|
|
|
|
// Check the initial state.
|
|
$this->check_current_state(question_state::$todo);
|
|
$this->check_current_mark(null);
|
|
|
|
// Simulate some data submitted by the student.
|
|
$this->process_submission(array('answer' => 'This is my wonderful essay!', 'answerformat' => FORMAT_HTML));
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$complete);
|
|
$this->check_current_mark(null);
|
|
|
|
// Finish the attempt.
|
|
$this->quba->finish_all_questions();
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$needsgrading);
|
|
$this->check_current_mark(null);
|
|
$this->assertEquals('This is my wonderful essay!',
|
|
$this->quba->get_response_summary($this->slot));
|
|
|
|
// Process a blank manual comment. Ensure it does not change the state.
|
|
$numsteps = $this->get_step_count();
|
|
$this->manual_grade('', '', FORMAT_HTML);
|
|
$this->check_step_count($numsteps);
|
|
$this->check_current_state(question_state::$needsgrading);
|
|
$this->check_current_mark(null);
|
|
|
|
// Process a comment, but with the mark blank. Should be recorded, but
|
|
// not change the mark.
|
|
$this->manual_grade('I am not sure what grade to award.', '', FORMAT_HTML);
|
|
$this->check_step_count($numsteps + 1);
|
|
$this->check_current_state(question_state::$needsgrading);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output(
|
|
new question_pattern_expectation('/' .
|
|
preg_quote('I am not sure what grade to award.', '/') . '/'));
|
|
|
|
// Now grade it.
|
|
$this->manual_grade('Pretty good!', '9.00000', FORMAT_HTML);
|
|
$this->check_step_count($numsteps + 2);
|
|
$this->check_current_state(question_state::$mangrpartial);
|
|
$this->check_current_mark(9);
|
|
$this->check_current_output(
|
|
new question_pattern_expectation('/' . preg_quote('Pretty good!', '/') . '/'));
|
|
|
|
// Process the same data again, and make sure it does not add a step.
|
|
$this->manual_grade('Pretty good!', '9.00000', FORMAT_HTML);
|
|
$this->check_step_count($numsteps + 2);
|
|
$this->check_current_state(question_state::$mangrpartial);
|
|
$this->check_current_mark(9);
|
|
|
|
// Now set the mark back to blank.
|
|
$this->manual_grade('Actually, I am not sure any more.', '', FORMAT_HTML);
|
|
$this->check_step_count($numsteps + 3);
|
|
$this->check_current_state(question_state::$needsgrading);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output(
|
|
new question_pattern_expectation('/' .
|
|
preg_quote('Actually, I am not sure any more.', '/') . '/'));
|
|
|
|
$qa = $this->quba->get_question_attempt($this->slot);
|
|
$this->assertEquals('Commented: Actually, I am not sure any more.',
|
|
$qa->summarise_action($qa->get_last_step()));
|
|
}
|
|
|
|
public function test_manual_graded_essay_can_grade_0() {
|
|
|
|
// The current text editor depends on the users profile setting - so it needs a valid user.
|
|
$this->setAdminUser();
|
|
|
|
// Create an essay question.
|
|
$essay = test_question_maker::make_an_essay_question();
|
|
$this->start_attempt_at_question($essay, 'deferredfeedback', 10);
|
|
|
|
// Check the right model is being used.
|
|
$this->assertEquals('manualgraded', $this->quba->get_question_attempt(
|
|
$this->slot)->get_behaviour_name());
|
|
|
|
// Check the initial state.
|
|
$this->check_current_state(question_state::$todo);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output($this->get_contains_question_text_expectation($essay),
|
|
$this->get_does_not_contain_feedback_expectation());
|
|
|
|
// Simulate some data submitted by the student.
|
|
$this->process_submission(array('answer' => 'This is my wonderful essay!', 'answerformat' => FORMAT_HTML));
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$complete);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output(
|
|
new question_contains_tag_with_attribute('textarea', 'name',
|
|
$this->quba->get_question_attempt($this->slot)->get_qt_field_name('answer')),
|
|
$this->get_does_not_contain_feedback_expectation());
|
|
|
|
// Finish the attempt.
|
|
$this->quba->finish_all_questions();
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$needsgrading);
|
|
$this->check_current_mark(null);
|
|
$this->assertEquals('This is my wonderful essay!',
|
|
$this->quba->get_response_summary($this->slot));
|
|
|
|
// Process a blank comment and a grade of 0.
|
|
$this->manual_grade('', 0, FORMAT_HTML);
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$mangrwrong);
|
|
$this->check_current_mark(0);
|
|
}
|
|
|
|
public function test_manual_graded_respects_display_options() {
|
|
// This test is for MDL-43874. Manual comments were not respecting the
|
|
// Display options for feedback.
|
|
|
|
// The current text editor depends on the users profile setting - so it needs a valid user.
|
|
$this->setAdminUser();
|
|
|
|
// Create an essay question.
|
|
$essay = test_question_maker::make_an_essay_question();
|
|
$this->start_attempt_at_question($essay, 'deferredfeedback', 10);
|
|
|
|
// Check the right model is being used.
|
|
$this->assertEquals('manualgraded', $this->quba->get_question_attempt(
|
|
$this->slot)->get_behaviour_name());
|
|
|
|
// Check the initial state.
|
|
$this->check_current_state(question_state::$todo);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output($this->get_contains_question_text_expectation($essay),
|
|
$this->get_does_not_contain_feedback_expectation());
|
|
|
|
// Simulate some data submitted by the student.
|
|
$this->process_submission(array('answer' => 'This is my wonderful essay!', 'answerformat' => FORMAT_HTML));
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$complete);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output(
|
|
new question_contains_tag_with_attribute('textarea', 'name',
|
|
$this->quba->get_question_attempt($this->slot)->get_qt_field_name('answer')),
|
|
$this->get_does_not_contain_feedback_expectation());
|
|
|
|
// Finish the attempt.
|
|
$this->quba->finish_all_questions();
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$needsgrading);
|
|
$this->check_current_mark(null);
|
|
$this->assertEquals('This is my wonderful essay!',
|
|
$this->quba->get_response_summary($this->slot));
|
|
|
|
// Process a comment and a grade.
|
|
$this->manual_grade('This should only appear if the displya options allow it', 5, FORMAT_HTML);
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$mangrpartial);
|
|
$this->check_current_mark(5);
|
|
|
|
$this->displayoptions->manualcomment = question_display_options::HIDDEN;
|
|
$this->check_output_does_not_contain('This should only appear if the displya options allow it');
|
|
$this->displayoptions->manualcomment = question_display_options::VISIBLE;
|
|
$this->check_output_contains('This should only appear if the displya options allow it');
|
|
}
|
|
}
|