Tim Hunt
53b8e25626
Comment format (FORMAT_...) was correctly being processed when the manual grading happened as the result of a form submission. It was only when done using the question_usage or question_attempt API method that there was no way to specify the format. (Although I think the only place this API as used was in the unit tests.) Note that question_attempt::manual_grade API had to change, but I don't think that is a real API change. Calling code should be using question_usage::question_attempt, which is backwards compatible. Note that now, if you don't pass format, then no error is generated, but a developer debugging message is generated.
89 lines
3.6 KiB
PHP
89 lines
3.6 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/**
|
|
* This file contains tests that walks a question through the information item
|
|
* behaviour.
|
|
*
|
|
* @package qbehaviour
|
|
* @subpackage informationitem
|
|
* @copyright 2009 The Open University
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
|
|
|
|
defined('MOODLE_INTERNAL') || die();
|
|
|
|
global $CFG;
|
|
require_once(dirname(__FILE__) . '/../../../engine/lib.php');
|
|
require_once(dirname(__FILE__) . '/../../../engine/tests/helpers.php');
|
|
|
|
|
|
/**
|
|
* Unit tests for the information item behaviour.
|
|
*
|
|
* @copyright 2009 The Open University
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
class qbehaviour_informationitem_walkthrough_test extends qbehaviour_walkthrough_test_base {
|
|
public function test_informationitem_feedback_description() {
|
|
|
|
// Create a true-false question with correct answer true.
|
|
$description = test_question_maker::make_question('description');
|
|
$this->start_attempt_at_question($description, 'deferredfeedback');
|
|
|
|
// Check the initial state.
|
|
$this->check_current_state(question_state::$todo);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output($this->get_contains_question_text_expectation($description),
|
|
new question_contains_tag_with_attributes('input', array('type' => 'hidden',
|
|
'name' => $this->quba->get_field_prefix($this->slot) . '-seen', 'value' => 1)),
|
|
$this->get_does_not_contain_feedback_expectation());
|
|
|
|
// Process a submission indicating this question has been seen.
|
|
$this->process_submission(array('-seen' => 1));
|
|
|
|
$this->check_current_state(question_state::$complete);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output($this->get_does_not_contain_correctness_expectation(),
|
|
new question_no_pattern_expectation(
|
|
'/type=\"hidden\"[^>]*name=\"[^"]*seen\"|name=\"[^"]*seen\"[^>]*type=\"hidden\"/'),
|
|
$this->get_does_not_contain_feedback_expectation());
|
|
|
|
// Finish the attempt.
|
|
$this->quba->finish_all_questions();
|
|
|
|
// Verify.
|
|
$this->check_current_state(question_state::$finished);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output(
|
|
$this->get_contains_question_text_expectation($description),
|
|
$this->get_contains_general_feedback_expectation($description));
|
|
|
|
// Process a manual comment.
|
|
$this->manual_grade('Not good enough!', null, FORMAT_HTML);
|
|
|
|
$this->check_current_state(question_state::$manfinished);
|
|
$this->check_current_mark(null);
|
|
$this->check_current_output(
|
|
new question_pattern_expectation('/' . preg_quote('Not good enough!', '/') . '/'));
|
|
|
|
// Check that trying to process a manual comment with a grade causes an exception.
|
|
$this->setExpectedException('moodle_exception');
|
|
$this->manual_grade('Not good enough!', 1, FORMAT_HTML);
|
|
}
|
|
}
|