c9c4d0b24e
Previously, the testable validator's get_plugintype_location() used to return path to a directory that itself did not need to be writable. This was causing false failures. This patch reimplements the testable validator's get_plugintype_location() method so that it returns a path inside $CFG->tempdir which is always writable. Also, to make all test methods consistent, all of them now use the testable_tool_installaddon_validator class. Before this patch, some test methods used the testable class and some used the parent class.