Tim Hunt
94815ccfa0
The problem was mostly that, in the past, we did not worry if question_attempt_step.id changed during regrade (because we deleted the old step row and inserted a new one). However, now that steps can have associated files, we can't be that slack, becuase the step id is used as the file itemid. So, now, we have to update the existing rows during a regrade. We do this by having the question engine tell the question_engine_unit_of_work that the step has first been deleted, and then added back. Then we make the unit-of-work spot that delete + add = update. This also means that during regrading, we have to pass around some extra ids so that new steps know the id of the step they are replacing. Naturally, this requires some quite trickly logic, so I finally got around to writing unit tests for question_engine_unit_of_work, which is a good thing. Along the way I also got around to renaming question_attempt->set_number_in_usage, which got missed out when everthing else was renamed to slot ages ago. Finally, while working on this code, I noticed and fixed some PHPdoc comments.
363 lines
15 KiB
PHP
363 lines
15 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/**
|
|
* This file contains tests for the question_attempt class.
|
|
*
|
|
* Action methods like start, process_action and finish are assumed to be
|
|
* tested by walkthrough tests in the various behaviours.
|
|
*
|
|
* @package moodlecore
|
|
* @subpackage questionengine
|
|
* @copyright 2009 The Open University
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
|
|
|
|
defined('MOODLE_INTERNAL') || die();
|
|
|
|
require_once(dirname(__FILE__) . '/../lib.php');
|
|
require_once(dirname(__FILE__) . '/helpers.php');
|
|
|
|
|
|
/**
|
|
* Unit tests for the {@link question_attempt} class.
|
|
*
|
|
* These are the tests that don't require any steps.
|
|
*
|
|
* @copyright 2009 The Open University
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
class question_attempt_test extends UnitTestCase {
|
|
private $question;
|
|
private $usageid;
|
|
private $qa;
|
|
|
|
public function setUp() {
|
|
$this->question = test_question_maker::make_question('description');
|
|
$this->question->defaultmark = 3;
|
|
$this->usageid = 13;
|
|
$this->qa = new question_attempt($this->question, $this->usageid);
|
|
}
|
|
|
|
public function tearDown() {
|
|
$this->question = null;
|
|
$this->useageid = null;
|
|
$this->qa = null;
|
|
}
|
|
|
|
public function test_constructor_sets_maxmark() {
|
|
$qa = new question_attempt($this->question, $this->usageid);
|
|
$this->assertIdentical($this->question, $qa->get_question());
|
|
$this->assertEqual(3, $qa->get_max_mark());
|
|
}
|
|
|
|
public function test_maxmark_beats_default_mark() {
|
|
$qa = new question_attempt($this->question, $this->usageid, null, 2);
|
|
$this->assertEqual(2, $qa->get_max_mark());
|
|
}
|
|
|
|
public function test_get_set_slot() {
|
|
$this->qa->set_slot(7);
|
|
$this->assertEqual(7, $this->qa->get_slot());
|
|
}
|
|
|
|
public function test_fagged_initially_false() {
|
|
$this->assertEqual(false, $this->qa->is_flagged());
|
|
}
|
|
|
|
public function test_set_is_flagged() {
|
|
$this->qa->set_flagged(true);
|
|
$this->assertEqual(true, $this->qa->is_flagged());
|
|
}
|
|
|
|
public function test_get_qt_field_name() {
|
|
$name = $this->qa->get_qt_field_name('test');
|
|
$this->assertPattern('/^' . preg_quote($this->qa->get_field_prefix()) . '/', $name);
|
|
$this->assertPattern('/_test$/', $name);
|
|
}
|
|
|
|
public function test_get_behaviour_field_name() {
|
|
$name = $this->qa->get_behaviour_field_name('test');
|
|
$this->assertPattern('/^' . preg_quote($this->qa->get_field_prefix()) . '/', $name);
|
|
$this->assertPattern('/_-test$/', $name);
|
|
}
|
|
|
|
public function test_get_field_prefix() {
|
|
$this->qa->set_slot(7);
|
|
$name = $this->qa->get_field_prefix();
|
|
$this->assertPattern('/' . preg_quote($this->usageid) . '/', $name);
|
|
$this->assertPattern('/' . preg_quote($this->qa->get_slot()) . '/', $name);
|
|
}
|
|
|
|
public function test_get_submitted_var_not_present_var_returns_null() {
|
|
$this->assertNull($this->qa->get_submitted_var(
|
|
'reallyunlikelyvariablename', PARAM_BOOL));
|
|
}
|
|
|
|
public function test_get_submitted_var_param_mark_not_present() {
|
|
$this->assertNull($this->qa->get_submitted_var(
|
|
'name', question_attempt::PARAM_MARK, array()));
|
|
}
|
|
|
|
public function test_get_submitted_var_param_mark_blank() {
|
|
$this->assertIdentical('', $this->qa->get_submitted_var(
|
|
'name', question_attempt::PARAM_MARK, array('name' => '')));
|
|
}
|
|
|
|
public function test_get_submitted_var_param_mark_number() {
|
|
$this->assertIdentical(123.0, $this->qa->get_submitted_var(
|
|
'name', question_attempt::PARAM_MARK, array('name' => '123')));
|
|
}
|
|
|
|
public function test_get_submitted_var_param_mark_invalid() {
|
|
$this->assertIdentical(0.0, $this->qa->get_submitted_var(
|
|
'name', question_attempt::PARAM_MARK, array('name' => 'frog')));
|
|
}
|
|
}
|
|
|
|
|
|
/**
|
|
* These tests use a standard fixture of a {@link question_attempt} with three steps.
|
|
*
|
|
* @copyright 2009 The Open University
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
class question_attempt_with_steps_test extends UnitTestCase {
|
|
private $question;
|
|
private $qa;
|
|
|
|
public function setUp() {
|
|
$this->question = test_question_maker::make_question('description');
|
|
$this->qa = new testable_question_attempt($this->question, 0, null, 2);
|
|
for ($i = 0; $i < 3; $i++) {
|
|
$step = new question_attempt_step(array('i' => $i));
|
|
$this->qa->add_step($step);
|
|
}
|
|
}
|
|
|
|
public function tearDown() {
|
|
$this->qa = null;
|
|
}
|
|
|
|
public function test_get_step_before_start() {
|
|
$this->expectException();
|
|
$step = $this->qa->get_step(-1);
|
|
}
|
|
|
|
public function test_get_step_at_start() {
|
|
$step = $this->qa->get_step(0);
|
|
$this->assertEqual(0, $step->get_qt_var('i'));
|
|
}
|
|
|
|
public function test_get_step_at_end() {
|
|
$step = $this->qa->get_step(2);
|
|
$this->assertEqual(2, $step->get_qt_var('i'));
|
|
}
|
|
|
|
public function test_get_step_past_end() {
|
|
$this->expectException();
|
|
$step = $this->qa->get_step(3);
|
|
}
|
|
|
|
public function test_get_num_steps() {
|
|
$this->assertEqual(3, $this->qa->get_num_steps());
|
|
}
|
|
|
|
public function test_get_last_step() {
|
|
$step = $this->qa->get_last_step();
|
|
$this->assertEqual(2, $step->get_qt_var('i'));
|
|
}
|
|
|
|
public function test_get_last_qt_var_there1() {
|
|
$this->assertEqual(2, $this->qa->get_last_qt_var('i'));
|
|
}
|
|
|
|
public function test_get_last_qt_var_there2() {
|
|
$this->qa->get_step(0)->set_qt_var('_x', 'a value');
|
|
$this->assertEqual('a value', $this->qa->get_last_qt_var('_x'));
|
|
}
|
|
|
|
public function test_get_last_qt_var_missing() {
|
|
$this->assertNull($this->qa->get_last_qt_var('notthere'));
|
|
}
|
|
|
|
public function test_get_last_qt_var_missing_default() {
|
|
$this->assertEqual('default', $this->qa->get_last_qt_var('notthere', 'default'));
|
|
}
|
|
|
|
public function test_get_last_behaviour_var_missing() {
|
|
$this->assertNull($this->qa->get_last_qt_var('notthere'));
|
|
}
|
|
|
|
public function test_get_last_behaviour_var_there() {
|
|
$this->qa->get_step(1)->set_behaviour_var('_x', 'a value');
|
|
$this->assertEqual('a value', '' . $this->qa->get_last_behaviour_var('_x'));
|
|
}
|
|
|
|
public function test_get_state_gets_state_of_last() {
|
|
$this->qa->get_step(2)->set_state(question_state::$gradedright);
|
|
$this->qa->get_step(1)->set_state(question_state::$gradedwrong);
|
|
$this->assertEqual(question_state::$gradedright, $this->qa->get_state());
|
|
}
|
|
|
|
public function test_get_mark_gets_mark_of_last() {
|
|
$this->assertEqual(2, $this->qa->get_max_mark());
|
|
$this->qa->get_step(2)->set_fraction(0.5);
|
|
$this->qa->get_step(1)->set_fraction(0.1);
|
|
$this->assertEqual(1, $this->qa->get_mark());
|
|
}
|
|
|
|
public function test_get_fraction_gets_fraction_of_last() {
|
|
$this->qa->get_step(2)->set_fraction(0.5);
|
|
$this->qa->get_step(1)->set_fraction(0.1);
|
|
$this->assertEqual(0.5, $this->qa->get_fraction());
|
|
}
|
|
|
|
public function test_get_fraction_returns_null_if_none() {
|
|
$this->assertNull($this->qa->get_fraction());
|
|
}
|
|
|
|
public function test_format_mark() {
|
|
$this->qa->get_step(2)->set_fraction(0.5);
|
|
$this->assertEqual('1.00', $this->qa->format_mark(2));
|
|
}
|
|
|
|
public function test_format_max_mark() {
|
|
$this->assertEqual('2.0000000', $this->qa->format_max_mark(7));
|
|
}
|
|
|
|
public function test_get_min_fraction() {
|
|
$this->qa->set_min_fraction(-1);
|
|
$this->assertEqual(-1, $this->qa->get_min_fraction(0));
|
|
}
|
|
|
|
public function test_cannot_get_min_fraction_before_start() {
|
|
$qa = new question_attempt($this->question, 0);
|
|
$this->expectException();
|
|
$qa->get_min_fraction();
|
|
}
|
|
}
|
|
|
|
|
|
/**
|
|
* Unit tests for loading data into the {@link question_attempt} class.
|
|
*
|
|
* @copyright 2009 The Open University
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
class question_attempt_db_test extends data_loading_method_test_base {
|
|
public function test_load() {
|
|
$records = new test_recordset(array(
|
|
array('questionattemptid', 'contextid', 'questionusageid', 'slot',
|
|
'behaviour', 'questionid', 'variant', 'maxmark', 'minfraction', 'flagged',
|
|
'questionsummary', 'rightanswer', 'responsesummary', 'timemodified',
|
|
'attemptstepid', 'sequencenumber', 'state', 'fraction',
|
|
'timecreated', 'userid', 'name', 'value'),
|
|
array(1, 123, 1, 1, 'deferredfeedback', -1, 1, 2.0000000, 0.0000000, 0, '', '', '', 1256233790, 1, 0, 'todo', null, 1256233700, 1, null, null),
|
|
array(1, 123, 1, 1, 'deferredfeedback', -1, 1, 2.0000000, 0.0000000, 0, '', '', '', 1256233790, 2, 1, 'complete', null, 1256233705, 1, 'answer', '1'),
|
|
array(1, 123, 1, 1, 'deferredfeedback', -1, 1, 2.0000000, 0.0000000, 1, '', '', '', 1256233790, 3, 2, 'complete', null, 1256233710, 1, 'answer', '0'),
|
|
array(1, 123, 1, 1, 'deferredfeedback', -1, 1, 2.0000000, 0.0000000, 0, '', '', '', 1256233790, 4, 3, 'complete', null, 1256233715, 1, 'answer', '1'),
|
|
array(1, 123, 1, 1, 'deferredfeedback', -1, 1, 2.0000000, 0.0000000, 0, '', '', '', 1256233790, 5, 4, 'gradedright', 1.0000000, 1256233720, 1, '-finish', '1'),
|
|
array(1, 123, 1, 1, 'deferredfeedback', -1, 1, 2.0000000, 0.0000000, 0, '', '', '', 1256233790, 6, 5, 'mangrpartial', 0.5000000, 1256233790, 1, '-comment', 'Not good enough!'),
|
|
array(1, 123, 1, 1, 'deferredfeedback', -1, 1, 2.0000000, 0.0000000, 0, '', '', '', 1256233790, 6, 5, 'mangrpartial', 0.5000000, 1256233790, 1, '-mark', '1'),
|
|
array(1, 123, 1, 1, 'deferredfeedback', -1, 1, 2.0000000, 0.0000000, 0, '', '', '', 1256233790, 6, 5, 'mangrpartial', 0.5000000, 1256233790, 1, '-maxmark', '2'),
|
|
));
|
|
|
|
$question = test_question_maker::make_question('truefalse', 'true');
|
|
$question->id = -1;
|
|
|
|
question_bank::start_unit_test();
|
|
question_bank::load_test_question_data($question);
|
|
$qa = question_attempt::load_from_records($records, 1, new question_usage_null_observer(), 'deferredfeedback');
|
|
question_bank::end_unit_test();
|
|
|
|
$this->assertEqual($question->questiontext, $qa->get_question()->questiontext);
|
|
|
|
$this->assertEqual(6, $qa->get_num_steps());
|
|
|
|
$step = $qa->get_step(0);
|
|
$this->assertEqual(question_state::$todo, $step->get_state());
|
|
$this->assertNull($step->get_fraction());
|
|
$this->assertEqual(1256233700, $step->get_timecreated());
|
|
$this->assertEqual(1, $step->get_user_id());
|
|
$this->assertEqual(array(), $step->get_all_data());
|
|
|
|
$step = $qa->get_step(1);
|
|
$this->assertEqual(question_state::$complete, $step->get_state());
|
|
$this->assertNull($step->get_fraction());
|
|
$this->assertEqual(1256233705, $step->get_timecreated());
|
|
$this->assertEqual(1, $step->get_user_id());
|
|
$this->assertEqual(array('answer' => '1'), $step->get_all_data());
|
|
|
|
$step = $qa->get_step(2);
|
|
$this->assertEqual(question_state::$complete, $step->get_state());
|
|
$this->assertNull($step->get_fraction());
|
|
$this->assertEqual(1256233710, $step->get_timecreated());
|
|
$this->assertEqual(1, $step->get_user_id());
|
|
$this->assertEqual(array('answer' => '0'), $step->get_all_data());
|
|
|
|
$step = $qa->get_step(3);
|
|
$this->assertEqual(question_state::$complete, $step->get_state());
|
|
$this->assertNull($step->get_fraction());
|
|
$this->assertEqual(1256233715, $step->get_timecreated());
|
|
$this->assertEqual(1, $step->get_user_id());
|
|
$this->assertEqual(array('answer' => '1'), $step->get_all_data());
|
|
|
|
$step = $qa->get_step(4);
|
|
$this->assertEqual(question_state::$gradedright, $step->get_state());
|
|
$this->assertEqual(1, $step->get_fraction());
|
|
$this->assertEqual(1256233720, $step->get_timecreated());
|
|
$this->assertEqual(1, $step->get_user_id());
|
|
$this->assertEqual(array('-finish' => '1'), $step->get_all_data());
|
|
|
|
$step = $qa->get_step(5);
|
|
$this->assertEqual(question_state::$mangrpartial, $step->get_state());
|
|
$this->assertEqual(0.5, $step->get_fraction());
|
|
$this->assertEqual(1256233790, $step->get_timecreated());
|
|
$this->assertEqual(1, $step->get_user_id());
|
|
$this->assertEqual(array('-comment' => 'Not good enough!', '-mark' => '1', '-maxmark' => '2'),
|
|
$step->get_all_data());
|
|
}
|
|
|
|
public function test_load_missing_question() {
|
|
$records = new test_recordset(array(
|
|
array('questionattemptid', 'contextid', 'questionusageid', 'slot',
|
|
'behaviour', 'questionid', 'variant', 'maxmark', 'minfraction', 'flagged',
|
|
'questionsummary', 'rightanswer', 'responsesummary', 'timemodified',
|
|
'attemptstepid', 'sequencenumber', 'state', 'fraction',
|
|
'timecreated', 'userid', 'name', 'value'),
|
|
array(1, 123, 1, 1, 'deferredfeedback', -1, 1, 2.0000000, 0.0000000, 0, '', '', '', 1256233790, 1, 0, 'todo', null, 1256233700, 1, null, null),
|
|
));
|
|
|
|
question_bank::start_unit_test();
|
|
$qa = question_attempt::load_from_records($records, 1, new question_usage_null_observer(), 'deferredfeedback');
|
|
question_bank::end_unit_test();
|
|
|
|
$missingq = question_bank::get_qtype('missingtype')->make_deleted_instance(-1, 2);
|
|
$this->assertEqual($missingq, $qa->get_question());
|
|
|
|
$this->assertEqual(1, $qa->get_num_steps());
|
|
|
|
$step = $qa->get_step(0);
|
|
$this->assertEqual(question_state::$todo, $step->get_state());
|
|
$this->assertNull($step->get_fraction());
|
|
$this->assertEqual(1256233700, $step->get_timecreated());
|
|
$this->assertEqual(1, $step->get_user_id());
|
|
$this->assertEqual(array(), $step->get_all_data());
|
|
}
|
|
}
|