Eloy Lafuente (stronk7)
4f7631113c
This commit includes more changes, all them also adding the :void return type to unit tests missing them. The difference is that all these changes, while also detected perfectly by the moodle.PHPUnit.TestReturnType sniff, were not auto-fixed (like the previous commit ones), because all them do include some "return" statement and, for safety, we don't fix them. All the cases have been visually inspected and confirmed that the existing "return" statements always belong to anon functions within the test body and not the test own return statement.
90 lines
3.1 KiB
PHP
90 lines
3.1 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
namespace tool_dataprivacy;
|
|
|
|
use data_privacy_testcase;
|
|
|
|
defined('MOODLE_INTERNAL') || die();
|
|
require_once('data_privacy_testcase.php');
|
|
|
|
/**
|
|
* Tests for the manager observer.
|
|
*
|
|
* @package tool_dataprivacy
|
|
* @copyright 2018 Andrew Nicols <andrew@nicols.co.uk>
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
class manager_observer_test extends data_privacy_testcase {
|
|
/**
|
|
* Ensure that when users are configured as DPO, they are sent an message upon failure.
|
|
*/
|
|
public function test_handle_component_failure(): void {
|
|
$this->resetAfterTest();
|
|
|
|
// Create another user who is not a DPO.
|
|
$this->getDataGenerator()->create_user();
|
|
|
|
// Create two DPOs.
|
|
$dpo1 = $this->getDataGenerator()->create_user();
|
|
$dpo2 = $this->getDataGenerator()->create_user();
|
|
$this->assign_site_dpo(array($dpo1, $dpo2));
|
|
$dpos = \tool_dataprivacy\api::get_site_dpos();
|
|
|
|
$observer = new \tool_dataprivacy\manager_observer();
|
|
|
|
// Handle the failure, catching messages.
|
|
$mailsink = $this->redirectMessages();
|
|
$mailsink->clear();
|
|
$observer->handle_component_failure(new \Exception('error'), 'foo', 'bar', 'baz', ['foobarbaz', 'bum']);
|
|
|
|
// Messages should be sent to both DPOs only.
|
|
$this->assertEquals(2, $mailsink->count());
|
|
|
|
$messages = $mailsink->get_messages();
|
|
$messageusers = array_map(function($message) {
|
|
return $message->useridto;
|
|
}, $messages);
|
|
|
|
$this->assertEqualsCanonicalizing(array_keys($dpos), $messageusers);
|
|
}
|
|
|
|
/**
|
|
* Ensure that when no user is configured as DPO, the message is sent to admin instead.
|
|
*/
|
|
public function test_handle_component_failure_no_dpo(): void {
|
|
$this->resetAfterTest();
|
|
|
|
// Create another user who is not a DPO or admin.
|
|
$this->getDataGenerator()->create_user();
|
|
|
|
$observer = new \tool_dataprivacy\manager_observer();
|
|
|
|
$mailsink = $this->redirectMessages();
|
|
$mailsink->clear();
|
|
$observer->handle_component_failure(new \Exception('error'), 'foo', 'bar', 'baz', ['foobarbaz', 'bum']);
|
|
|
|
// Messages should have been sent only to the admin.
|
|
$this->assertEquals(1, $mailsink->count());
|
|
|
|
$messages = $mailsink->get_messages();
|
|
$message = reset($messages);
|
|
|
|
$admin = \core_user::get_user_by_username('admin');
|
|
$this->assertEquals($admin->id, $message->useridto);
|
|
}
|
|
}
|