Stevani Andolo
00db83d1bf
In this commit, there are couple of fixes based on the report: 1. Removed legacy polyfill from provider.php 2. Fixed phpunit warning detected by CodeChecker 3. Removed unused files 4. Fixed the PHPunit failures by removing "securityquestions" from the data_provider due to it has not been included as one of the factors 5. Added PHPunit test to the factors that can be unittested 6. Removed !important rule from tool_mfa/styles.css 7. Added (int) type to sleep method within sleep_timer method due to a php deprecation in too_mfa/classes/manager.php 8. Changed last param form bool to string in not_enough_factors() when initiating a new single_button object in tool_mfa/renderer.php 9. Add explanation text to login page 10. Fixed "Access to an undefined property .." from PHPStan 12. Fixed all the "Variable $.. might not be defined" from PHPStan 13. Fixed the issue from https://github.com/catalyst/moodle-tool_mfa/issues/379
86 lines
3.0 KiB
PHP
86 lines
3.0 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
namespace tool_mfa;
|
|
use tool_mfa\tool_mfa_trait;
|
|
|
|
defined('MOODLE_INTERNAL') || die();
|
|
require_once(__DIR__ . '/tool_mfa_trait.php');
|
|
|
|
/**
|
|
* Tests for base factor implementation methods.
|
|
*
|
|
* @package tool_mfa
|
|
* @author Peter Burnett <peterburnett@catalyst-au.net>
|
|
* @copyright 2023 Catalyst IT
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
class object_factor_base_test extends \advanced_testcase {
|
|
|
|
use tool_mfa_trait;
|
|
|
|
/**
|
|
* Test deleting user's configured factors
|
|
*
|
|
* @covers ::setup_user_factor
|
|
* @return void
|
|
*/
|
|
public function test_revoke_user_factor() {
|
|
$this->resetAfterTest();
|
|
$user = $this->getDataGenerator()->create_user();
|
|
$this->setUser($user);
|
|
|
|
$this->set_factor_state('totp', 1, 100);
|
|
$totpfactor = \tool_mfa\plugininfo\factor::get_factor('totp');
|
|
$totpdata = [
|
|
'secret' => 'fakekey',
|
|
'devicename' => 'fakedevice',
|
|
];
|
|
$factorinstance = $totpfactor->setup_user_factor((object) $totpdata);
|
|
$totpdata2 = [
|
|
'secret' => 'fakekey2',
|
|
'devicename' => 'fakedevice2',
|
|
];
|
|
$totpfactor->setup_user_factor((object) $totpdata2);
|
|
|
|
$this->assertFalse((bool) $factorinstance->revoked);
|
|
$this->assertEquals(2, count($totpfactor->get_active_user_factors($user)));
|
|
|
|
// Test that calling the revoke on the generic type revokes all.
|
|
$totpfactor->revoke_user_factor();
|
|
$this->assertEquals(0, count($totpfactor->get_active_user_factors($user)));
|
|
|
|
// Add another factor for testing.
|
|
$totpdata3 = [
|
|
'secret' => 'fakekey3',
|
|
'devicename' => 'fakedevice3',
|
|
];
|
|
$factorinstance2 = $totpfactor->setup_user_factor((object) $totpdata3);
|
|
|
|
// Now test you can't revoke another users factor.
|
|
$user2 = $this->getDataGenerator()->create_user();
|
|
$this->setUser($user2);
|
|
|
|
$this->assertFalse($totpfactor->revoke_user_factor($factorinstance2->id));
|
|
$this->assertEquals(1, count($totpfactor->get_active_user_factors($user)));
|
|
|
|
// Now revoke as ourselves.
|
|
$this->setUser($user);
|
|
$this->assertTrue($totpfactor->revoke_user_factor($factorinstance2->id));
|
|
$this->assertEquals(0, count($totpfactor->get_active_user_factors($user)));
|
|
}
|
|
}
|