Tobias Reischmann
05f9380cbc
Due to race conditions in the function subscribe_user it was possible to create duplicate forum subscriptions. This lead to error messages, when displaying the list of all subscriptions. This patch removes all existing duplicate entries and creates a unique db key to prevent this from happening in the future.
119 lines
4.1 KiB
PHP
119 lines
4.1 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/**
|
|
* This file keeps track of upgrades to
|
|
* the forum module
|
|
*
|
|
* Sometimes, changes between versions involve
|
|
* alterations to database structures and other
|
|
* major things that may break installations.
|
|
*
|
|
* The upgrade function in this file will attempt
|
|
* to perform all the necessary actions to upgrade
|
|
* your older installation to the current version.
|
|
*
|
|
* If there's something it cannot do itself, it
|
|
* will tell you what you need to do.
|
|
*
|
|
* The commands in here will all be database-neutral,
|
|
* using the methods of database_manager class
|
|
*
|
|
* Please do not forget to use upgrade_set_timeout()
|
|
* before any action that may take longer time to finish.
|
|
*
|
|
* @package mod_forum
|
|
* @copyright 2003 onwards Eloy Lafuente (stronk7) {@link http://stronk7.com}
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
|
|
defined('MOODLE_INTERNAL') || die();
|
|
|
|
function xmldb_forum_upgrade($oldversion) {
|
|
global $CFG, $DB;
|
|
|
|
$dbman = $DB->get_manager(); // Loads ddl manager and xmldb classes.
|
|
|
|
if ($oldversion < 2015120800) {
|
|
|
|
// Add support for pinned discussions.
|
|
$table = new xmldb_table('forum_discussions');
|
|
$field = new xmldb_field('pinned', XMLDB_TYPE_INTEGER, '1', null, XMLDB_NOTNULL, null, '0', 'timeend');
|
|
|
|
if (!$dbman->field_exists($table, $field)) {
|
|
$dbman->add_field($table, $field);
|
|
}
|
|
|
|
// Forum savepoint reached.
|
|
upgrade_mod_savepoint(true, 2015120800, 'forum');
|
|
}
|
|
// Moodle v3.1.0 release upgrade line.
|
|
// Put any upgrade step following this.
|
|
|
|
if ($oldversion < 2016091200) {
|
|
|
|
// Define field lockdiscussionafter to be added to forum.
|
|
$table = new xmldb_table('forum');
|
|
$field = new xmldb_field('lockdiscussionafter', XMLDB_TYPE_INTEGER, '10', null, XMLDB_NOTNULL, null, '0', 'displaywordcount');
|
|
|
|
// Conditionally launch add field lockdiscussionafter.
|
|
if (!$dbman->field_exists($table, $field)) {
|
|
$dbman->add_field($table, $field);
|
|
}
|
|
|
|
// Forum savepoint reached.
|
|
upgrade_mod_savepoint(true, 2016091200, 'forum');
|
|
}
|
|
|
|
// Automatically generated Moodle v3.2.0 release upgrade line.
|
|
// Put any upgrade step following this.
|
|
|
|
// Automatically generated Moodle v3.3.0 release upgrade line.
|
|
// Put any upgrade step following this.
|
|
|
|
if ($oldversion < 2017092200) {
|
|
|
|
// Remove duplicate entries from forum_subscriptions.
|
|
// Find records with multiple userid/forum combinations and find the highest ID.
|
|
// Later we will remove all those entries.
|
|
$sql = "
|
|
SELECT MIN(id) as minid, userid, forum
|
|
FROM {forum_subscriptions}
|
|
GROUP BY userid, forum
|
|
HAVING COUNT(id) > 1";
|
|
|
|
if ($duplicatedrows = $DB->get_recordset_sql($sql)) {
|
|
foreach ($duplicatedrows as $row) {
|
|
$DB->delete_records_select('forum_subscriptions',
|
|
'userid = :userid AND forum = :forum AND id <> :minid', (array)$row);
|
|
}
|
|
}
|
|
$duplicatedrows->close();
|
|
|
|
// Define key useridforum (primary) to be added to forum_subscriptions.
|
|
$table = new xmldb_table('forum_subscriptions');
|
|
$key = new xmldb_key('useridforum', XMLDB_KEY_UNIQUE, array('userid', 'forum'));
|
|
|
|
// Launch add key useridforum.
|
|
$dbman->add_key($table, $key);
|
|
|
|
// Forum savepoint reached.
|
|
upgrade_mod_savepoint(true, 2017092200, 'forum');
|
|
}
|
|
|
|
return true;
|
|
}
|