stronk7
21ae339623
NOBUG Fixed error happening when restoring missingtype questions if answers weren't present (cast error)
2009-07-29 18:59:27 +00:00
tjhunt
997dbc1d6a
question bank: MDL-19826 Tidy up.
2009-07-15 04:04:23 +00:00
tjhunt
6ab41ced9f
question bank: MDL-19826 Error when deleting a lot of questions
...
We were stupidly putting the list of questionids in the URL, even though this was a post forum.
2009-07-15 03:33:27 +00:00
tjhunt
cb06574d5b
question bank: MDL-18822 Highlight the last question you edited in the list
...
Helpful if you need to edit a lot of questions - saves you from losing your place.
Idea and patch by Oleg Sychev.
2009-06-05 08:30:35 +00:00
pichetp
be88a9db22
MDL-19210 eliminate the generation of multiple dataitems having the same item number
...
merge from HEAD
2009-05-25 03:35:23 +00:00
pichetp
3978521f56
MDL-19214 Adding category hidden element Merging from HEAD
2009-05-24 21:06:34 +00:00
gbateson
beef81db81
MDL-18883: fix setting of absolute urls for images in subfolders of course files
2009-04-17 01:50:11 +00:00
skodak
36560de1bf
MDL-18875 no PHP5 syntax in 1.9.x yet
2009-04-16 06:27:37 +00:00
tjhunt
579c4bc033
shortanswer qtype: Add the problem case from http://moodle.org/mod/forum/discuss.php?d=120557 to the unit tests.
2009-04-06 02:03:05 +00:00
skodak
88b119010d
MDL-18769 PHP5ism not allowed in 1.9
2009-04-01 15:48:57 +00:00
tjhunt
d547bb0bd0
qtypes: MDL-18711 Allow qtype plugins to have custom CSS and JavaScript on the editing page.
2009-03-30 09:15:37 +00:00
tjhunt
6042285796
questions: unit tests for default_questiontype::compare_responses.
2009-03-26 08:42:18 +00:00
mudrd8mz
f847d9f546
MDL-18644 Both if and else end with return therefore another return afterwards is
...
obsolete. Also, "return true" at top of the function renders all the
following code useless
2009-03-23 09:47:45 +00:00
thepurpleblob
4a093d5096
MDL-18579:
...
Provide nicer message if 'Stop on error' is selected and errors are found.
2009-03-18 11:14:17 +00:00
thepurpleblob
80fe7b9ef7
MDL-18555:
...
Adding better handling for unsupported question types.
2009-03-16 14:19:46 +00:00
thepurpleblob
7d8f12b630
MDL-18390:
...
Now looks up the questiontype name correctly.
2009-03-16 13:43:19 +00:00
tjhunt
d3c7da5741
qtypes: MDL-18559 questions showing penalty information when they shouldn't.
...
We had a !== when it should have been !=, and our constants were defined as strings not ints. This problem has been there since forever, but no one had noticed before. Thanks to Alan Trick for finally spotting it!
2009-03-16 01:52:24 +00:00
thepurpleblob
4e334e2d89
MDL-18390 - now correctly looks up name of questiontype from language pack
2009-03-11 13:15:32 +00:00
thepurpleblob
a34725b3eb
MDL-18390
...
Corrected handling of unsupported question types and added new language file
to remove hard coded strings.
2009-03-04 10:25:23 +00:00
tjhunt
86bfbf6d5a
Aiken question import: MDL-18423 Greater robustness when parsing.
2009-03-03 05:12:06 +00:00
tjhunt
4bfcbb6065
qtype base: remove debug code.
2009-03-03 04:37:46 +00:00
tjhunt
51d6e3d5b9
Add missing Id tags to all files under question, to help the unmerged files script.
2009-02-19 01:09:33 +00:00
pichetp
fbffc13306
MDL-18034 MDL-18035 fixing typo merged from HEAD
2009-02-18 18:04:12 +00:00
tjhunt
e18c7dde34
question editing: MDL-18035 Nice refactoring from Oleg Sychev that saves 50+ lines of code between the various editing forms.
2009-02-18 06:52:02 +00:00
tjhunt
56cef87b61
random question: MDL-18174 Fix notice when adding a random question to a quiz.
2009-02-17 06:14:48 +00:00
tjhunt
a2b4f68e91
question bank: MDL-12719, MDL-15774, MDL-17105, and MDL-18174
...
These are all to do with the combination of the $form->category, and $form->categorymoveto fields on the question editing forms since Moodle 1.9. These are now resolved to a single ->category value in question.php, which simplifies the logic for the individual question types.
MDL-15774 and MDL-12719 errors editing Cloze question
MDL-17105 problems with qustion saving logic.
MDL-18174 'Select from subcategories' option not preserved when editing a random question.
2009-02-13 06:11:58 +00:00
tjhunt
45b0c62de6
datasetdependant qtype: fix whitespace.
2009-02-10 05:40:13 +00:00
Francois Marier
cc90879d52
Fix CVS-git drift (old .sql files)
2009-02-01 23:44:30 +00:00
pichetp
3c6ed6e2ca
MDL-17995 replacing is_null() by empty(). Merged from HEAD
2009-01-26 01:27:16 +00:00
pichetp
eb64eefaab
MDL-17995 replacing != '' by !empty(). Merged from HEAD
2009-01-26 01:26:03 +00:00
pichetp
bb215b150f
MDL-17995 replacing $wrapped !='' by !is_null($wrapped) Merge from HEAD
2009-01-25 14:52:56 +00:00
tjhunt
ee71dd5d5b
matching qtype: MDL-17981 extra distractors feature was not working on MS SQL server, since MDL-14420 was fixed.
2009-01-23 02:19:36 +00:00
tjhunt
1ed574d378
quiz backup: MDL-17970 MSSQL text / varchar compare issue.
...
Commiting this fix so it gets into 1.9.4. I've tested and it does not break sensible databases, and probably fixes the problem on MSSQL.
2009-01-20 04:24:01 +00:00
tjhunt
1ae3f411b5
backup/restore: MDL-16614 more reliable test for when we are restoring a backup that was made of the same site that we are restoring to.
...
* Use this to fix a question restore bug.
* Replace older code that does something similar with the new test.
* Refactor initialisation of $CFG->siteidentifier into a function. There were about 4 copies of this code ;-)
2009-01-20 03:16:05 +00:00
tjhunt
190dddfc0b
quiz / questions: MDL-17919 Bad link edit questions from quiz preview page.
...
Thanks to Ann Adamcik for noticing this. It was a regression from MDL-6085.
2009-01-16 04:47:35 +00:00
tjhunt
bf28249d82
questiontypes: MDL-17800 Add extra_question_fields() support to backup/restore functions.
...
* Implement this in the base class, and
* use this in the shortanswer type as a proof of concept.
This makes writing new question type subclasses a bit easier. Thanks to Oleg Sychev for this code.
2009-01-15 07:29:00 +00:00
tjhunt
4328416b29
question engine: MDL-17651 this context is not used anywhere, so remove it.
...
(There was a bug in the get_context_instance call.)
2009-01-15 05:15:31 +00:00
tjhunt
a23612213a
shortanswer qtype: MDL-17706 use extra_question_fields mechanism to save on code. Changes thanks to Oleg Sychev.
2009-01-09 05:10:40 +00:00
thepurpleblob
db784f7936
MDL-17779
...
Add simple check that question at least has questiontext before allowing it.
2009-01-05 15:20:11 +00:00
tjhunt
159865b202
multichoice qtype upgrade: MDL-17619 referring to constant from questionlib.php, which was not being included.
2008-12-12 13:12:59 +00:00
tjhunt
aa77a3d3de
match qtype: MDL-17326 backup and restore problems
...
* The shuffleanswers options was not backed up or restored.
* Responses were not properly recoded on restore.
2008-12-12 06:45:01 +00:00
tjhunt
2eaf6c0e95
matching qtype: MDL-17496 With filterall and multilang, the contents of the dropdowns was not being properly filtered
...
This was caused becuse the solution to MDL-9005 was not quite right.
2008-12-12 04:39:30 +00:00
tjhunt
26207ab4c2
numerical and shortanswer question types: problems with compare_responses and test_response.
...
MDL-15315 The previous fix for this issue with wildcard answers in the item analysis report caused the following two regressions. This patch fixes it properly.
MDL-17247 This is basiclly pointing out the weridness in the previous fix and gave some useful clues as to a proper solution. Thanks Oleg.
MDL-17610 This was a report of a problem with each attempt builds on last, with a shortanswer question, where the sutdent's response contains a '.
Also, lots of unit tests to try to ensure the new code is right.
2008-12-12 03:48:32 +00:00
tjhunt
5be081f0d9
matching qtype: MDL-14420 Could not use '0' as a question stem. Oops, more tests need to be corrected.
2008-12-11 05:01:43 +00:00
tjhunt
112b018900
matching qtype: MDL-14420 Could not use '0' as a question stem. Bloody PHP!
2008-12-11 04:57:45 +00:00
tjhunt
2c87248acc
matching qtype: whitespace cleanup.
2008-12-11 04:55:48 +00:00
tjhunt
88575207d3
numerical qtype: MDL-15159 Error moving a numerical question type with no units from one category to another.
2008-12-11 04:33:48 +00:00
dongsheng
f3355b7b06
"MDL-17570, cleanup inline css"
2008-12-10 07:09:48 +00:00
tjhunt
110b003f86
quiz manual grading: MDL-5517 manual grading pop-up is too small. HTML editor does not fit.
2008-12-10 07:06:18 +00:00
tjhunt
51134a7b79
quiz: MDL-6085 when editing a question from various places like a preview attempt or review screen, don't use a popup, instead take advantage of the fact that question.php now takes a returnurl.
2008-12-10 06:22:04 +00:00