49a9771cf5
MDL-19078 course search: also look in idnumber and shortname fields
2009-06-10 05:49:56 +00:00
22fc88f88b
MDL-17837 opt limit resultsets returned by some get_xxxx_users() function.
2009-01-14 17:44:46 +00:00
576fe29a1c
"MDL-16954, get rid of remote_addr notice on cli, set ip = 0.0.0.0 in mdl_log table when accessed from cli"
2008-12-11 05:17:02 +00:00
79518165b9
course categories: Fix many bugs with category editing and permissions. Clean up code.
...
Bugs: MDL-17479, MDL-16426, MDL-16063, MDL-16013, MDL-15658, MDL-15556, MDL-15161, MDL-14925, MDL-13742, MDL-11557.
* Simplify category editing permissions to just moodle/category:manage and moodle/category:seehiddencategories.
* Enforce those correctly. (Note MDL 17502 is still outstanding.)
* Don't screw up category sort order when you just edit name or description.
* Niceties like where redirects go when you cancel or submit forms.
* Make sure a global course creator can see the site admin block.
* Don't allow a category to be made the child of one of its children!
* General code cleanup to bring key files more in line with best pracitice.
Apologies for the fact it is one big patch, rather than a series of smaller patches. However, categoryedit.php, category.php and index.php where in pretty bad shape and needed significant cleaning up. categoryedit.php, in particular, was almost completely rewritten.
2008-12-04 08:49:47 +00:00
426c2ba5b2
restore: MDL-17480 Potentially expensive function user_can_create_courses called repeatedly from restore UI.
2008-12-01 06:55:31 +00:00
0e2a066e7b
MDL-14488 - start sql query with unique field - credit David Monllaó
2008-09-07 06:03:49 +00:00
5d10a560d7
MDL-7971 check in get_categories if user can see hidden categories uses specific capability not course:create
2008-07-16 15:12:12 +00:00
0148e8be18
"MDL-14460, fix all get_context_instance"
2008-05-01 06:02:27 +00:00
e8ee249670
Finally fixed version of lastaccess hadling.
...
Moved from add_to_log() to require_login(). MDL-14272
2008-04-15 21:42:50 +00:00
afd99f1f07
Correct usage of debugging. MDL-11893
2008-04-15 21:31:10 +00:00
7d23ab127f
Fixing logic + minor formatting of email. MDL-11893
2008-04-15 20:01:27 +00:00
6fdfabaf42
MDL-11893, append failed SQL to email, see tracker
2008-04-15 05:36:25 +00:00
f4cb414111
Check for 60s interval from PHP. Save 3 queries per request. MDL-14272
2008-04-10 20:57:10 +00:00
5c978acd07
Unset rcahe on UPDATE statements not using dmllib.php. MDL-14257
2008-04-08 23:12:08 +00:00
cd3a029451
MDL-12263, under certain conditions, $catctxids is NULL, so an if statement should be here.
2008-03-20 07:16:33 +00:00
c147575b6c
MDL-13915: Fixed add_to_log when very long url is specified (now doesn't try to insert more than 100 chars into database)
2008-03-13 15:25:12 +00:00
5ab05fb15f
MDL-11180 datalib: get_courses() - grab the course context as part of the select
...
This speeds up course & category listing enormously - cutting 2500 DB queries
for a site with 2500 courses. It's the power of the JOIN...
2008-02-26 21:51:16 +00:00
e5f7002f2f
MDL-12294 fixed parentlang string
2008-02-26 07:27:23 +00:00
c5b4af2e5d
MDL-13483 found two more native php mail() commands
2008-02-25 14:03:53 +00:00
794fc9a9a3
MDL-13399, MDL-13614 fixed regression caused by last commit
2008-02-23 19:28:33 +00:00
8905e7b645
MDL-13399 prevent ambiguous column names in get_my_courses
2008-02-18 20:13:02 +00:00
f1bd9b5ecf
MDL-13155 reworked get_all_instances_in_course() and get_all_instances_in_courses(), based on patch by Tim
2008-02-05 21:34:08 +00:00
4ce19d978c
MDL-12945 disabled mods are not returned from get_course_mods() anymore, the results are used in scheduled backup and other parts that do not expect disabled mods
2008-02-01 07:32:34 +00:00
94cbbdbd2e
MDL-12945 a slightly bigger patch for performance in recent activity and various group related issues + some other fixes - see list of subtasks in tracker
2008-01-24 20:29:31 +00:00
8658d5c5b0
MDL-12523 datalib: get_admins() - Rewrite to avoid get_users_by_capability()
...
get_admins() and get_admin() were counting on
get_users_by_capability() returning a role-assignment id to pick the
"primary" admin account. With the get_users_by_capability() rewrite,
we no longer have an RA id to clearly blame for the capability.
So, rewrite get_admins() based on the known-good SQL used in
is_siteadmin().
MDL-12452
2008-01-06 23:17:42 +00:00
225ff8f476
Better behaviour for "-" course searches under MSSQL and Oracle. MDL-7312 ; merged from 18_STABLE
2008-01-01 12:01:36 +00:00
f7cf45ab80
Prevent some debugging notices, cast to object before inserting.
2007-12-31 15:18:59 +00:00
297178bc87
Improve PHP doc comments.
2007-12-12 17:10:51 +00:00
7e17fa336e
datalib: get_logs_user*() - fix invalid SQL - MDL-12426
...
Oracle does not accept column labels in the GROUP BY section -
get_logs_usercourse() and get_logs_userday() were computing the
day/hours column and using it in the GROUP BY. The compatible fix
is to reproduce the same computation in the GROUP BY section.
Credit for the fix goes to Dennis Rochford <Dennis.Rochford@usq.edu.au >.
2007-12-04 06:24:23 +00:00
1a35d7472f
MFC: MDL-12101 cleanup/fixing/refactoring of user bulk operation and admin user browsing
2007-11-13 09:02:11 +00:00
677ab5e475
Fix typo.
2007-10-25 14:29:39 +00:00
5e919c34ee
MDL-11893, send email to admin when add_to_log fails
2007-10-25 04:01:38 +00:00
03cedd6283
MDL-11432 eliminated majority of RecordCount uses, added several missing rs_close() - this should help improve perf on some platforms - Eloy says ;-)
2007-10-10 12:19:27 +00:00
115a43113a
ANSI join ON clauses should contain only the join condition. Also,
...
added prefix to the ORDER BY to prevent duplicate names.
2007-10-08 17:42:46 +00:00
5b1dbd5cd7
Some SQL fixes to avoid putting 'quotes' around integers (performance)
2007-10-05 13:34:28 +00:00
d75731c6ac
prevent returning of invalid array from get_course_managers()
2007-10-03 22:26:05 +00:00
59bef7283d
Moving 3 functions from datalib to deprecatedlib. Only used
...
by admin/cron.php. First step of MDL-11571 and MDL-11487
2007-10-03 16:31:20 +00:00
1afb11e70b
Fixed longtimenosee unenrolments. user_lastaccess and role_assignments were growing with uneccessary entries, to the point where memory limits were reached and in the end NO unenrolments were happening at all.
...
See MDL-11571
2007-10-03 12:24:06 +00:00
3b0ee367a7
MDL-11466 - failing to check for the case $rs = false in the accesslib performance improvements. Credit for the fix goes to Gareth Morgan.
2007-09-26 21:31:54 +00:00
8d503f7557
Get rid of duplicate $Id$ tags.
2007-09-26 10:11:13 +00:00
bfbfdb5350
MDL-11350 allowvisiblecoursesinhiddencategories was not used fully in the determination of the course's visibility
2007-09-20 13:15:26 +00:00
05a71b3341
change restore code to use the more efficient get_user_courses_bycap
2007-09-20 09:16:49 +00:00
1ced9d7b73
MDL-10903 - Wrong capability checked in get_all_instances_in_course should be moodle/course:viewhiddenactivities, not moodle/course:viewhiddencourses. Merged from MOODLE_18_STABLE.
2007-09-19 17:06:31 +00:00
45ea1afb16
accesslib: make_context_subobj() now expects ctxlevel, and fix all callers
...
make_context_subobj() was not providing a contextlevel property, and
no callers fetched the field. This comes from its humble origins where
it was only ever called for course objects. These days it's used in
many other situations, so this patch DTRT and
- fixes make_context_subobj() expect a cxtlevel and turn it into
contextlevel
- fixes all callers (accesslib, datalib) to provide it
2007-09-19 07:54:37 +00:00
b1cff118c7
datalib:get_courses_wmanagers() handle empty $CFG->coursemanager more gracefully
...
Having no roles set as coursemanager is a valid setting.
get_courses_wmanagers() should not produce invalid SQL on it...
actually, it should not even try to get the course managers.
2007-09-19 07:54:23 +00:00
bbfed0ec61
datalib: get_my_courses() honour $fields array
...
If the caller passes a fields array, then merge it as we say we will do.
2007-09-19 07:51:36 +00:00
b9e9491a89
accesslib: get_my_courses() fix when called when empty sort
...
get_my_courses() was failing if called with an empty sortorder on a
cached courselist. Fix.
2007-09-19 07:51:19 +00:00
e89f157b0a
datalib: get_courses_wmanagers() exclude the sitecourse
...
Should never return the sitecourse - so we exclude it explicitly.
2007-09-19 07:49:10 +00:00
2e159efb1c
Revert "datalib: Introducing sql_intarray_to_in()"
...
We don't need sql_intarray_to_in(), use implode() instead.
This reverts commit 3ef7fc54d9df780c837c64a8ace1fc565d6d7744.
2007-09-19 07:47:26 +00:00
44f1636ee2
datalib: get_categories() - remove PostgreSQL-ism
2007-09-19 07:28:43 +00:00
fmarier