Commit Graph

421 Commits

Author SHA1 Message Date
iarenaza fc54986465 ldap auth and enrolment: MDL-19672 prevent update_user_record() from mangling distinguished names with backslashes
In addition to it, in order to be able to used a distiguished name with '\'
(and other LDAP special characters) in a LDAP filter to find the user
enrolments, we need to quote it using the LDAP filter quoting rules
2009-07-06 18:51:30 +00:00
iarenaza 2ecb5ae389 CAS authentication: MDL-19671 phpCAS::getUser can return a mixed-case username, so lower-case it for comparison.
Merged from MOODLE_18_STABLE
2009-06-30 23:32:42 +00:00
iarenaza aab2bf6809 ntlmsso login hook: MDL-18596 We need to call httpsrequired() before using httpswwwroot 2009-06-04 22:22:37 +00:00
fmarier 386f08f476 Fix typo 2009-05-15 03:36:44 +00:00
fmarier 9c067299f6 MDL-19156: auth/fc: clarifying the licensing terms as per author's email 2009-05-11 23:38:44 +00:00
skodak fa952896a3 MDL-18704 fixed incorrect mnet logging 2009-05-08 12:15:34 +00:00
skodak 623a81e19a MDL-18744 cas fix, credit goes to Thibault Le Meur 2009-05-08 07:53:11 +00:00
skodak 2e4dfb210e MDL-18757 using new addslashes_recursive() instead of old addslashes_object() which does not tollerate arrays, nulls, etc. 2009-05-06 15:53:52 +00:00
dongsheng 551d425a88 "MDL-19037, use getremoteaddr to get remote ip address, backported from 2.0" 2009-05-01 08:06:08 +00:00
mudrd8mz 5a1655832f MDL-18644 Variable used without $-prefix 2009-03-23 09:44:52 +00:00
exe-cutor f21a6c674c MDL-18597 Various code improvements, new logout return url config option and better instructions regarding Shibboleth logout 2009-03-18 13:26:31 +00:00
exe-cutor 37934e4996 Shibboleth authentication: Fixed bug MDL-18538 that overwrites alternateloginurl when Shibboleth authentication settings are saved 2009-03-12 15:06:07 +00:00
skodak f2af2ec841 MDL-18209 fixe short php tag - thanks Jeffrey Silverman 2009-02-15 19:23:24 +00:00
iarenaza 6a31fe27bb Cache LDAP connections: MDL-18130 Properly handle open LDAP connections.
Both CAS and LDAP auth plugins open new connections to the LDAP server
to get the user account details. While this is the desired behaviour
for regular logins (we probably don't have an already open connection
to the LDAP server), this is a ressource hog when we are doing user
synchronization, as the closed connections remain in the TCP_WAIT
state for a while before the server can reuse them. If we are syncing
a lot of users, we can make the server run out of available TCP
ressources.

So we cache the connection the first time we establish it and return
the same connection handle everytime, unless we've closed all the
'open' connections, or the auth object is destroyed.

In addition to that, there were a few missing calls to ldap_close().
2009-02-15 14:53:58 +00:00
iarenaza b65da94dd7 NTLM SSO: MDL-13760 Speed up ntlm sign on with conditional redirect for msie
Provides an option, configurable by admin, to make the ntlm test happen
only if MSIE is not used. This speeds things up for IE.
2009-02-14 16:17:51 +00:00
iarenaza f8102d906e NTLM SSO: MDL-14584 Fix for several outstanding NTLM SSO issues.
These include:

MDL-14078: redirect() doubles the specified timeout when we haven't printed
           the page header and uses javascript to execute the redirect. This
           is interacting badly with some versions of IE and FF (at least
           3.0.x Windows version) that fireup javascript timers even if
           we already left the page where we set those up. Just print
           the page header (we are printing other content anyway) to
           make redirect respect our timeouts.

MDL-14071: All the relevant details are in the description of the bug :)

MDL-14297: This is probably the same as MDL-14078
2009-02-14 16:14:22 +00:00
exe-cutor 08b51e7f13 authentication: MDL-18116 Added Shibboleth logout handler URL, remove hard-coded strings to lang file, updated README
- Added a new setting logout_handler to the Shibboleth authentication settings
- Removed hard-coded strings in the configuration settings and replaced them with proper print_string expressions
- Added a logoutpage_hook function that (optinally) sends a user who clicks on the logout button to the Shibboleth logout handler after Moodle logout
- Updated README
2009-02-06 08:19:58 +00:00
iarenaza b11a0766ed auth/ldap: MDL-9405 sync_users() can create duplicated users
Merged from MOODLE_18_STABLE

If we are using auth_ldap_sync_users.php to synchronize our users, and we
have a database which is case-sensitive when doing comparisons (Postgres and
Oracle at least), and any of our users has the vale of the username attribute
in mixed-case (like 'John Smith'), we get duplicated users.

This is because we don't make sure the username attribute value is 'lowercased'
after we retrive it from the LDAP server and before we insert it into the
database.
2008-12-26 16:00:12 +00:00
jonathanharker 501592d7be MDL-17549 auth/radius: add CHAP and MSCHAP auth support, detect PHP reqs
* Added support for CHAP and MSCHAP authentication schemes
   contributed by Stanislav Tsymbalov http://www.tsymbalov.net/
   original code at http://sourceforge.net/projects/moodleradius/

 * Tweak the detection of PHP RADIUS extension and Pear code

 * Update the warning notices to use more Moodly CSS classes

 * Add PEAR Auth_RADIUS and Crypt_CHAP packages to lib/pear
2008-12-14 23:18:53 +00:00
exe-cutor b926e3dde5 Added Upgrade instructions for Shibboleth 2.x
Corrected some typos for logout section
2008-12-08 10:46:13 +00:00
exe-cutor 8f12ddef8e Added fix for Shibboleth 2.x 2008-12-08 10:45:47 +00:00
exe-cutor 9333948786 Added Shibboleth front and back channel logout support 2008-12-04 16:27:00 +00:00
moodler 69017ad364 auth/cas MDL-17121 Upgraded to latest version which is LGPL 2008-11-07 01:59:35 +00:00
peterbulmer 8fca983968 MDL-15942 catch one more mnet update needing secure commit
Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-10-30 01:42:17 +00:00
peterbulmer 1a445dc3fc MDL-17038 bugfixes
Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-10-30 01:40:21 +00:00
peterbulmer 00959494a6 MDL-17038 - truncate overlength varchar fields before attempting to insert
Signed-off-by: Peter Bulmer <peter.bulmer@catalyst.net.nz>


Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-10-30 01:39:45 +00:00
peterbulmer d5942d6a6f MDL-17038 formatting correction
Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-10-30 01:39:09 +00:00
peterbulmer 5b407159d5 MDL-17038 Change to use sensible variable names
Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-10-30 01:38:39 +00:00
peterbulmer e3c3610af1 MDL-17038 - refine query to limit size of returned data.
Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-10-30 01:21:15 +00:00
iarenaza b29004e366 MDL-16061 Revert incorrect fix for "Remove 'username' from the $moodleattributes array".
Merged from MOODLE_18_STABLE.

The fix is wrong, as it breaks auth_db_sync_users.php and
auth_ldap_sync_users.php at least. No new users are added to Moodle, as the
username is missing from the new user info record.

The fix needs to go into update_user_record() in lib/moodlelib.php to make it
skip the 'username' key, as we really need get_userinfo() to return the
username as part of the user info array.
2008-08-25 22:40:29 +00:00
iarenaza 6046523272 MDL-15799 LDAP - user data mapping doesn't work. Merged from MOODLE_18_STABLE
The Right Way(tm) to write a LDAP filter is enclosing it in parentheses (see
RFC 4515/2254).
2008-08-24 20:42:57 +00:00
iarenaza 1e6da87629 MDL-16061 Remove 'username' from the $moodleattributes array.
It doesn't make sense at all (username is not part of the externally mapped
fields) and produces a notice that breaks HTTP headers with debugging enabled.
2008-08-15 11:21:48 +00:00
jerome 36cf4a27de MDL-15175: ensures cross-db: add a lowercase conversion for the username 2008-08-14 09:44:13 +00:00
peterbulmer 5edabc2b82 MDL-15933 Require jump destination MNET peer to be non-deleted.
Also require landing source MNET peer to be non-deleted.
2008-08-13 23:31:01 +00:00
jerome 7a12ac92c0 MDL-15175: fix sync with external Oracle database 2008-08-13 06:31:45 +00:00
stronk7 fc9d285a62 Fixed copy&paste error. Credit goes to Sergio Rabellino.
http://moodle.org/mod/forum/discuss.php?d=102933
2008-08-07 17:09:27 +00:00
peterbulmer 73c73b1119 MDL-12558 modify emails as they are being sent
replace urls in-place to direct users to their idp first
(1.9 edition - Moodle-Moodle sso only)
2008-08-03 23:28:59 +00:00
skodak 2959f8b18e MDL-9983, MDL-13998, MDL-15552 core events related cleanup and potential sql injection problem fixed; please note the changes are not backwards compatible, 3rd party code will need to be updated - sorry for the trouble 2008-07-06 17:55:54 +00:00
skodak 5e8fe2da7a MDL-15398 reverting previous incorrect patch 2008-06-24 22:09:46 +00:00
fmarier f42d997d98 auth/ldap: fix PHP warnings and remove bad "Choose one" id 2008-06-19 02:27:33 +00:00
iarenaza 8278b5164b MDL-4248 Fix error when updating user profiles and any of these fields is empty
According to http://es2.php.net/manual/en/function.ldap-modify.php#43216 we
need to specify an array() value to delete an attribute's value, instead of an
empty string.

Merged from MOODLE_18_STABLE
2008-05-31 14:55:56 +00:00
dongsheng 2e49d3ab21 "MDL-15037, remove "none" in html head" 2008-05-29 03:21:11 +00:00
iarenaza c875af622e MDL-14987 Default attribute for Active Directory password expiry is missing
Backported from HEAD
2008-05-25 21:55:50 +00:00
dongsheng 443a1fee8e "MDL-14460, fix all the other get_context_instance,(use sed replace them), see tracker" 2008-05-02 04:07:27 +00:00
skodak 475419e555 MDL-14543 fixed broken deleting from auth sync 2008-04-25 13:20:28 +00:00
skodak 6547c735ca removing bogus //1 2008-04-25 12:24:52 +00:00
skodak d1e867d052 MDL-13401 fixed REQUEST_URI test 2008-04-25 12:23:21 +00:00
thepurpleblob a2e867b092 MDL-14461:
The user must be (effectively) be logged in to use this function.
Adding the logged in check means they will be asked if they are not (like
everywhere else)
2008-04-23 08:45:29 +00:00
dongsheng 4c404aa348 MDL14312, remove align attribute in table tag 2008-04-16 02:29:55 +00:00
dongsheng 2df5a942f3 MDL-14311, fix minor html errors 2008-04-15 05:53:51 +00:00