Fixing XHTML stuff
Skodak's patch from SC#187 without the HACK ALERT part
The "Next" buttons in grading windows don't get you where you 'd
expect right now, but please see SC#187 before doing anything about it.
- zero grade vs no grade now works, no grade is stored as -1 in database
- student modification time was being updated by teacher in quickgrade
- sundry notices
- grade buttons are now links
- popup window has teacher comments at the top
- popup window can now cycle through all users without leaving the window
- new quickgrading feature to grade inline in one go
- can choose page size
find the solution. No hacks, no replicating the table object, I just tweaked
the table class itself to help us.
I 'll post at SC#187 about this, but the bug is now totally fixed.
This is obviously a copy/paste artifact from mod/quiz/report/overview/report.php,
but notice that over there is non-trivial processing going on over there with the
sortorder array!
The sortorder can be used directly in queries, just stick an "ORDER BY " in front.
at SC#187 postid 1104 with a small addition, EXCEPT the //HACK ALERT part.
Where does that leave us? The popup does not die anymore, BUT:
1. It throws a notice about $sort not being defined (to be expected)
2. It doesn't use the correct sortorder ($sort is not defined, so default sort)
Please see the discussion at SC#187 before doing more work on this.
Changing get_records_sql() for one record ALWAYS and associated foreach() to
a get_record_sql() without foreach. Please be considerate with copy/paste. ;-)
Users can now be assigned to multiple groups. Thanks Yu!
Break out the Bob Marley!!
Otherwise groups work more or less like they did before.
This has been pretty well tested by Yu and myself, but since Yu started
uncovering lots of existing groups bugs it's possible there may be still
a few corner cases still lurking here and there.
Please help test this thoroughly for 1.6!!
defacer