the course has "no groups" UNLESS groupmodeforce == 1 as well.
Sadly, this severely weakens the performace optimizations :(
See bug 3303 for an example of what the problem was before.
Users can now be assigned to multiple groups. Thanks Yu!
Break out the Bob Marley!!
Otherwise groups work more or less like they did before.
This has been pretty well tested by Yu and myself, but since Yu started
uncovering lots of existing groups bugs it's possible there may be still
a few corner cases still lurking here and there.
Please help test this thoroughly for 1.6!!
the point, it could be much tighter and easier to understand. So here's the
candidate replacement code plus some assertions, I intend to let it run for
some time and if no assertion errors come up (they shouldn't) do the replace.
This was almost my very first Moodle code. Isn't experience wonderful? ;-)
More correct handling of group events, we cannot simply omit them because
the course has "no groups" UNLESS groupmodeforce == 1 as well.
Sadly, this severely weakens the performace optimizations :(
See bug 3303 for an example of what the problem was before.
1. Possible fix for bug 2410, also bug report at http://moodle.org/mod/forum/discuss.php?d=19173.
2. Group events may be edited by teachers without course editing rights.
3. Cosmetics for the DST display (this is a work in progress).
pleasantly viewable in any browser (I 'm testing FF and IE).
Some things still don't satisfy me and some parts haven't been done yet.
But at least it doesn't look broken in IE anymore.
**********************************************************************
* THIS IS NOT COMPLETED YET AND IN FACT IT'S QUITE BROKEN RIGHT NOW! *
**********************************************************************
My head is spinning and that's enough layout madness for one day.
Fix for bug 2252:
You can now choose to have the calendar "remember" your filter settings
between logins.
Some extra code in calendar/lib.php for DST. It doesn't currently affect
how Moodle works.
The old code assumed that the courseid would always be set but that is only the case for course events, not for user or group events. (See http://moodle.org/mod/forum/discuss.php?d=4466#20827 for a discussion about the meaning of the courseid field in the event table)
I also made the $courseid argument to get_coursemodule_from_instance() optional. It is not needed and in some cases it will not be know, as for example for non-course events created by activity modules.
defacer