Commit Graph

180 Commits

Author SHA1 Message Date
tjhunt 83f0fef567 questions manual grading: MDL-15147 refine the logic for distinguishing '' and 0, so you can grade an essay 0 without making a comment, but also, grade some, but not all student's work in the manual grading report. 2008-12-12 09:00:11 +00:00
tjhunt 47ceac47e4 questionlib: clarify a comment. 2008-12-12 02:50:36 +00:00
tjhunt 3c573960ec question bank: MDL-14376 Errors deleting a course containing Cloze questions.
(For some reason, this only seemed to cause problems on MySQL.)
2008-12-11 05:31:33 +00:00
tjhunt e8f99abc68 quiz manual grading: MDL-5517 manual grading pop-up is too small. HTML editor does not fit. Merged from MOODLE_19_STABLE.
Also MDL-17585 Improve layout of manual grading forms to make them look more like formslib forms. The standard trick of stealing the HTML and class names that formslib works, so the standard style rules apply to your form.
2008-12-10 09:11:30 +00:00
tjhunt 426091ee1f Simple whitespace cleanup. 2008-12-10 05:32:51 +00:00
tjhunt f24493ec9b random essay questions: MDL-8648 Allow essay questions to be selected by random question.
In the 1.9 branch this is controlled by a new option under Admin -> Experimental. In Moodle 2.0 dev it is not optional, it just works.

The main change is letting the manual grading report know which random questions might need manual grading. MDL-4004 - this depends on the random question under consideration, which requires a new questiontype method.

I also changed the random question code so that I could remove some global variables.
2008-11-28 06:07:11 +00:00
tjhunt df4e224454 question bank: MDL-14434 Cannot edit the only question category in a context. 2008-11-27 11:50:29 +00:00
tjhunt 24ada7b2b6 Yay! found a global variable that was not being used anywhere. Kill! Kill! 2008-11-26 08:55:24 +00:00
jamiesensei 91ec2c427a MDL-17183 "function 'question_get_real_state' fails when response is empty string" fixed regular expression 2008-11-10 07:03:25 +00:00
tjhunt 30f09308b9 MDL-16683 - add 5/6 as a grading option. Also, make all these optoins 7 decimal places, to match what we store in the DB, and explaing the 'rationale' behind the list. 2008-09-26 03:14:05 +00:00
tjhunt ac324e05ea MDL-16675 change callers to require_js to take advantage of the fact that callers no longer have to add $CFG->wwwroot themselves. 2008-09-25 06:40:52 +00:00
jamiesensei 8b92c1e3f6 MDL-16529 "Only include closed attempts in manual grade counts" 2008-09-23 09:52:55 +00:00
tjhunt d583bff0fc Update to use print_js_config. 2008-09-23 02:56:46 +00:00
tjhunt 766df8f72b MDL-16334 Convert mod/quiz/comment.php to use attemptlib.php - final part of the work on the quiz navigtion, I hope.
MDL-16559 Remove question/comment.html template, and instead just have a function in questionlib.php
MDL-16562 Regression from MDL-16263, notices when regrading.
Sorry, the three got tangled together (coupled through questionlib) while I was fixing bugs in preparation for a demo.
2008-09-18 07:39:10 +00:00
tjhunt bdff6b85d9 MDL-16409 - Finish the report. 2008-09-10 05:34:09 +00:00
tjhunt cca6e300e7 Refactor getting question bank capabilties in mod/quiz/lib.php - don't hard code them.
Also, functions for getting a URL for editing questions in a particular context, ready for MDL-16409.
2008-09-10 05:28:25 +00:00
tjhunt 05efb0e52f MDL-6751 Admin page for question types. This does the bulk of the work:
MDL-16407 Add to admin/settings/plugins.php to link to the new manage page, and pull in any qtype settings pages
MDL-16408 Write the manage question types page, to display the table of installed types
2008-09-09 08:43:40 +00:00
tjhunt 3843d2745e Whitespace and comment improvements. 2008-09-09 08:35:38 +00:00
tjhunt 40d1feeb49 MDL-15540 Navigation panel did not work on the review page for multi-page quizzes because of the way states were loaded. Fix the regressions caused by the previous refactor. 2008-09-04 07:05:14 +00:00
tjhunt 81d833adaa MDL-15540 Navigation panel did not work on the review page for multi-page quizzes because of the way states were loaded. Refactor. 2008-09-04 06:37:43 +00:00
tjhunt f62040ed1f MDL-16263 Flagging questions during a quiz attempt. Save flag state on the review page when JS is off too. 2008-09-03 08:32:29 +00:00
tjhunt 5e9170b43e MDL-16263 Flagging questions during a quiz attempt. Save flag state on submit when JS is off. 2008-09-03 07:11:59 +00:00
tjhunt a282ef514e MDL-16263 Flagging questions during a quiz attempt. IE cannot cope with an object initialiser with a trailing comma, so change how thise JS is output. 2008-09-03 05:37:46 +00:00
scyrma 2a68c5d9b9 MDL-16318: remove a few calls use_html_editor() (more to come) 2008-09-03 03:09:56 +00:00
tjhunt 630a3dc384 MDL-14160 SQL in get_categories_for_contexts does not work on Oracle. Thanks to Adrian Smith and Francois Marier for the fix. 2008-09-02 06:55:32 +00:00
tjhunt 62e76c6766 MDL-16263 A way for students to flag/bookmark, particular questions during a quiz attempt for later review.
This is an initial implementation that is now at a working state, but with a few things left to do. It seemed like a good idea to commit it before leaving work on Friday night.
2008-08-29 10:08:27 +00:00
tjhunt e1dc480c8c MDL-16219 - followup - committing missing change in questionlib.php in head. 2008-08-29 03:34:44 +00:00
tjhunt f88fb62c40 MDL-10682 - Ensure quiz and question grades are formatted consisently and correctly. While testing, I also fixed a few XHTML Strrrict errors. 2008-08-15 06:42:38 +00:00
tjhunt c49f8af39b Whitespace 2008-07-30 10:18:25 +00:00
jamiesensei 43ec99aa74 MDL-15268 "Content for Quiz Statistics report table" further work on quiz statistics report. 2008-07-30 09:02:44 +00:00
tjhunt 4089d9ec52 MDL-15537 - followup - don't display an error if you ask questionlib.php to load an empty list of questions. 2008-07-25 14:18:02 +00:00
tjhunt bbf795dfde MDL-15792 - Images in question don't display. This is a regression from MDL-14279. Fix thanks to Yolanda Ord?ez Rufat. 2008-07-23 10:32:35 +00:00
jamiesensei 4f5ffac022 MDL-15268 "Content for Quiz Statistics report table" seperated quiz item / position stats code into a seperate class in qstats.php and now calculating item statistics too. 2008-07-18 14:36:24 +00:00
tjhunt b9d4b03134 MDL-15693 - print_question_icon does not cope with missing question types 2008-07-17 12:49:25 +00:00
tjhunt b55797b8cc MDL-15452 - Put the OU quiz navigation improvements into the Moodle codebase. I was able to factor out some commonalities with review.php along the way. 2008-07-15 15:30:39 +00:00
jamiesensei 98f38217bb MDL-14216 "Improvements to regrade report - improved reporting of actions and dry run / regrade" 2008-07-11 07:27:14 +00:00
scyrma 5a254a2938 MDL-14279: use get_file_url instead of checking $CFG->slashargument manually (merge from 1.9) 2008-07-10 09:55:11 +00:00
tjhunt 66d07f81a1 MDL-15538 - Rework attempt.php to use attemptlib.php - I had broken processing of submitted responses. Hopefully it is fixed again now. 2008-07-08 18:22:18 +00:00
tjhunt 78e7a3dd5d MDL-15452 - Put the OU quiz navigation improvements into the Moodle codebase - quite a lot of progress, sorry I am committing this as a big lump, but it took me a while to get the code back to a working state.
MDL-15537 - create oo attemptlib.php to hold shared code between attempt, summary and review.php
MDL-15541 - Refactor starting a new attempt into a new file startattempt.php
MDL-15538 - Rework attempt.php to use attemptlib.php
2008-07-08 16:33:47 +00:00
tjhunt 373f0afd24 MDL-15494 - No allowance for the possibility that something might go wrong when processing the response to a question. 2008-07-01 13:34:09 +00:00
tjhunt b10c38a37b MDL-15452 - ongoing - Put the OU quiz navigation improvements into the Moodle codebase
* Javadoc comments for most of the code I committed on Friday.
* Implement the get_question_status method.
* Along the way, refactor duplicated logic between two of the question types, questionlib, and the new code - removing inconsistency while doing so.
2008-06-30 16:56:49 +00:00
jamiesensei 455c3efa13 MDL-14204 "Content for Quiz Statistics report table - Random_guess_score" oops ought to give that function name a 'question_' prefix 2008-06-16 13:59:30 +00:00
jamiesensei 6f51ed72be MDL-14204 "Content for Quiz Statistics report table - Random_guess_score" added method random_guess_score to question type objects and a new function in questionlib that calls the question type method. 2008-06-16 13:29:00 +00:00
thepurpleblob 7ba71c513b MDL-15228
The old 1.9 code ignored any multiple results so I guess this can do the
same.
2008-06-13 11:13:31 +00:00
nicolasconnault 415f8c3eeb CONTRIB-490 Fixed minor bugs uncovered by generator script 2008-06-12 12:55:13 +00:00
nicolasconnault b9bd6da4f8 CONTRIB-490 Added support for scripted generation of questions. Calculated type not yet supported (datasets too complicated ;) 2008-06-12 09:15:16 +00:00
skodak 294ce9870f MDL-15189 magic quotes finally removed 2008-06-09 16:53:30 +00:00
skodak eb84a826d5 MDL-15102 dml converted questionlib 2008-06-09 12:16:54 +00:00
skodak 1c69b88529 MDL-14679 removed all instances of set_field_select() 2008-06-01 16:14:59 +00:00
skodak 534792cd82 MDL-14679 removed all instances of get_records_select_menu() 2008-06-01 15:52:12 +00:00