Commit Graph

104 Commits

Author SHA1 Message Date
jamiesensei 3efbe6bc89 MDL-14676 "In question bank, problem with moodle/question:edit* when do not have moodle/question:move*" Fixed logic for processing submission of question form and also added some validation to check that the user has permissions to move a question. 2008-10-08 10:27:38 +00:00
tjhunt c6106dd9b7 MDL-16720 The edit icon in the quiz preview screen pops up the edit form in a window that is too small 2008-09-28 08:59:50 +00:00
tjhunt ddf977898c Clean up code in a couple of places by using my print_js_call function. 2008-09-19 04:53:03 +00:00
jamiesensei 869309b8d8 MDL-14202 "Replace Item Analysis Report with new improved 'Statistics' report." finished statistics report. This patch includes some changes to lib/tablelib.php so that it is possible to export the content of a table as part of a multi table export - with mutliple tables / multiple worksheets. 2008-09-11 12:48:08 +00:00
tjhunt 770537257a MDL-16398 Remove the unused and unnecessary set_default_options method from the question type API 2008-09-09 01:50:30 +00:00
tjhunt d0dfe9491d MDL-16263 Flagging questions during a quiz attempt. Make it work nicely with just the keyboard, no mouse, if JavaScript is on. 2008-09-03 05:50:53 +00:00
tjhunt 62e76c6766 MDL-16263 A way for students to flag/bookmark, particular questions during a quiz attempt for later review.
This is an initial implementation that is now at a working state, but with a few things left to do. It seemed like a good idea to commit it before leaving work on Friday night.
2008-08-29 10:08:27 +00:00
tjhunt 21a4ca7d79 MDL-15654 Incorrect escaping of HTML in the history table on the review quiz attempt page. 2008-08-20 09:46:18 +00:00
tjhunt f9a2cf86a9 MDL-7308 - Check all the DB columns used to store grades, and make sure they all use a consistent type. 2008-08-15 11:15:08 +00:00
tjhunt f88fb62c40 MDL-10682 - Ensure quiz and question grades are formatted consisently and correctly. While testing, I also fixed a few XHTML Strrrict errors. 2008-08-15 06:42:38 +00:00
tjhunt 9f9eec1ef0 MDL-15542 - Refactor quiz response processing into a separate processresponses.php. 2008-07-15 16:46:24 +00:00
tjhunt b55797b8cc MDL-15452 - Put the OU quiz navigation improvements into the Moodle codebase. I was able to factor out some commonalities with review.php along the way. 2008-07-15 15:30:39 +00:00
tjhunt b10c38a37b MDL-15452 - ongoing - Put the OU quiz navigation improvements into the Moodle codebase
* Javadoc comments for most of the code I committed on Friday.
* Implement the get_question_status method.
* Along the way, refactor duplicated logic between two of the question types, questionlib, and the new code - removing inconsistency while doing so.
2008-06-30 16:56:49 +00:00
jamiesensei 455c3efa13 MDL-14204 "Content for Quiz Statistics report table - Random_guess_score" oops ought to give that function name a 'question_' prefix 2008-06-16 13:59:30 +00:00
jamiesensei 6f51ed72be MDL-14204 "Content for Quiz Statistics report table - Random_guess_score" added method random_guess_score to question type objects and a new function in questionlib that calls the question type method. 2008-06-16 13:29:00 +00:00
dongsheng bd8ee7c1c4 "MDL-14129, fix print_error" 2008-06-15 12:02:43 +00:00
nicolasconnault b9bd6da4f8 CONTRIB-490 Added support for scripted generation of questions. Calculated type not yet supported (datasets too complicated ;) 2008-06-12 09:15:16 +00:00
skodak 294ce9870f MDL-15189 magic quotes finally removed 2008-06-09 16:53:30 +00:00
nicolasconnault 9cf4a18b41 MDL-15113 Upgrade to DMLLIB 2.0. Needs further testing and bug-fixing.
MDL-15100 Fixed a bug in gradelib.php
Plus edited tablelib.php for table_sql upgrade to dmllib 2.0
2008-06-09 10:00:35 +00:00
nicolasconnault f34488b2e6 MDL-15102 Upgrade to DMLLIB 2.0. Needs further testing and bug-fixing. 2008-06-06 14:43:15 +00:00
skodak 44e1b7d7ff MDL-14679 remoed all instances of get_records_list() 2008-06-01 15:42:48 +00:00
jamiesensei 720be6f2c3 MDL-5241 "When manually grading, identity questions by their number within the quiz as well as by question name"
Also added a drop down box to select question to mark instead of the viewquestions table. The drop down box is available at the top of every page, but only if there is more than one manually gradeable question in the quiz. If there is only one question it is automatically selected for marking.

Also added a new constant QUESTION_EVENTS_GRADED during a general refactoring of UI code in grading report and some improvements to efficiency of SQL in report.

Merged from Moodle 1.9 branch
2008-05-26 11:39:51 +00:00
dongsheng 0b4f4187a2 "MDL-14129, fix print_error" 2008-05-21 05:07:37 +00:00
tjhunt a588d813cb MDL-14762 - find and update links to files in answer->feedback when moving questions between contexts. 2008-05-09 13:13:43 +00:00
dongsheng 5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
tjhunt 694061adf4 Fix dangerous comment. (MDL-13536) 2008-02-19 17:14:12 +00:00
tjhunt 8bb3fac17c MDL-13110 - Manually grading random questions does not work. Fix thanks to Ken Burres. 2008-01-30 18:18:36 +00:00
scyrma aa68a7b0a2 MDL-13020 : deprecates make_table 2008-01-16 08:17:25 +00:00
tjhunt 556be2831b MDL-12369 - get_actual_response should not truncate the student's response. Merged from MOODLE_19_STABLE. 2007-11-28 12:45:57 +00:00
tjhunt 75082bdd89 MDL-12286 - 'Save as new question' button ignores the setting in the 'Save in category' dropdown. Merged from MOODLE_19_STABLE. 2007-11-20 17:52:16 +00:00
jamiesensei cb14dd6316 modifiedby and timemodified is now set when a question is created as well as createdby and timecreated instead of being left as zero 2007-09-27 07:41:58 +00:00
tjhunt 411efaee25 MDL-5327 - When making up a default question name from the question text, strip any HTML tags. Merged from MOODLE_18_STABLE. 2007-09-27 06:54:17 +00:00
tjhunt f59dba8497 MDL-11398 - Random questions sometimes ended up with names different from the cateogry they were actually picking from. Also, the same random questoin could be used in more than one quiz, in which case editing that question would change two quizzes unexpectedly. The fix is:
* Don't let the user set the name for random questions.
* Instead force the name to be "Random (catname)" (localised) whever the question is created or saved.
* When a category is renamed, rename all the random questions in it.
* Remove the restriction that Jamie seems to have added in 1.9 that was preventing the category of random questions from being edited.
2007-09-26 16:10:38 +00:00
tjhunt b92ffdf9ac Whitespace cleanup. 2007-09-24 15:45:29 +00:00
tjhunt 80fdc53efd Related to MDL-10916 - saving Cloze questions in Moodle 1.9 generates Notices because of changes to questionstupe_base::save_question. 2007-09-24 14:18:47 +00:00
tjhunt c5ccb82c61 XHTML Strict in question state history table. Merged from MOODLE_18_STABLE. 2007-09-20 15:10:04 +00:00
tjhunt c767d3b7d3 MDL-11317 - Slashes displayed in incorrect responses for short answer questions. Fix by adding stripslashes in the appropriate place. Merged from MOODLE_18_STABLE. 2007-09-18 12:15:22 +00:00
tjhunt ace1bf9d8e MDL-11284 - Can't save edited questions 2007-09-14 09:33:30 +00:00
jamiesensei ffba1f0bec added some comments 2007-08-16 05:20:35 +00:00
jamiesensei e7e62d45be Fix for MDL-10823 Access to question edit page denied from quiz preview screen. 2007-08-14 04:22:05 +00:00
tjhunt ceeae340f9 MDL-10799 - Question types do not accurately determine whether their state has changed or not. Merged from MOODLE_18_STABLE. 2007-08-10 15:21:29 +00:00
jamiesensei 271e6decda merging MOODLE_19_QUESTIONS with HEAD 2007-08-09 21:51:09 +00:00
tjhunt e3fa6587ee Helper method to help when calling print_error from a question type. 2007-08-09 15:38:35 +00:00
tjhunt 215bd82630 Fix typo. Thanks to Adriane Boyd. 2007-08-09 09:00:30 +00:00
tjhunt 3d3867b69a MDL-10730 - After submitting a question in adaptive mode, go back to that question, not the top of the page. Code thanks to Tony Gardner-Medwin, based on my suggestion. 2007-08-06 14:10:46 +00:00
tjhunt 5fceb049cc Use of get_html_head_contributions was causing unwanted interaction bewteen question types. Switched to using a class variable. 2007-07-30 17:04:46 +00:00
tjhunt ca9000df6f Fix typo in a comment. 2007-06-19 16:33:16 +00:00
tjhunt 6e9debfbf1 Removing remaining references to RQP in core code. I had not realised there were so many. By the way, I am committing this from a pub in York. Pub's with wireless, whatever next? 2007-05-24 17:25:37 +00:00
jamiesensei 9ab75b2bcc passing cmid to question.php and removed use of session modform var. Question.php now independent of quiz module. Small improvement to displayed breadcrumbs. 2007-05-04 05:47:59 +00:00
tjhunt 27987cbb78 Eliminate support for old-style question editing forms. 2007-04-25 18:20:04 +00:00