Commit Graph

557 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7) 862f48225d Merge branch 'MDL-19263-21' of https://github.com/mackensen/moodle into MOODLE_21_STABLE 2012-04-26 02:59:35 +02:00
Eloy Lafuente (stronk7) 19cc130565 MDL-32490 Offline assignment: phpdocs and whitespace fixes 2012-04-25 02:42:12 +02:00
Henning Bostelmann 72d890d2d2 MDL-32490 Offline assignment: do not display lateness information 2012-04-25 02:42:04 +02:00
Charles Fulton 4ef25d16cb MDL-19263 assignment: only notify users enrolled in course 2012-04-20 06:16:15 -07:00
Sam Hemelryk fad527952b Revert "MDL-30843 and MDL-30842 - accessibility compliance: Add <label> for form input text and select tag"
This reverts commit 0add004b0e.
2012-04-11 17:20:49 +12:00
Rossiani Wijaya 0add004b0e MDL-30843 and MDL-30842 - accessibility compliance: Add <label> for form input text and select tag 2012-03-30 17:13:50 +08:00
Ruslan Kabalin 0b50793e41 MDL-31917 Improve assigment submission usability
Say 'View' if assignment has been graded via gradebook and changing
grades via submissions interface is not possible.
2012-03-13 14:05:13 +13:00
Ruslan Kabalin 08fb6ca3f1 MDL-31919 Fix assignment overview output to respect gradebook grading.
Currenly, if assigment has been graded in gradebook only, in the assigment
overview it is listed as not graded.
2012-03-13 14:01:00 +13:00
Sam Hemelryk c7b23475a5 MDL-30724 mod_assignment: Minor fixes during integration 2012-03-05 16:09:35 +13:00
Gerard (Gerry) Caulfield 9af65cb3ac MDL-30724 Limit assignment_count_real_submissions() to only select real
submissions

I've also refactored some code so that it is more structured and allows
for easier overriding of function associated with counting submissions
and updated associated doc blocks.
2012-02-27 12:30:37 +08:00
Gerard (Gerry) Caulfield d773f373ef MDL-30957 Adding a new method "is_complete" to assignment lib for
testing if a submission has actually been submitted and then adding a
call to it before displaying the the assignment submission date header

As recommended I've simplified the functions and split the logic out into appropriate upload classes.
2012-02-20 11:37:51 +08:00
Sam Hemelryk 042e24f146 MDL-30709 mod_assignment: Renamed callback to mod_assignment_get_file_info 2012-02-15 11:27:05 +13:00
Sam Hemelryk 5e87e0e6e4 MDL-30709 mod_assignment Fixed phpdocs for assignment_get_file_info 2012-02-14 17:16:32 +13:00
Marina Glancy 42711a4d6a MDL-30709: Fixed bug with inserting files from Recent files repository
Two parts of changes: in assignment module function assignment_get_file_info was missing
and when populating the list of recent files the function get_file_info was not called, which caused populating the list of recent files with the files that could not later be inserted
2012-02-09 13:59:10 +08:00
Henning Bostelmann 1627ecfdbc MDL-29266 Assignment grading: save state of "send notifications" box 2012-01-03 11:09:54 +13:00
Andrew Robert Nicols 6298e8d646 MDL-30350 Highlight late submissions in the submission overview page 2011-12-08 14:28:12 +08:00
Andrew Robert Nicols 2f14dd463b MDL-30174 Assignment : Only increment submission offset if the current assignment was not saved 2011-11-22 02:21:34 +08:00
Andrew Robert Nicols 12216d31ff MDL-30173 Assignment : Convert to use moodle_url and add missing filter param 2011-11-22 02:04:46 +08:00
Eloy Lafuente (stronk7) c35c8eb8e6 Merge branch 'mdl-29529-assignment-submission-sorting-m21-2' of git://github.com/sbourget/moodle into MOODLE_21_STABLE 2011-11-11 01:18:58 +01:00
Stephen Bourget 4aef860aec MDL-29529 Assignment: Fix regression caused by MDL-27638 2011-11-10 17:08:43 -05:00
Mark Nielsen c8972b9909 MDL-30059: Assignment Submission Notification Should Use Teacher's Timezone Rather Than Server Time 2011-11-07 13:37:30 +08:00
Henning Bostelmann 716267f233 MDL-29810 Assignment grading: don't include teachers in list of students 2011-10-27 22:19:15 +01:00
Eloy Lafuente (stronk7) 63526ae3d5 MDL-29564 Assignment: whitespace fix 2011-10-10 13:10:07 +02:00
Sam Hemelryk 430ce6cca3 Merge branch 'mdl-29564-assignment-plagiarism' of git://github.com/sbourget/moodle into MOODLE_21_STABLE 2011-10-10 11:51:08 +13:00
Stephen Bourget b801633a9c MDL-29564 Assignment: Fixed a fatal error caused by a missing include 2011-10-04 13:44:59 -04:00
David Mudrak 59c8be2362 MDL-27857 Export to portfolio support in the assignment module improved
Portfolio API code in the assignment module expected that the current
user is the author of the submission. Therefore the "Export to
portfolio" button did not work when the submission was viewed by a
teacher (eg at the page with the list of all submissions in the Advanced
upload assignment).

This patch introduces a new callback argument 'submissionid' that holds
explicit ID of the submission the export deals with. With it available,
we do not need to expect the current user is the author of the
submission.

The patch also cleans some strings used for portfolio callback
exceptions.
2011-10-03 10:13:11 +02:00
David Mudrak daf4471a40 MDL-27857 Assignment does not use form tag to render portfolio export control widget
When this code was used as a part of the grading screen, the default
PORTFOLIO_ADD_FULL_FORM widget led to nested form elements. This patch replaces
the form widget with a plain text link that can be embedded safely.
2011-10-03 10:13:10 +02:00
Sam Hemelryk b3c64930ff MDL-29189 course Minor fixups after code review 2011-09-13 11:19:17 +12:00
Sam Hemelryk 34c46428f1 MDL-29189 mutlilang Reviewed the uses of course shortname and ensured things are being formatted consistently 2011-09-08 09:30:10 +12:00
Henning Bostelmann b1a24c1eb0 MDL-25872 View assignment submissions: show only students, not teachers
Fixing incorrect capability reference mod/assignment:view to ...:submit
2011-08-26 17:34:35 +01:00
Rajesh Taneja b51aac313f MDL-27896 context - Fixed editor context to observe filter status 2011-08-12 16:48:22 +08:00
Rossiani Wijaya 35ef97232c MDL-27555 assignment module: remove 'submitted' option from optional setting for offline assignment type. 2011-07-13 15:32:21 +08:00
Eloy Lafuente (stronk7) 282a0a713e Merge branch 'MDL-28087_friendly_jabber' of git://github.com/andyjdavis/moodle 2011-06-29 20:11:17 +02:00
Sam Hemelryk f86e19b1ee Merge branch 'MDL-27829_block_pagetype_master' of git://github.com/andyjdavis/moodle 2011-06-29 17:04:13 +08:00
Andrew Davis (andyjdavis) 5daa7279d4 MDL-28087 assignment: made the jabber notification of assignment grading better 2011-06-29 11:29:11 +08:00
Eloy Lafuente (stronk7) cddb428722 Merge branch 'MDL-27990_assignment_notifications' of git://github.com/andyjdavis/moodle 2011-06-28 22:14:54 +02:00
Andrew Davis (andyjdavis) 83dfca3fa3 MDL-27990 assignment: removed a redundant retrieval of a user preference 2011-06-28 11:08:59 +08:00
Andrew Davis (andyjdavis) b38e2e28a1 MDL-27829 blocks: altered the algorithm used to find plugin page types 2011-06-27 12:27:41 +08:00
Andrew Davis (andyjdavis) 0f1751b01b MDL-28023_assignment_jabber assignment: added context url to improve the jabber notifications 2011-06-27 11:08:21 +08:00
Andrew Davis (andyjdavis) fa09b5a9a3 MDL-28023 assignment: assignment wasnt supplying all the data necessary to produce a meaningful jabber notification 2011-06-25 13:12:48 +08:00
Andrew Davis (andyjdavis) be34802d23 MDL-27990 assignment: Some small modifications to the assignment notification code
AMOS BEGIN
 MOV [enableemailnotification,mod_assignment],[enablenotification,mod_assignment]
 MOV [enableemailnotification_help,mod_assignment],[enablenotification_help,mod_assignment]
AMOS END
2011-06-24 14:19:40 +08:00
Eloy Lafuente (stronk7) 6057bf5b05 MDL-27810 portfolio: Added ->portfolioenabled check to one more place 2011-06-22 02:10:11 +02:00
Sam Hemelryk 6708a1f525 MDL-27810 portfolio: Added ->portfolioenabled checks before creating portfolio buttons to avoid initialising portfolio requirements 2011-06-21 10:35:53 +08:00
Sam Hemelryk 46d3b9be73 Merged branch 's7_MDL-26105_block_settings_master' git://github.com/andyjdavis/moodle.git with changes 2011-06-13 16:54:52 +08:00
Marina Glancy 13b3f4d4af MDL-26430 fixed appearance of one html form within another 2011-06-10 12:55:12 +08:00
Dongsheng Cai b1627a92e5 MDL-26105 Block settings should contains less options, and be more user friendly
AMOS BEGIN
    MOV [page-blog-index, pagetype], [page-blog-index, blog]
    MOV [page-blog-x, pagetype], [page-blog-x, blog]
    MOV [page-tag-x, pagetype], [page-tag-x, tag]
    MOV [page-course-view-weeks, pagetype], [page-course-view-weeks, format_weeks]
    MOV [page-course-view-weeks-x, pagetype], [page-course-view-weeks-x, format_weeks]
    MOV [page-course-view-topics, pagetype], [page-course-view-topics, format_topics]
    MOV [page-course-view-topics-x, pagetype], [page-course-view-topics-x, format_topics]
AMOS END
2011-06-09 13:51:14 +08:00
Sam Hemelryk e455bdb3d7 MDL-27638 Removed buggy status line from query as it is being calculated in php anyway 2011-05-31 17:02:17 +08:00
Sam Hemelryk 2b04c41c58 MDL-27471 Adding mandatory component & ratingarea to the ratings API + other fixes
* Added the component and ratingarea fields and implemented it throughout
  the rating API as mandatory fields
* Cleanup rating indexes
* Upgrade forum/data/glossary ratings
* Moved the logic in the render_rating method to methods of the rating object.
* Added new callback for checking ratingareas
* Cleaned comments here and there
* Mark the xxx_get_participants methods as deprecated
* Refactor rate_ajax and ratingsuser_can_view_aggregate methods
* Cleaned up rating/index.php to use html_table object and moved inline styles to CSS.
* Added missing properties of the rating object that were being set throughout the rating
  API.
2011-05-23 12:35:39 +02:00
Sam Hemelryk 870b8b0402 Merge branch 'MDL-27161_head' of git://github.com/rwijaya/moodle.git 2011-05-16 12:28:18 +08:00
Rossiani Wijaya e512715b89 MDL-27161: fixed optional setting for 'require grading' to prevent page lock out (head) 2011-05-12 17:32:00 +08:00