Commit Graph

2070 Commits

Author SHA1 Message Date
David Monllao 72621d23ae Merge branch 'MDL-62347-master' of git://github.com/bmbrands/moodle 2018-09-04 14:05:41 +02:00
David Mudrák 39d2c68856 MDL-61742 messaging: Do not send messages from inactive providers
Before this patch, we only checked that the given provider has been
configured in the user or system preferences. However, if the provider's
component is disabled, it does not even appear in these preferences.
Additionally, there was no check that the message / notification
provider is among providers allowed to be consumed by the recipient.

The patch checks that the message origin is among providers returned by
the message_get_providers_for_user() so disabled plugins can't act as
sources of messages and users can't receive messages from providers they
do not have capability for. This mitigates the risk of abusing a plugin
as a source of spam, for example.

Unit test is fixed and extended. When the $CFG->messaging is disabled,
no messages between users should be sent (I can't understand why the
unit test was written in an opposite way). Added assertions for the
raised debugging message.
2018-08-31 12:15:30 +02:00
Andrew Nicols e36019c2f3 Merge branch 'wip-MDL-62742-master' of git://github.com/marinaglancy/moodle 2018-08-29 08:31:08 +08:00
Marina Glancy 442f12f81a MDL-62742 core: rename coursecat->core_course_category
Also rename course_in_list -> core_course_list_element
Deprecate class coursecat_sortable_records
2018-08-28 11:36:23 +02:00
John Beedell d0a60444a1 MDL-63165 Question: xml import of question categories 2018-08-24 15:20:18 +01:00
Jake Dallimore 805ce3de79 Merge branch 'MDL-36255-master' of https://github.com/lucaboesch/moodle 2018-08-21 16:04:17 +08:00
Víctor Déniz Falcón 02fda279ed MDL-57281 behat: deprecated step definition I navigate to node in
Definition step deprecated and affected tests modified.
2018-08-20 12:53:26 +01:00
Luca Bösch 8ad225b431 MDL-36255 grades: allow multilang filters in grades 2018-08-20 08:29:36 +02:00
Andrew Nicols 883f655552 MDL-36754 output: Support token pluginfiles in group pic 2018-08-14 07:06:09 +08:00
Andrew Nicols 8af75f08e8 MDL-36754 tests: Move moodle_url tests to own file 2018-08-14 07:06:09 +08:00
Andrew Nicols 91f1f28233 MDL-36754 core_files: Support tokens when rewriting text
Support use of a token for access to pluginfile.php when rewriting text
content.

This is primarily intended for notifications where the user is unlikely
to be logged into Moodle when receiving the notification.
2018-08-14 06:57:32 +08:00
Bas Brands 4f9d62835a MDL-62347 course: pagination phpunit updates 2018-08-13 13:45:33 +02:00
Jun Pataleta 2454ddb6ef Merge branch 'MDL-45170-master' of git://github.com/junpataleta/moodle 2018-08-08 16:27:55 +08:00
Jun Pataleta c353ad20c3 MDL-45170 core: Integration review fixes
* Pass $forcehttps parameter to call extract_draft_file_urls_from_text()
 call in \core_weblib_testcase::test_extract_draft_file_urls_from_text()
* Style fixes
2018-08-08 16:17:32 +08:00
Charles Fulton 7d7d3b1731 MDL-45170 files: check other draftfile areas when processing 2018-08-08 16:15:23 +08:00
Andrew Nicols 0c759ba614 Merge branch 'MDL-56335-master' of git://github.com/mihailges/moodle 2018-08-08 13:14:00 +08:00
Mihail Geshoski 216b89475d MDL-54741 general: 3.2 final deprecation in lib/deprecatedlib.php 2018-08-06 09:29:54 +08:00
Mihail Geshoski f2cdf99382 MDL-56335 behat: prefixed_tablenode_transformations final deprecation 2018-08-06 09:27:08 +08:00
Andrew Nicols aa75f70280 Merge branch 'MDL-59847-master' of https://github.com/snake/moodle 2018-08-02 11:39:50 +08:00
Eloy Lafuente (stronk7) c965349aad Merge branch 'MDL-59595-master-2' of git://github.com/snake/moodle 2018-08-02 00:21:23 +02:00
Eloy Lafuente (stronk7) 1ffa22bbc7 Merge branch 'MDL-61041-master' of git://github.com/damyon/moodle 2018-08-01 16:36:12 +02:00
Jun Pataleta 77b6d458e5 Merge branch 'MDL-58768-master-2' of git://github.com/rezaies/moodle 2018-07-31 16:18:44 +08:00
David Monllao a50b8a438a Merge branch 'MDL-56712-master' of git://github.com/mihailges/moodle 2018-07-30 17:47:51 +02:00
David Monllao 627d9aa6c8 Merge branch 'MDL-55188-master' of git://github.com/abgreeve/moodle 2018-07-30 17:33:21 +02:00
Mark Nelson 8bfe908209 MDL-63002 core: fixed incorrect calls to non-existent delete_record() 2018-07-30 20:59:42 +08:00
Mihail Geshoski d77b5db55f MDL-56712 media: Remove 3.2 deprecated functions and classes 2018-07-30 09:25:34 +08:00
Adrian Greeve b41e1d7c55 MDL-55188 events: Final deprecation of part of events 1 API. 2018-07-30 09:25:06 +08:00
Adrian Greeve 5454e72c21 MDL-55188 events: First deprecation of eventslib.php 2018-07-30 09:23:54 +08:00
cescobedo 2769bf315b MDL-55188 events: Final deprecation events_trigger. 2018-07-30 09:21:21 +08:00
Shamim Rezaie f7115c2e80 MDL-58768 coursecat: coursecat::get to accept a $user parameter 2018-07-28 07:51:32 +10:00
David Mudrák 6808227b1f MDL-59847 core: Fix display of hidden identity fields in user lists
Places that display list of users (such as course participants page)
with additional identifier fields now respect the user's permission to
view other users' hidden profile fields.
2018-07-27 09:55:22 +02:00
Eloy Lafuente (stronk7) b562240b61 Merge branch 'MDL-57622-master' of git://github.com/mihailges/moodle 2018-07-26 00:22:37 +02:00
Damyon Wiese 3412b12c22 MDL-61041 assign: Remove assignment 2.2 upgrader 2018-07-25 14:11:10 +08:00
Andrew Nicols 5ecca25603 Merge branch 'MDL-62897-master' of git://github.com/rezaies/moodle 2018-07-25 12:42:31 +08:00
Andrew Nicols 834054ee06 Merge branch 'MDL-60826-master' of git://github.com/lameze/moodle 2018-07-25 09:18:53 +08:00
Eloy Lafuente (stronk7) e3f3c41252 Merge branch 'MDL-62653-master' of git://github.com/andrewnicols/moodle 2018-07-25 00:37:05 +02:00
Jake Dallimore dbf66238b7 MDL-59595 admin: unit test covering the adminroot cache reset scenario
The adminroot cache should be reset when the current user is changed,
which can occur during cron or during unit tests.
2018-07-24 08:25:30 +08:00
Simey Lameze e2b7dca006 MDL-60826 groups: deprecate groups_get_all_groups_for_courses function 2018-07-24 07:58:35 +08:00
Mihail Geshoski 10bd37fabd MDL-54742 general: Remove strings deprecated in 3.2 2018-07-23 14:25:14 +08:00
Shamim Rezaie 94fe904ed6 MDL-62897 Questions: Fix multi top cats in question_save_from_deletion 2018-07-23 14:37:40 +10:00
Mihail Geshoski 5f2628c517 MDL-57622 behat: Remove behat steps deprecated in 3.2 2018-07-23 09:25:59 +08:00
Adrian Greeve f38766e166 MDL-62849 files lib: Add method to return all files.
Added a function which returns all the files from all directories
in the draftarea.
2018-07-17 10:25:11 +08:00
Andrew Nicols df95c479fc MDL-62653 behat: Ensure that tasks run properly from behat 2018-07-13 13:54:42 +08:00
Andrew Nicols 481548f580 MDL-62834 behat: Move include to function 2018-07-04 10:29:15 +08:00
Eloy Lafuente (stronk7) c475c97b45 Merge branch 'MDL-62838' of git://github.com/timhunt/moodle 2018-07-04 00:49:23 +02:00
Tim Hunt 1146659db4 MDL-62838 filters: dont use statics inside functions. Use MUC 2018-06-29 17:24:41 +01:00
Tim Hunt 8aedf6d478 MDL-62834 behat: new step for enabling filters 2018-06-29 11:26:41 +01:00
Eloy Lafuente (stronk7) 8f63202014 Merge branch 'MDL-62747' of https://github.com/timhunt/moodle 2018-06-28 00:30:38 +02:00
Juan Pablo de Castro 6aa8a3b6d0 MDL-14274 lib/evalmath: support of conditional math in formulas.
- Comparison operators >, ==, <, <=, >=
- "if(condition, valueiftrue, valueif false)" function.

(amended to keep non-related lines unmodified - whitespace & indent)
2018-06-26 10:25:44 +02:00
Tim Hunt a1bc8928cc MDL-62747 accesslib: rdef caching should handle roles with no caps 2018-06-19 16:26:00 +01:00