f6711bb394
MDL-67673 phpunit: Fix the return type of template methods
...
All the setup/teardown/pre/post/conditions template methods
now are required to return void. This was warned with phpunit 7
and now is enforced.
At the same time, fix a few wrong function names,
provider data and param types, return statements...
2020-10-21 12:45:59 +02:00
2356454f21
MDL-60680 notifications: Include action buttons information
2019-04-25 14:55:57 +02:00
36fa0ec900
MDL-60680 notifications: Return custom data in notifications
2019-04-25 14:55:18 +02:00
c96c9601af
MDL-62947 mod_feedback: fix feedback so it correctly uses forms API
...
Feedback code was doing the following, which is incompatible with the
sec-patched quickforms lib:
- appending '[0]' to non-group element names, meaning type checks in
getCleanType() were falling back to PARAM_RAW instead of PARAM_INT,
and meaning _findValue() was comparing elements it thought to be arrays
with scalar submit values (worked with eval() implementation as the 0th
element of a string was the character, but not working when patched).
- external unit tests incorrectly testing multichoice questions in the
process_page tests - patched lib highlighted failures.
It was also doing the following:
- actively setting null as default element values instead of 0 for
radio buttons and dropdowns (for 'not selected'). This is incompatible
with more recent quickforms lib (see MDL-63070).
- creating groups using addElement instead of addGroup - not recommended
This patch addresses the above.
2018-09-05 12:12:20 +08:00
f39d43af41
MDL-60578 mod_feedback: Handle correctly site feedbacks
2018-09-04 14:18:41 +02:00
38fefb5cdf
MDL-60578 mod_feedback: pass courseid to WS
2018-09-04 14:18:39 +02:00
796e48a58b
MDL-60611 phpunit: remove deprecated stuff and other minor fixes
...
Thanks @scara for MDL-60611 phpunit: improved redis skipping reasons
2017-11-05 01:45:04 +01:00
d8f9177462
Merge branch 'MDL-58412-master' of git://github.com/jleyva/moodle
2017-04-20 09:56:10 +08:00
cadae8dce6
MDL-58412 mod_feedback: Use constant for anonymous feedback
...
We were using hardcoded values instead the correct constant
FEEDBACK_ANONYMOUS_NO
2017-04-19 11:37:15 +02:00
ad02561c15
Merge branch 'MDL-58453-master' of git://github.com/jleyva/moodle
2017-04-11 16:47:29 +02:00
7f700290b2
MDL-58453 mod_feedback: Add missing security checks
...
Some checks done in mod/feedback/show_nonrespondents.php were missing.
- Check for anonymous feedback
- Check for real courses (not site home)
2017-04-11 09:42:27 +01:00
b140b13c25
Merge branch 'MDL-58453-master' of git://github.com/jleyva/moodle
2017-04-10 11:23:37 +08:00
94478c083d
MDL-57813 mod_feedback: New WS mod_feedback_get_last_completed
2017-04-06 09:40:26 +02:00
682aea9b84
MDL-58453 mod_feedback: Refactor get_non_respondents WS
...
We should return more information like if the user started or not the
feedback and the total number of non respondents (to be able to
paginate).
2017-04-05 09:28:29 +02:00
a24289f12f
MDL-57821 mod_feedback: New WS mod_feedback_get_responses_analysis
2017-04-04 12:01:23 +02:00
bb66bc4a89
MDL-57822 mod_feedback: New WS mod_feedback_get_non_respondents
2017-03-28 22:52:03 +02:00
52f57996f4
MDL-58230 mod_feedback: New WS mod_feedback_get_finished_responses
2017-03-28 22:50:36 +02:00
ac9f0a6800
MDL-58229 mod_feedback: New WS get_unfinished_responses
2017-03-21 13:21:32 +01:00
82b2cd7d19
MDL-57820 mod_feedback: New WS mod_feedback_get_analysis
2017-03-21 13:12:35 +01:00
82a7a67869
MDL-57818 mod_feedback: New WS mod_feedback_process_page
2017-03-21 12:25:32 +01:00
74975948e5
MDL-57817 mod_feedback: New WS mod_feedback_get_page_items
2017-03-21 11:33:55 +01:00
951ddedf6f
MDL-57816 mod_feedback: New WS mod_feedback_launch_feedback
2017-03-21 11:22:13 +01:00
bb676b74fe
MDL-57815 mod_feedback: New Web Service mod_feedback_get_items
2017-03-16 15:35:06 +01:00
b315d721d9
MDL-57814 mod_feedback: New WS mod_feedback_get_current_completed_tmp
2017-03-15 15:31:38 +01:00
0f3c09979f
MDL-57811 mod_feedback: New Web Service mod_feedback_view_feedback
2017-03-15 15:25:00 +01:00
3f62cbd33e
MDL-57812 mod_feedback: New WS get_feedback_access_information
2017-03-15 15:23:24 +01:00
1f7734931f
MDL-50538 mod_feedback: New WS mod_feedback_get_feedbacks_by_courses
2017-03-14 15:54:26 +01:00
Eloy Lafuente (stronk7)