Commit Graph

1060 Commits

Author SHA1 Message Date
Paul Holden d1b1b94fb4 MDL-71306 cohort: ignore empty values in form autocomplete element. 2021-10-04 21:09:56 +01:00
Paul Holden cf99ea1a46 MDL-72462 forms: style checkbox/radio field labels consistently.
Fixes small regression from 942dc9de that moved indentation of form
fields to the label node, but only for those labels with specific
class.
2021-09-27 18:23:51 +01:00
Eloy Lafuente (stronk7) 433212a33e Merge branch 'MDL-72093-master' of git://github.com/mihailges/moodle 2021-09-16 00:32:47 +02:00
Jake Dallimore f91529bed3 Merge branch 'MDL-71137-master' of https://github.com/NashTechOpenUniversity/moodle 2021-09-15 10:11:48 +08:00
Mihail Geshoski 7d821080f0 MDL-72093 navigation: Update behat tests 2021-09-14 12:02:35 +08:00
Thong Bui 3972964e45 MDL-71137 File upload: progress bar issues display when D&D multi files 2021-09-06 14:11:03 +07:00
Guillermo Gomez fb10b36c04 MDL-71585 qbank_managecategories: Add managecategories to core
This implementation will introduce a qbank plugin "managecategories"
which will add the question categories feature in the question bank view
by replacing the core classes. Having this plugin will give users
the flexibility of enabling or disabling the category tab.
2021-09-03 09:41:18 +10:00
Thach Le Huy b3be2bbb67 MDL-71814 Atto: File picker – file info panel focus issue 2021-08-16 16:52:08 +07:00
Víctor Déniz 21909b59fb Merge branch 'MDL-69918-master' of git://github.com/andrewnicols/moodle 2021-08-10 19:15:22 +01:00
Andrew Nicols 530322e2ce MDL-69918 core: Update uses of legacy form change checker 2021-08-10 23:54:01 +08:00
Andrew Nicols cbe19158e9 MDL-69918 core: Rewrite Form Change Checker a ES6 2021-08-10 23:54:01 +08:00
Andrew Nicols 776f4bd80c MDL-72179 behat: Make use of page resolvers 2021-07-26 15:14:28 +08:00
Andrew Nicols c204fe3eeb MDL-72179 behat: Lowercase all page instance resolvers 2021-07-23 20:43:48 +08:00
Andrew Nicols 44cde6766b Merge branch 'MDL-71176-master_password_autocomplete' of https://github.com/safatshahin/moodle 2021-07-01 10:08:04 +02:00
Safat Shahin bc76ab4742 MDL-71176 login: Add html5 autocomplete attributes
This implementation will include the correct
autocomplete attribute value so that the password
managers can aid in creating good secure passwords
and not get confused with other autocomplete types.
There are some changes the password type form so
that autocomplete attribute can be passed an array.
2021-07-01 12:38:11 +10:00
Eloy Lafuente (stronk7) 4242216e86 Merge branch 'MDL-71947-master' of https://github.com/bmbrands/moodle 2021-06-29 11:39:26 +02:00
Bas Brands 11288e1598 MDL-71947 theme_boost: fix styles for vertical forms 2021-06-24 12:30:02 +02:00
Andrew Nicols 4f422785c6 MDL-71113 javascript: Improve basic JS Documentation 2021-06-18 09:38:05 +08:00
Andrew Nicols 92179b7057 MDL-71113 js: Fix all jsdoc warnings 2021-06-18 09:38:05 +08:00
Sujith Haridasan f11be42fae MDL-68915 core_form: Fix the behat test failure
Fix the behat test failure for the forums when
grades exist.

Signed-off-by: Sujith Haridasan <sujith@moodle.com>
2021-06-10 15:05:42 +08:00
Sujith Haridasan 25ea1f8e64 MDL-68915 lesson: Do not allow maxgrade change
Do not allow maxgrade change when some of the
users are already graded. As of now this is applicable
to the following activities:
1. Forum
2. Database
3. Lesson
4. Glossary

Signed-off-by: Sujith Haridasan <sujith@moodle.com>
2021-06-10 08:30:39 +05:30
abgreeve ef1d17c8ba Merge branch 'MDL-71644-master' of https://github.com/NashTechOpenUniversity/moodle 2021-06-03 09:40:43 +08:00
Andrew Nicols 1a9d53d831 MDL-70990 core_form: Replace FORM_ERROR event
The legacy M.core.event.FORM_ERROR event has been replaced with a new
core_form/events::formError native DOM event.

The new event can be listened to at any point in the DOM using the
following syntax:

```
import {eventTypes} from 'core_form/events';

document.addEventListener(eventTypes.formError, handler);
```

A backward-compatabibility layer is included to ensure that any legacy
YUI event listener is still called with the same arguments.

This legacy bridges will be removed after Moodle 4.3.
2021-05-26 10:47:17 +08:00
Andrew Nicols a1ccefe2ac MDL-70990 core_form: Standardise event name usage
The `types` object introduced in Moodle 3.11 has been replaced with the
`eventTypes` object which is used consistently across all CustomEvent
definitinos.

Likewise the trigger functions have been renamed from
`triggerUploadStarted` to `notifyUploadStarted` and from
`triggerUploadCompleted` to `notifyUploadCompleted`.

Backwards compatability is maintained.
2021-05-26 10:46:52 +08:00
Andrew Nicols 919db49a44 MDL-70990 core_form: Replace FORM_FIELD_VALIDATION event
The legacy core/event::FORM_FIELD_VALIDATION event has been replaced with a
new core_form/events::formFieldValidationFailed native DOM event.

The new event can be listened to at any point in the DOM using the
following syntax:

```
import {eventTypes} from 'core_form/events';

document.addEventListener(eventTypes.formFieldValidationFailed, handler);
```

A backward-compatabibility layer is included to ensure that any legacy
jQuery event is still called with the same arguments.

This legacy bridge will be removed after Moodle 4.3.
2021-05-26 10:46:52 +08:00
Andrew Nicols acd9d9823b MDL-70990 core_form: Replace FORM_SUBMIT_AJAX event
The legacy M.core.event.FORM_SUBMIT_AJAX ecent has been replaced with a
new core_form/events::formSubmittedByJavascript native DOM event.

The new event can be listened to at any point in the DOM using the
following syntax:

```
import {eventTypes} from 'core_form/events';

document.addEventListener(eventTypes.formSubmittedByJavascript, handler);
```

A backward-compatabibility layer is included to ensure that any
legacy YUI event triggered on a form is still respected and the new
native event is also fired.

A similar handler is also included to ensure that any legacy YUI event
listener is still called with the same arguments.

These legacy bridges will be removed after Moodle 4.3.
2021-05-26 10:46:49 +08:00
Thong Bui f81cdd42b2 MDL-71644 Quiz: The issues outstanding from MDL-70947.
Issue 1: While essay question's uploading progress, we need to disable submit
buttons to prevent submit form event.

Issue 2: Enable buttons after pressing cancel button on the popup
confirming overwrite file existed.
2021-05-20 08:29:31 +07:00
Marina Glancy b46badb130 MDL-70926 core: getuserdate() shoud show debugging if null was passed
passing null to getdate() has different results in PHP7 and PHP8
2021-05-06 19:55:32 +02:00
Ilya Tregubov cf1cf222e7 MDL-66431 core: Fix behat tests.
Move activity creation to data generators. Only fixing those
tests failing due to removing usemodchooser preference.
2021-05-01 16:22:03 +02:00
Jun Pataleta c646a8eaec Merge branch 'MDL-70947-master' of git://github.com/HuongNV13/moodle 2021-04-30 10:34:11 +08:00
Sara Arjona 3a07ee3191 Merge branch 'MDL-60331-master_take3' of git://github.com/lucaboesch/moodle 2021-04-29 17:49:43 +02:00
Huong Nguyen c6fb80b639 MDL-70947 File upload: Upload protection
Interacts badly with double-submit protection, and not all uploads protected
2021-04-29 15:28:19 +07:00
Luca Bösch 7dd58aac64 MDL-60331 questions: prevent double escaping question categories. 2021-04-28 17:30:46 +02:00
Sara Arjona 92cfa71cd0 Merge branch 'MDL-70763' of git://github.com/paulholden/moodle 2021-04-28 12:36:23 +02:00
Víctor Déniz ab6f97292d Merge branch 'MDL-71087-master' of https://github.com/NashTechOpenUniversity/moodle 2021-04-19 23:44:06 +01:00
Paul Holden 3b9e53c7e1 MDL-70763 core: export preferences for correct user.
Ensure we are using the ID of the given user rather than falling
back to that of the current user during privacy export.
2021-04-04 23:15:23 +01:00
Andrew Nicols 91bd6289e2 Merge branch 'MDL-70962' of git://github.com/paulholden/moodle 2021-03-29 11:58:05 +08:00
Paul Holden 11099c15bb MDL-70962 forms: catch modal exceptions when getting body content.
They are thrown in the following circumstances:

 * The dynamic form class doesn't exist;
 * It does exist but it's `check_access` method throws exception

Co-Authored-By: Andrew Nicols <andrew@nicols.co.uk>
2021-03-25 17:26:36 +00:00
Andrew Nicols 9a9bf7f116 Merge branch 'MDL-71039-master' of git://github.com/marinaglancy/moodle 2021-03-23 11:17:44 +08:00
Thinh Pham 07cbbc9193 MDL-71087 File picker: Focus lost after 'Create folder' 2021-03-22 14:35:44 +07:00
Marina Glancy 960bb02482 MDL-71039 core_form: support valuehtmlcallback in autocomplete inline 2021-03-04 13:39:05 +01:00
Ilya Tregubov eaf40e050e MDL-69680 lib: Replace deprecated jQuery functions 2021-03-04 12:48:26 +08:00
Marina Glancy 612c230709 MDL-70966 various: Under PHP8 empty string is no longer equals to 0 2021-02-28 19:16:09 +01:00
Marina Glancy 1e03a240b5 MDL-64554 form: reset form change checker before triggering submit event 2021-02-18 13:04:14 +01:00
Andrew Nicols 7d5b808e3e Merge branch 'MDL-64554-master' of git://github.com/andrewnicols/moodle 2021-02-18 11:16:40 +08:00
Andrew Nicols 79731372c3 MDL-64554 core_form: Rename class for dynamic form 2021-02-18 11:16:21 +08:00
Andrew Nicols d6e50d14d2 Merge branch 'MDL-64554-master' of git://github.com/andrewnicols/moodle 2021-02-18 10:21:55 +08:00
Andrew Nicols ab70110a74 MDL-64554 core_form: CI fixes 2021-02-18 10:10:08 +08:00
Marina Glancy 72be49c473 MDL-64554 core_form: new API for modal forms 2021-02-17 18:06:49 +01:00
Andrew Nicols ab024ac209 Merge branch 'MDL-47410-master' of git://github.com/mihailges/moodle 2021-02-17 09:34:22 +08:00