Commit Graph

6 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7) 8a14a7bd22 MDL-71036 phpunit: assertContains() now performs strict comparison
The methods assertContains() and assertNotContains() now perform
strict (type and value) comparison, pretty much like assertSame()
does.

A couple of new assertContainsEquals() and assertNotContainsEquals()
methods have been created to provide old (non-strict) behavior, pretty
much like assertEquals() do.

Apart from replacing the calls needing a relaxed comparison to those
new methods, there are also a couple of alternative, about how to
fix this, depending of every case:

- If the test is making any array_values() conversion, then it's better
  to remove that conversion and use assertArrayHasKey(), that is not
  strict.
- Sometimes if may be also possible to, simply, cast the expectation
  to the exact type coming in the array. I've not applied this technique
  to any of the cases in core.

Link: https://github.com/sebastianbergmann/phpunit/issues/3426
2021-03-11 23:04:31 +01:00
Andrew Nicols 14d8cdcc35 MDL-66748 core_grading: Use new gradingform data providers 2019-09-24 21:04:14 +08:00
Adrian Greeve 980425022b MDL-63622 core_grading: Add support for removal of context users.
Core grading now implements the new core_userlist_provider
interface to allow for deletion of specific users in a context.
2018-10-29 07:37:44 +08:00
Adrian Greeve dfc5e6d10e MDL-62535 grading methods: Unit test update for fix. 2018-08-30 13:19:21 +08:00
Adrian Greeve 0aedccc973 MDL-62535 core_grading: Unit test for new methods. 2018-08-20 11:32:01 +08:00
Sara Arjona 6416e87f26 MDL-61951 grading: Implement privacy API 2018-05-09 22:41:04 +02:00