Commit Graph

581 Commits

Author SHA1 Message Date
Andrew Nicols d2cd91224f MDL-72108 js: Fix incorrect jsdoc examples for core/ajax 2021-07-08 10:39:44 +08:00
Tim Hunt 46ba8d9e70 MDL-68003 session timeout warning: don't show in iframes 2021-06-29 16:58:51 +01:00
Andrew Nicols 613cd69cbd MDL-71113 javascript: Improve basic JS Documentation 2021-06-18 09:38:05 +08:00
Andrew Nicols e214af5720 MDL-71113 js: Fix all jsdoc warnings 2021-06-18 09:38:05 +08:00
Andrew Nicols 42dc1464df Merge branch 'MDL-70846-311' of https://github.com/dcai/moodle into MOODLE_311_STABLE 2021-06-10 08:41:34 +08:00
Dongsheng Cai a246699a2b MDL-70846 accessibility: update tree attributes to pass a11y check
- Move aria-* atrributes from <p> to <li>
- Move "role" attribute from <p> to <li>
- Update behat tests

Based on reference implementation from:
- https://www.w3.org/TR/wai-aria-practices-1.1/examples/treeview/treeview-2/treeview-2a.html
- https://www.w3.org/WAI/GL/wiki/Using_ARIA_trees
2021-05-28 12:49:56 +10:00
Jun Pataleta bb662a7dc4 Merge branch 'MDL-71157-311' of git://github.com/sarjona/moodle into MOODLE_311_STABLE 2021-05-20 12:29:58 +08:00
Andrew Nicols 02bc9d32c3 MDL-71157 core: Pending JS in paged content bars 2021-05-19 12:34:51 +02:00
Dongsheng Cai 5464f37017 MDL-65203 template: tab should be quoted to produce valid json 2021-05-18 20:42:17 +10:00
Víctor Déniz c7e2a997a8 Merge branch 'MDL-71089-311' of git://github.com/roland04/moodle into MOODLE_311_STABLE 2021-04-13 19:40:09 +01:00
Mikel Martín 7c82ff41a3 MDL-71089 core: Add different Toast notification styling 'types' 2021-04-13 16:29:10 +02:00
Eloy Lafuente (stronk7) c1e84df96f Merge branch 'MDL-70802-311' of git://github.com/andrewnicols/moodle into MOODLE_311_STABLE 2021-04-08 18:34:10 +02:00
Paul Holden 35efccacee MDL-70962 forms: catch modal exceptions when getting body content.
They are thrown in the following circumstances:

 * The dynamic form class doesn't exist;
 * It does exist but it's `check_access` method throws exception

Co-Authored-By: Andrew Nicols <andrew@nicols.co.uk>
2021-03-25 17:26:33 +00:00
Andrew Nicols e36710af52 MDL-70802 javascript: Normalise component consistently in templates 2021-03-24 11:18:33 +08:00
Ilya Tregubov 4bc3faf193 MDL-69680 lib: Replace deprecated jQuery functions 2021-03-04 12:48:06 +08:00
Marina Glancy 1d33351fbb MDL-64554 core_form: new API for modal forms 2021-02-17 18:09:38 +01:00
Andrew Nicols bf9838f31c Merge branch 'MDL-69748-311' of git://github.com/rezaies/moodle into MOODLE_311_STABLE 2021-02-04 11:52:10 +08:00
Shamim Rezaie d9cfd2ecc5 MDL-69748 core: Fix hideif issue with array elements
Changed the element selector to get all array elements,
whether named or unnamed. The previus selector was only
working for elements that thir names were like name="something[]".
It was not working for name="something[a]" elements.
2021-02-04 14:38:37 +11:00
Sara Arjona d5923517e8 Merge branch 'MDL-70316-311' of git://github.com/mihailges/moodle into MOODLE_311_STABLE 2021-02-03 15:29:33 +01:00
Ilya Tregubov e1f6c22780 MDL-70304 core: updated adapter.js to 7.4.0 2021-02-02 08:59:09 +02:00
Mihail Geshoski ea2fac7ca2 MDL-70316 core: Upgrade emoji-data to 6.0.0 2021-01-27 13:37:47 +08:00
Sara Arjona fc67a37242 Merge branch 'MDL-70305-311' of git://github.com/peterRd/moodle into MOODLE_311_STABLE 2021-01-18 09:20:30 +01:00
Peter Dias 60c5c0e8df MDL-70305 lib: Update thirdpartylibs chartjs version 2021-01-14 07:55:25 +08:00
Peter Dias e193299876 MDL-70305 lib: Upgrade chartjs to 2.9.4 2021-01-14 07:55:25 +08:00
Sara Arjona e730802e08 Merge branch 'MDL-70299-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE 2021-01-13 17:20:00 +01:00
Jun Pataleta 5e4a7224a5 Merge branch 'MDL-70580-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE 2021-01-13 10:20:00 +08:00
Paul Holden 5f9c1e5dd2 MDL-70580 core: retrieve closest tree node in click handler. 2021-01-12 20:17:22 +00:00
Jun Pataleta 7ff1b6c79c Merge branch 'MDL-70580-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE 2021-01-12 13:15:50 +08:00
Andrew Nicols 1894ea0c5c MDL-70580 core: Tree nodes should check if they were clicked directly 2021-01-11 23:43:22 +00:00
Paul Holden 705bc7fdaa MDL-70299 libraries: upgrade to version 1.7.1 of loglevel. 2021-01-08 09:51:09 +00:00
Dmitrii Metelkin 571df8fe10 MDL-70352 core: attach modal to a specific element 2021-01-06 11:16:15 +11:00
Andrew Nicols d2ef283eb0 Merge branch 'MOODLE_311_MDL-65856' of https://github.com/hdagheda/moodle into MOODLE_311_STABLE 2020-12-22 09:41:48 +08:00
Heena Agheda 690d44219c MDL-65856 session: UX review of session timeout
Add new setting 'sessiontimeoutwarning', gives logged in user ability to extend session when there is no activity.
2020-12-21 09:11:10 +11:00
Sara Arjona cbee3f569c Merge branch 'MDL-69107-311-2' of git://github.com/andrewnicols/moodle into MOODLE_311_STABLE 2020-12-18 15:22:16 +01:00
Andrew Nicols 119977e663 MDL-69107 form_autocomplete: Rewrite item selection
The form_autocomplete is essentially a custom element. Unfortunately the
`setValue()` function in Mink has undesired actions so it is necessary
to write our own handling for it.

The standard Mink `setValue()` function focuses the element, sets a
value, and then blurs the element. In the case of the autocomplete this
can cause the autocomplete suggestions list to be closed in some
situations. Instead of using the setValue we click, and type the value,
but do not immediately blur.
2020-12-15 09:08:05 +08:00
Tom Dickman 761d070b76 MDL-67623 block overview: fix pagination regression
Fixed a regression caused by MDL-64194 resulting in Dashboard - Course
overview pagination not working from second page of courses onwards.

Course overview block should now do the following:
- Display no pagination controls when user has no courses
- Display no pagination controls when less than 12 courses to display
- Only display pagination controls up to the number of courses user is
enrolled in
- Work correctly when on a page greater than the second page.
2020-12-14 13:26:22 +11:00
Andrew Nicols 72e6bd78aa Merge branch 'MDL-70320_311' of https://github.com/timhunt/moodle into MOODLE_311_STABLE 2020-12-09 11:57:54 +08:00
Mihail Geshoski 671a566121 MDL-57614 core: Fetch blocks through a webservice in add block modal 2020-12-02 13:47:55 +08:00
Tim Hunt 7de93d7a6b MDL-70320 permission overrides: role names were double-escaped 2020-11-25 21:21:10 +00:00
Andrew Nicols 725a75e064 MDL-67513 core: Only move modal to body if currently attached
A previous change as part of this commitset was intended to move the
modal to the document.body, but where the modal had been destroyed it
was instead added back to the body.
2020-11-16 09:34:01 +01:00
Neill Magill 0c6d8a96ce MDL-67513 forum: View conversations while fullscreen grading
Before this change when a modal was shown and an element on the page
was fullscreen the modal would be created behind it.

This change ensures that the modal will be inside an element that is
fullscreen so that it will be correctly displayed.
2020-11-16 08:27:16 +08:00
Jun Pataleta 4c1fbc320f Merge branch 'MDL-70072-310' of git://github.com/rezaies/moodle into MOODLE_310_STABLE 2020-11-11 22:09:07 +08:00
Sara Arjona 05ef5c3c48 Merge branch 'MDL-70106-icon-cache-310' of https://github.com/Peterburnett/moodle into MOODLE_310_STABLE 2020-11-10 16:53:37 +01:00
Shamim Rezaie f6b7ed422a MDL-70072 core: Fix always displaying date in Gregorian 2020-11-06 19:23:11 +11:00
Andrew Nicols 27de77007b MDL-70075 core: Autocomplete selection should always have an active item
Ensure that there is always one active element in the list of selected
autocomplete elements.

Without this we have issues beacuse clicking on the link makes the first
one active if one is not already active, and this turns a click event
into a drag event, which means that it is not deleted.
2020-11-05 09:05:38 +08:00
Andrew Nicols 34d1c23668 MDL-70075 core: Do not return a value in an event handler
Returning a value of `false` in an event handler has the effect of
calling event.preventDefault() and event.stopPropagation().

This is neither obvious, nor desirable in this situation.
2020-11-05 09:05:38 +08:00
Andrew Nicols dc7ca062ca MDL-70075 core: jQuery.attr() does not accept a bool value
The documented values that jQuery.attr() accepts are String, Number, or
null. For some reason, when we pass a Boolean value, the subsequent
click handler does not work in some situations.

Changing this to take a Number, and unsetting it when empty, resolves
this issue.
2020-11-05 09:05:38 +08:00
Andrew Nicols 8100d46f85 MDL-70075 core: Listen for change in accessibleChange event
The accessibleChange custom interaction event was only listening for
blur and focus, however some OS/browser combinations do not emit these
events until the element is explicitly blurred. This is notably
different on Firefox on some Operating Systems.

Recent changes in MDL-68167 explicitly moved the user participants page
filter module to use the accessibleChange event, which means that the
selections are now only triggered on an explicit blur when using
Firefox. This highlight a bug whereby, when the mouse is used to make a
selection, the event is not triggered until the element is blurred.

This change modifies the accessibleChange event to ignore the `change`
event where it was triggered by the keyboard and where that keybaord
event was not a [return] or [escape] keypress, but to otherwise respect
the native change event.
2020-11-05 09:05:38 +08:00
Andrew Nicols f4dfe66ea8 MDL-70075 core: Listen for the focus and blur events again
The `blur` event does not bubble, but the `focusout` events are not
available in all supported versions of Firefox.

Rather than switching event, this patch using event capture to
effectively achieve the same result and bubble the event up through the
DOM to the delegated listener.

There should be no functional change with this patch, except to support
Firefox fully.
2020-11-05 09:05:38 +08:00
Peter Burnett 3885c566aa MDL-70106 cache: Set icon localstorage cache to use theme localisation 2020-11-04 13:33:23 +10:00