c415eed491
MDL-79920 factor_email: String changes for email factor
2024-04-05 10:10:09 +11:00
a64b26cb86
MDL-79920 factor_sms: Improvements to the sms setup
...
Unlike other configurable factors, sms factor is not yet compatible
with the newly introduced replace action.
2024-04-05 10:10:09 +11:00
dbef09ab19
MDL-79920 factor_totp: Improvements to the totp setup
2024-04-05 10:10:09 +11:00
71a5622c71
MDL-79920 factor_webauthn: Improvements to the webauthn setup
2024-04-05 10:10:09 +11:00
361dfe8145
MDL-75952 general: Since php81, refection->setAccessible() is no-op
...
Refereces:
- https://wiki.php.net/rfc/make-reflection-setaccessible-no-op
- https://www.php.net/manual/en/reflectionproperty.setaccessible.php
- https://www.php.net/manual/en/reflectionmethod.setaccessible.php
As of PHP 8.1.0, calling this method has no effect; all methods are
invokable by default. So, let's remove all uses from core, they are
no-op.
2024-03-10 21:15:00 +01:00
3278ce7aba
Merge branch 'MDL-65292' of https://github.com/stronk7/moodle
2024-03-08 08:00:41 +08:00
3020fac005
Merge branch 'MDL-80736_main' of https://github.com/marxjohnson/moodle
2024-02-29 09:54:06 +07:00
ba1f804ffa
MDL-65292 style: Fix all function declarations white space
...
This has been generated running the following Sniffs, all
them part of the Moodle's CodeSniffer standard:
- PSR12.Functions.ReturnTypeDeclaration
- PSR12.Functions.NullableTypeDeclaration
- moodle.Methods.MethodDeclarationSpacing
- Squiz.Whitespace.ScopeKeywordSpacing
All them are, exclusively, about correct spacing, so the changes
are, all them, only white space changes.
Only exceptions to the above are 3 changes what were setting the
return type in a new line, and, when that happens, the closing
parenthesis (bracket) has to go to the same line than the colon.
2024-02-28 23:33:26 +01:00
c424ba34e2
MDL-80725 tool_mfa: Apply en_fix to Behat tests
...
Also use the appropriate Behat tags `@tool @tool_mfa @factor_sms`
instead of `@tool_admin_mfa`.
2024-02-06 16:00:00 +08:00
ddbfeecb83
MDL-80725 lang: Import fixed English strings (en_fix)
2024-01-31 18:45:03 +01:00
2f351c5a8e
MDL-80736 libraries: Move AWS helper code from factor_sms to core\aws
2024-01-29 09:15:19 +00:00
10a8e9536e
MDL-78511 tool_mfa: Fix version for sms plugin.
2023-12-14 08:34:09 +08:00
e894123a4d
MDL-78511 tool_mfa: SMS factor include behat tests anf fix validation
2023-12-12 10:49:30 +01:00
9e6b1b9118
MDL-78511 tool_mfa: Refactor SMS factor code
...
In this patch I have refactor the SMS factor code
to not require local_aws as a dependency.
Namespaces and paths from clases copied
from local_aws adapted to the new location.
2023-12-12 10:36:40 +01:00
d35330a49e
MDL-78511 tool_mfa: Include useful code from local_aws
...
In this patch we have included some useful classes implemented
In the plugin local_aws developed by Catalyst
2023-12-08 15:27:05 +01:00
0773c553ec
MDL-78511 tool_mfa: Include SMS factor into core
...
In this patch we have included the SMS factor from "tool_mfa"
developed by Catalyst.
Co-authored-by: Peter Burnett <peterburnett@catalyst-au.net >
Co-authored-by: Misha Golenkov <golenkovm@gmail.com >
Co-authored-by: Brendan Heywood <brendan@catalyst-au.net >
Co-authored-by: Alex Morris <alex.morris@catalyst.net.nz >
Co-authored-by: Dan Marsden <dan@danmarsden.com >
Co-authored-by: Kevin Pham <kevinpham@catalyst-au.net >
Co-authored-by: Chris Pratt <tonyyeb@gmail.com >
Co-authored-by: Andrew Lyons <andrew@nicols.co.uk >
Co-authored-by: Tomo Tsuyuki <tomotsuyuki@catalyst-au.net >
Co-authored-by: Liam Kearney <https://github.com/LiamKearn >
Co-authored-by: Nicholas Hoobin <nicholashoobin@catalyst-au.net >
Co-authored-by: Scott Verbeek <scottverbeek@catalyst-au.net >
Co-authored-by: nomisge <https://github.com/nomisge >
Co-authored-by: Dmitrii Metelkin <dmitriim@catalyst-au.net >
Co-authored-by: Matthew Hilton <matthewhilton@catalyst-au.net >
Co-authored-by: Michael Geering <https://github.com/dryj >
Co-authored-by: alphadijkstra <https://github.com/alphadijkstra >
2023-12-08 15:27:05 +01:00
04bc690557
Merge branch 'MDL-80221-main-enfix' of https://github.com/mudrd8mz/moodle
2023-12-04 16:12:07 +08:00
de4f02d809
MDL-80221 lang: Import fixed English strings (en_fix)
2023-11-22 22:48:47 +01:00
525212f2d2
MDL-78496 core: Address phpcs issues with upgrade.php files
2023-11-19 21:20:53 +08:00
9beff03a96
MDL-79626 upgrade: add the 4.3.0 separation line to all upgrade scripts
2023-10-10 10:44:17 +08:00
94bc2cd38b
MDL-79551 versions: bump all versions and requires near release
2023-10-04 13:57:17 +08:00
0d6fb2546d
MDL-79344 tool_mfa: Use core/log for factor_webauthn
2023-10-02 11:41:53 +07:00
492fded0ec
MDL-79344 tool_mfa: Fixed factor_webauthn request timeout handler
2023-09-28 15:48:34 +08:00
13b7ea5d44
MDL-79323 lang: Import fixed English strings (en_fix)
2023-09-19 10:24:37 +01:00
77a998006f
MDL-78534 Authentication: MFA factor updates for UI
...
Add additional display logic to factor classes.
Update each individual factor class and the based factor classs
with the ability to nominate an icon associated with the factor
type as well as any additional logic to assist with displaying
factor information during the login process. This includes string
updates.
2023-09-14 11:49:35 +10:00
3b160c7b71
MDL-79241 tool_mfa: correctly setup standard plugin type
2023-09-06 09:14:25 +01:00
227a2f8e9c
MDL-79051 Authentication: MFA Improve email template
...
Improve the layout, display and information architecture of
the email sent that contains the code for the email MFA factor.
2023-09-01 10:09:54 +07:00
33d04612cd
MDL-78509 tool_mfa: Improve PHPUnit for factor_cohort and factor_role
2023-08-29 10:39:58 +07:00
00db83d1bf
MDL-78509 tool_mfa: Fixes based on the report and other issues
...
In this commit, there are couple of fixes based on the report:
1. Removed legacy polyfill from provider.php
2. Fixed phpunit warning detected by CodeChecker
3. Removed unused files
4. Fixed the PHPunit failures by removing "securityquestions"
from the data_provider due to it has not been included as one of the factors
5. Added PHPunit test to the factors that can be unittested
6. Removed !important rule from tool_mfa/styles.css
7. Added (int) type to sleep method within sleep_timer method due to a php deprecation
in too_mfa/classes/manager.php
8. Changed last param form bool to string in not_enough_factors() when initiating
a new single_button object in tool_mfa/renderer.php
9. Add explanation text to login page
10. Fixed "Access to an undefined property .." from PHPStan
12. Fixed all the "Variable $.. might not be defined" from PHPStan
13. Fixed the issue from https://github.com/catalyst/moodle-tool_mfa/issues/379
2023-08-29 11:06:44 +08:00
63d8cfcf87
MDL-78509 lib_webauthn: Moved webauthn to lib
...
It was suggested to move the WebAuthn library form
admin/tool/mfa/webauthn/.extlib to lib/webauthn
2023-08-29 11:06:44 +08:00
a639783409
MDL-78509 tool_mfa: Boarded the tool_mfa into core
...
In this patch the "commitid" of the "upstream" has been included in this
commit. Also, we did not include three factors, which are SMS, Security
Questions and Login Banner.
Co-authored-by: Peter Burnett <peterburnett@catalyst-au.net >
Co-authored-by: Misha Golenkov <golenkovm@gmail.com >
Co-authored-by: Brendan Heywood <brendan@catalyst-au.net >
Co-authored-by: Alex Morris <alex.morris@catalyst.net.nz >
Co-authored-by: Dan Marsden <dan@danmarsden.com >
Co-authored-by: Kevin Pham <kevinpham@catalyst-au.net >
Co-authored-by: Chris Pratt <tonyyeb@gmail.com >
Co-authored-by: Andrew Lyons <andrew@nicols.co.uk >
Co-authored-by: Tomo Tsuyuki <tomotsuyuki@catalyst-au.net >
Co-authored-by: Liam Kearney <https://github.com/LiamKearn >
Co-authored-by: Nicholas Hoobin <nicholashoobin@catalyst-au.net >
Co-authored-by: Scott Verbeek <scottverbeek@catalyst-au.net >
Co-authored-by: nomisge <https://github.com/nomisge >
Co-authored-by: Dmitrii Metelkin <dmitriim@catalyst-au.net >
Co-authored-by: Matthew Hilton <matthewhilton@catalyst-au.net >
Co-authored-by: Michael Geering <https://github.com/dryj >
Co-authored-by: alphadijkstra <https://github.com/alphadijkstra >
2023-08-29 11:06:44 +08:00
David Woloszyn