Commit Graph

65 Commits

Author SHA1 Message Date
Tim Hunt 6760e6db34 MDL-53938 qformat_gift: handle multi-choice MR with one 100% choice 2016-05-27 21:28:46 +01:00
Tim Hunt f41269f31d MDL-46331 GIFT question import was breaking content inside <pre>.
Also, adding a Behat tests to verify GIFT import works without errors
(but leaving the detailed testing for the unit tests).
2014-09-09 22:59:04 +01:00
Tim Hunt f4fe3968a2 MDL-46212 questions: add {} whenver vars are put into "" strings
Having had one subtle bug cased be this, I decided to do a search and
fix all of these.
2014-07-03 14:02:39 +01:00
Kyle Temkin a4f765eb1d MDL-39756 add advanced attachment options to essay question type
Adds a set of options to the essay question type which implement
the following new features:

-Adds an input format which accepts only file uploads, and no
 inline text.
-Adds an option to make the inline text response optional when
 attachments are enabled, so students can choose to upload
 an essay file.
-Adds an option to make attachments required, so essays without
 attachments will be marked incomplete.
2014-01-15 12:43:04 -05:00
Jean-Michel Vedrine d2fd7262af MDL-39404 Update question/format files to match codechecker standards 2013-07-26 21:32:34 +02:00
Dan Poltawski ba26ed9cac Merge branch 'MDL-39283' of git://github.com/jmvedrine/moodle 2013-04-24 14:33:00 +01:00
Jean-Michel Vedrine b31d6664e6 MDL-39283 GIFT and XML question export broken for unsupported qtypes
Do no write any data to the export for unsupported qtypes
2013-04-23 09:42:53 +02:00
Jean-Michel Vedrine cdcda6a0b4 MDL-39164 GIFT, Blackboard and Examview import of essay questions broken 2013-04-18 17:36:18 +02:00
Tim Hunt cacb8fa08a MDL-34841 error importing questions with long names.
The problem was with the non-UTF-8-safe way that a question name
was being constructed from the question text.

I have done a proper fix with methods in the base class to
carefully construct a question name that is reasonable, and
which will fit in the database column. Then I have changed all
importers to use the new methods.

I also remembered not to break the lesson in the process.
2012-09-11 15:04:00 +01:00
Tim Hunt e231a3ffa2 MDL-27799 question bank: remove last traces of qtype constants.
Using consants to refer to plugin names is crazy. The whole point of
plugins is that you can install more, hence the list of constants will
never be complete.
2012-08-30 13:15:52 +01:00
Eloy Lafuente (stronk7) 14941785d7 Merge branch 'MDL-25492' of git://github.com/jmvedrine/moodle 2012-08-28 20:02:02 +02:00
Tim Hunt 19de315e83 MDL-34306 gift question format: allow import of general feedback
This change introduces #### as a separator for general feedback. You need
to add ####General feedback goes here as the last thing inside the {...}.
For example

// question: 123  name: Shortanswer
::Shortanswer::Which is the best animal?{
    =Frog#Good!
    =%50%Cat#What is it with Moodlers and cats?
    =%0%*#Completely wrong
    ####Here is some general feedback!
}

Note that this change is not entirely backwards compatible. It will break
any existing GIFT file where the character sequence #### us used between the
{} as part of the question. This seems highly unlikely.
2012-08-25 14:27:40 +01:00
Jean-Michel Vedrine 7ace84e069 MDL-25492 Blackboard V6+ question import is broken. 2012-08-24 13:27:45 +02:00
Tim Hunt d9299c349e MDL-34171 qformat_gift: Fix edge case with special character escaping.
We need to escape \ on export, because it is un-escaped on import.
2012-07-04 10:55:52 +01:00
Tim Hunt 0519420f59 MDL-28349 error when GIFT-importing essay questions. 2011-08-15 16:17:16 +01:00
Tim Hunt 3c78184552 MDL-27974 problems with gift question import/export.
Double-escapeing in match export and not initialising combined feedback on import.

Also remove a lot of redundant breaks.
2011-06-22 15:26:34 +01:00
Tim Hunt 9c197f4445 MDL-20636 Fix some more codechecker issues. 2011-05-14 22:53:25 +01:00
Tim Hunt c7df5006b9 MDL-20636 Add lots of missing public/protected/private. 2011-03-23 16:22:25 +00:00
Tim Hunt d649fb0221 MDL-20636 Remove all references to global $QTYPES.
Except in the question types that have not yet been converted to the new question engine.
2011-02-24 15:29:07 +00:00
Tim Hunt 5e8a85aa64 MDL-20636 Massively reduce the number of references to quiz in the question code.
This mostly involves moving lang strings around, but I don't have time to do an AMOS script now.
2011-02-23 18:53:50 +00:00
Tim Hunt f7970e3ca7 MDL-20636 Eliminate integer and boolean in PHPdoc comments. should be int and bool. 2011-02-23 16:25:25 +00:00
Tim Hunt a17b297d60 MDL-20636 Add missing defined('MOODLE_INTERNAL') || die(); 2011-02-23 16:00:20 +00:00
Tim Hunt d3603157bf MDL-20636 Add @package and GPL boiler-plate to files in /question. 2011-02-22 19:59:12 +00:00
Tim Hunt 74c479f212 MDL-20636 Merge branch 'master' into qe2_wip
Conflicts:
	lib/questionlib.php
	question/type/calculated/lang/en/qtype_calculated.php
	question/type/questiontype.php
2011-02-03 11:18:40 +00:00
Tim Hunt 2c00fa161e qformat_gift MDL-26059 fails to import truefalse questions with answer true. 2011-01-18 21:38:34 +00:00
Tim Hunt 49e2bba7cc MDL-20636 Merge import/export formats. XML is not finished (unit test failures). 2011-01-17 18:01:49 +00:00
Tim Hunt d1b7e03d5d MDL-20636 Current work-in-progress converting the question engine to Moodle 2.0 2011-01-13 18:35:29 +00:00
Tim Hunt b80d424c50 question export MDL-25324 Better file names for question exports. 2010-11-19 11:02:28 +00:00
Tim Hunt 5b744492a6 gift import/export MDL-25088 another attempt at fixing it, this time with unit tests. 2010-11-19 10:27:29 +00:00
Tim Hunt 13bb604ed5 question export MDL-25088 this is the first part. I think question export is now working for all types.
Import to follow soon.
2010-11-12 12:06:48 +00:00
Petr Skoda aeb15530b8 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-04 11:57:52 +00:00
nicolasconnault fef8f84e4b MDL-19822 Upgraded calls to helpbutton, print_simple_box* and notify 2009-08-18 05:19:00 +00:00
nicolasconnault 6dbcaceef1 MDL-19418 Replaced ereg* by preg* 2009-06-22 01:22:37 +00:00
tjhunt c32f2e5c64 gift import: MDL-18390 better way to get the question type name. 2009-03-12 06:00:55 +00:00
thepurpleblob f040135da5 MDL-18390 - now correctly looks up name of questiontype from language pack
Merged from STABLE19
2009-03-11 13:16:54 +00:00
thepurpleblob c05878500b MDL-18390:
Correctly report unhandled question types and get string from language pack.
2009-03-03 15:36:17 +00:00
skodak 294ce9870f MDL-15189 magic quotes finally removed 2008-06-09 16:53:30 +00:00
thepurpleblob 3f5633df11 MDL-14406
Ensure 'length' field for description type questions is 0 and that
default for all questions is 0

Merged from STABLE_19
2008-05-01 12:21:55 +00:00
toyomoyo 3ea69b8d43 MDL-12346, lesson module GIFT import fails 2007-11-29 04:31:57 +00:00
tjhunt 0d4c63d7fb MDL-11825 - Force penaltyfactor to 1 for truefalse questions on GIFT import, as is done on the editing form. Merged from MOODLE_18_STABLE. 2007-10-25 09:43:06 +00:00
thepurpleblob 0db7823cf9 MDL-11769:
question name is properly truncated to less than 255 characters tom
stop PostGRES choking.
2007-10-15 13:50:57 +00:00
thepurpleblob 13e88db4a2 MDL-10819:
GIFT now exports grade fractions for numeric questions

Merged from STABLE_18
2007-08-20 10:36:30 +00:00
thepurpleblob d510ec64b6 MDL-10902:
Whoops! Overwrote question object. Variable name changed
Thanks to Adriane Boyd for spotting that one.

Merged from STABLE_18
2007-08-18 09:33:45 +00:00
thepurpleblob 4433fff5a8 Moved check for plugin import/export to the start rather than the end
Merged from STABLE_18
2007-08-17 09:47:51 +00:00
thepurpleblob 64de04fb09 Added hooks to qtype import/export 2007-08-09 14:12:12 +00:00
thepurpleblob e8825e724b MDL-10531:
GIFT now handles Essay and Description type questions. See help/docs.

Merged from STABLE_18
2007-07-21 07:39:22 +00:00
pichetp 41a89a0748 Give the question bank code sensible PHPdocumentor package names. 2007-03-20 02:10:26 +00:00
thepurpleblob 532344b2cc Fixed some hardcoded strings in GIFT format. 2007-03-14 14:09:57 +00:00
thepurpleblob f37015613c MDL-8898
Improvements to error handling in question bank import/export.
2007-03-14 13:03:57 +00:00
thepurpleblob 7939a4a0cb MDL-8563
$question->answer was swapped for $question->correctanswer in questiontype
for some reason! Compensated for in format type.
2007-02-21 14:20:46 +00:00