Commit Graph

359 Commits

Author SHA1 Message Date
Jun Pataleta 3f1e893a17 Merge branch 'MDL-80374-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE 2024-01-22 16:29:48 +08:00
Ilya Tregubov f82c0f1a4b MDL-80394 core_grades: Revert changes to graded_users_iterator
Third party plugins are using it and change was breaking it
2023-12-13 09:38:21 +08:00
Paul Holden a86fac1edb MDL-80374 grade: show localised plugin name in report column heading. 2023-12-11 10:35:04 +00:00
Huong Nguyen 9378404bc3 Merge branch 'MDL-68652-402-1' of https://github.com/ilyatregubov/moodle into MOODLE_402_STABLE 2023-12-07 09:32:29 +07:00
Ilya Tregubov 28f37199f4 MDL-68652 core_grades: Only return allowed fields.
Grade iterator should check user permissions.
2023-12-07 09:13:26 +08:00
Ilya Tregubov 5ad9b4ae57 MDL-68652 mod_forum: Only include gradable users in grading 2023-12-06 12:46:42 +08:00
Ilya Tregubov 175eb51e18 MDL-68652 core_grades: Refactor grades functions.
get_gradable_users now has extra param to retrieve only active
users. Grade reports hase their own grade_report::get_gradable_users
since they decided whether to inlcude active users from report preferences
2023-12-05 10:52:55 +08:00
Jun Pataleta 8754e9c76e MDL-80043 grade: editingmode_title support for grade report plugins
* Add support for grade report plugins that define an
`editingmode_title` lang string. If the grade report plugin defines this
 language string, it will be used for the page title's unique
 identifying information when editing mode is turned on.
2023-12-01 09:11:47 +08:00
Jun Pataleta e372e143ca MDL-80043 grade: Use heading parameter for the page title if provided 2023-12-01 09:11:46 +08:00
Jun Pataleta ac6f82440a MDL-80121 grade: Trim heading
In order to prevent rendering an empty heading <h2>, we need to make
sure that the $heading parameter passed to print_grade_page_head() is
not an empty string.
2023-11-15 19:29:01 +08:00
Ilya Tregubov f0c782c87c MDL-78775 core_grades: Fix saving on grader report page
When we have a pagination on grader page and search for user
that is not on first page, saving was throwing an error
since page didn't have enough data
2023-10-13 14:20:11 +08:00
Jun Pataleta 1ece6f4295 MDL-79047 grade: Use the gradebook plugin name for the page title
* Use the appropriate gradebook plugin string for the page title.
* Improve gradebook page titles set by grade_get_plugin_info() by
listing the unique identifying information for the page first
(e.g. the gradebook plugin name), followed by broader information
(Grades + Course name), separating these bits of information using the
pipe `|` character.

For more information, check out
https://www.w3.org/WAI/WCAG21/Techniques/general/G88
2023-09-18 03:45:02 +02:00
Shamim Rezaie 3693a22ed7 MDL-78082 core_grades: lock/unlock all option for grade categories
A lock/unlock option is added to the context menu of the grade
categories again. But it is only used as an auxiliary tool to lock or
unlock all the grade items within the category.
2023-09-07 05:52:30 +10:00
Shamim Rezaie d2d8d16c2a MDL-78082 core_grades: Hide lock/unlock options for grade categories
Problem:
The grade_categories table lacks a 'locked' field, making it technically
impossible to lock grade categories. In Moodle 4.1, the "category total"
column could be locked (from the edit category form), but locking grade
categories directly was not supported.

Solution:
In response to the issue, the lock/unlock feature for grade categories
has been removed. Since the grade_categories table does not have the
necessary 'locked' field, attempting to implement category locking would
be infeasible. As a result, the feature has been removed from the
interface to avoid confusion.

Explanation:
By removing the lock/unlock feature for grade categories, we ensure that
users no longer encounter non-functional options and prevent any
potential misunderstandings about the locking behaviour. Additionally,
this change aligns the user interface with the underlying database
schema and eliminates any misleading functionality.
2023-09-07 05:50:09 +10:00
Jun Pataleta c2f25b7778 MDL-79045 grade: Don't enclose grade user_heading in $OUTPUT->heading()
Do not enclose \core_grades_renderer::user_heading() in
$OUTPUT->heading() and enclose the user's name in the user heading in
<h2> tags instead.
- Having <div> inside <h2> results in errors in HTML validation.
- Enclosing the whole user heading in <h2> results in the other
elements in the user heading (Message, Add to contacts) to be announced
to screen readers which can result in confusion.
2023-08-31 09:23:20 +08:00
Jun Pataleta 997d5e44a8 MDL-78550 grade: Avoid rendering an empty <h2> heading 2023-07-28 17:25:21 +08:00
Ilya Tregubov 2ad8691f81 Merge branch 'MDL-77375-402' of https://github.com/rezaies/moodle into MOODLE_402_STABLE 2023-07-06 09:20:36 +08:00
Shamim Rezaie 91acee489d MDL-77375 core_grades: set boundary of the dropdowns in grade setup page 2023-07-02 00:05:18 +10:00
Mihail Geshoski 932ebd1c2e MDL-76445 grade: Helper that returns all gradable users in a course 2023-06-13 15:14:21 +08:00
Paul Holden b97ffab51a MDL-77936 grade: omit second cell action divider when not required. 2023-04-27 08:42:52 +01:00
Paul Holden 44e3cb05e5 Merge branch 'MDL-77324-master-2' of https://github.com/ilyatregubov/moodle 2023-04-17 11:05:55 +01:00
Sara Arjona 9ce4fb65fd Merge branch 'MDL-77164-master' of https://github.com/marinaglancy/moodle 2023-04-13 14:00:18 +02:00
Marina Glancy 8fc1486d36 MDL-77164 various: fix incorrect phpdocs 2023-04-13 11:35:06 +01:00
Ilya Tregubov 0fdd514f11 MDL-77324 gradereport_singleview: Make action menus consistent 2023-04-13 16:57:48 +08:00
Mathew May 1a1939ac29 MDL-75274 gradereport_grader: Column collapsing 2023-04-13 11:45:17 +08:00
Ilya Tregubov 277b55199e MDL-75274 gradereport_grader: Fix sorting of grade items.
Seems that baseurl is rewritten causing toggling of ordering
not work
2023-04-13 10:42:04 +08:00
Kevin Percy b976b3bed0 MDL-77030 gradereport_grader: Display feedback in grader report 2023-04-11 13:16:06 +08:00
Ilya Tregubov 51182b603b MDL-77033 core_grades: Deprecate get icons functions.
We don't use those anymore. There are respective functions to get
link without icon.
2023-03-30 20:20:10 +08:00
Ilya Tregubov 11b6dce50c MDL-77033 core_grades: Add status column to setup page
Also make action menu consistent with grader report
2023-03-30 20:20:10 +08:00
Ilya Tregubov 9ba802ca0c MDL-77033 cores_grades: Refactor cell menus to be reusable.
We need similar menus on gradebook setup page. So moving from
grader plugin to core
2023-03-30 20:20:10 +08:00
Ilya Tregubov fc9583bae1 MDL-77029 gradereport_grader: Add sorting to grade item columns 2023-03-28 11:22:42 +08:00
Ilya Tregubov 7656f5b6b0 MDL-76147 gradereport_grader: Move grade items and categories icons to action menu. 2023-03-24 09:26:45 +08:00
Paul Holden 6a62ccc52a MDL-77472 grade: correct URL param type for adding tracking params. 2023-03-05 20:06:40 +00:00
Ilya Tregubov 29c220583f MDL-76146 gradereport_grader: Move action icons to action menu. 2023-02-17 11:34:09 +08:00
Ilya Tregubov a08282a872 MDL-75455 gradereport_singleview: PR review fixes.
Part of: MDL-75423
2022-11-11 10:52:26 +08:00
Ilya Tregubov 678a2bc29b MDL-75423 gradereport_singleview: Styling fixes. 2022-11-10 22:43:14 +08:00
Shamim Rezaie e2d389c37e MDL-75423 gradereport_singleview: Show custom user header 2022-11-10 22:43:13 +08:00
Shamim Rezaie 36f6390692 MDL-75423 gradereport_singleview: Replace grade analysis icon with menu 2022-11-10 22:43:13 +08:00
Mihail Geshoski 458c1c771b MDL-75513 core_grades: New method that returns the grade item string
Introduces a new method get_element_type_string() in grade/lib.php
which returns the appropriate string that describes the type of the
grade item element.
2022-11-02 17:47:02 +08:00
Mathew May e7c1c2841d MDL-75362 gradereport_user: Roll in zero state work for user report 2022-10-20 21:24:51 +08:00
Mathew May 547bf73ea7 MDL-75362 gradereport_user: CiBot 2022-10-20 21:24:51 +08:00
Ilya Tregubov b3e05d0e4e MDL-75156 gradebook: Grade summary plugin (grade averages).
Also included updates for existing unit tests and navigation.
2022-10-07 11:31:41 +04:00
Paul Holden 7ee1dc421f MDL-74282 grade: omit outcomes report if outcomes aren't enabled. 2022-07-08 10:43:38 +01:00
Andrew Nicols 4b388fc239 MDL-74235 core: Update core uses of activity icons to monologo 2022-04-07 12:56:14 +08:00
Mihail Geshoski b4e8e0a50d MDL-72873 core_grades: Create method that resets all static caches
Creates a new method reset_caches() in grade_helper which resets
all static caches within this class. This is required for unit
testing.
2021-12-16 00:10:13 +08:00
Mihail Geshoski 95b35652d3 MDL-72873 core_grades: Deprecate unused methods
The functions grade_print_tabs() and print_grade_plugin_selector()
can be deprecated as they are no longer used. These functions were
used to generate and output the tabs and dropdown box navigation
in gradebook which is now replaced with tertiary navigation.
2021-12-16 00:10:13 +08:00
Mihail Geshoski d1a0e4a95c MDL-72873 core_grades: Add general tertiary navigation 2021-12-16 00:10:13 +08:00
abgreeve d02274137a MDL-72090 navigation: Create an overflow menu for course admin.
This adds a select menu for navigation on course administration
 pages such as import, export, course copy, and course reset.
2021-12-09 11:13:35 +08:00
Marcus Boon d4a48daa9b MDL-70862 gradebook: Add callback so that we can add tabs in gradebook 2021-09-24 11:06:41 +10:00
Luca Bösch aa9a591ecd MDL-70433 grades: prevent double escaping in titles 2021-08-27 10:56:20 +02:00