I finally was able to see the HTML Editor bug in IE/XP that everyone
was talking about, and it's a very serious bug as it makes Moodle 1.3
almost unusable for these people. :-( :-(
So, I eventually found out that the problem is that the Javascript that
attaches the editor has troubles when it is embedded within the table that course/mod.php puts around the mod.html forms in each module.
(Only in IE and only sometimes, mind you).
While testing I also had a good look at a long standing issue which is the
inconsistency of the mod.html forms when using the editor.
So, to fix both I decided to put the HTML editor calls OUTSIDE the mod.html
in the mod.php file. This means that all modules get the HTML editor by default
on all text areas during activity module setup by default.
I've been running through this for the past few hours and it seems
pretty stable now and a lot more consistent, so I'm checking it in
as big fix towards the Moodle 1.3.1 we have to have.
Unfortunately it also means the API has changed a bit ... I had to
update all the module dependencies to this exact version (or later).
Please test this "stable" version hard using the standard modules only
and I'll merge these changes over to the trunk in a day or so and update
all known third-party modules.
These are the changes from MOODLE_13_STABLE, merged into trunk
The tag MOODLE_13_MERGED on the MOODLE_13_STABLE branch now refers to this point
The biggest changes here are the fixes for HTML editor in all standard modules
Moodle tables.
ie user -> userid in many tables, plus in user_students
start -> starttime and end -> endtime
I've just done all this as carefully as I could ... I don't think
I missed anything but it's pretty intensive work and I'd be fooling myself
if I didn't think I'd missed a couple.
Note that this version should pretty much be able to bootstrap itself
using PostgreSQL now ... but this is untested
This type of assignment doesn't require anything of the student online,
it just tells them about an assignment and the teacher can provide
feedback and grades. Useful for offline activities, and also for the
teacher to add manual columns to the grades page
where data from other modules can also live later on.
Also added a README for that directory to warn teachers not to mess
with it, version code to perform the upgrade, tweaks to assignment/lib.php
and a tweak to reading module so that assignment files aren't listed
in the list of possible readings (could get messy).
Basically the changes are:
- I've merged the 'discuss' module into the forum module
which makes the interface MUCH clearer for everyone
- I've added a new 'single' forum type that replicates
what the old discuss course modules used to look like.
- I've got rid of the "discussion" forum type - it will
still exist in upgraded courses but as a normal forum.
- the 'discuss' module is completely deleted - gone.
- the 'chat' module is completely deleted - gone.
- The upgrading system has been improved, and all code
is stored in version.php.
- I've put in upgrading commands to do the best I can
(right now) to upgrade courses that used the discuss
module. It should mostly work, just leaving some
"orphan" coursemodules on you course front page. You
can easily delete these using the little 'x'.
I may have forgotten something - I've only tested on
my testing server and I'm about to test on my production
server to see how it goes.
- Forums have a lot of little new features and fixes. The
main one is the subscription process. Teachers can 'force'
subscriptions on any forum. This disallows everyone from
choosing their own mail subscription - it's just on.
- The assignment module is half-finished and not working yet
I've still some massive changes to do, mostly involving making
all the lib.php function names more standardised, so consider
this is an interim checkin to do some tests.
moodler